[INFO] crate domain-core 0.3.0 is already in cache [INFO] extracting crate domain-core 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/domain-core/0.3.0 [INFO] extracting crate domain-core 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/domain-core/0.3.0 [INFO] validating manifest of domain-core-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of domain-core-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing domain-core-0.3.0 [INFO] finished frobbing domain-core-0.3.0 [INFO] frobbed toml for domain-core-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/domain-core/0.3.0/Cargo.toml [INFO] started frobbing domain-core-0.3.0 [INFO] finished frobbing domain-core-0.3.0 [INFO] frobbed toml for domain-core-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/domain-core/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting domain-core-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/domain-core/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5574c2207935ebd90ac8fe944e71d9d22f7d779403870d0fc39f829a13f7e94 [INFO] running `"docker" "start" "-a" "e5574c2207935ebd90ac8fe944e71d9d22f7d779403870d0fc39f829a13f7e94"` [INFO] [stderr] Checking domain-core v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/name/parsed.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | #[allow(len_without_is_empty)] // Clippy: It is never empty. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/opt/rfc7830.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | #[allow(len_without_is_empty)] // It’s not that kind of len. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/opt/mod.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/record.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | #[allow(type_complexity)] // I know ... [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/record.rs:445:13 [INFO] [stderr] | [INFO] [stderr] 445 | #[allow(type_complexity)] // I know ... [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/record.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | #[allow(type_complexity)] // I know ... [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/serial.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | #[allow(should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/reader.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/scan.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | #[allow(wrong_self_convention)] // XXX Continue changing. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rdata/rfc4034.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | #[allow(too_many_arguments)] // XXX Consider changing. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/name/parsed.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | #[allow(len_without_is_empty)] // Clippy: It is never empty. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/opt/rfc7830.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | #[allow(len_without_is_empty)] // It’s not that kind of len. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/opt/mod.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | #[allow(len_without_is_empty)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/record.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | #[allow(type_complexity)] // I know ... [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/record.rs:445:13 [INFO] [stderr] | [INFO] [stderr] 445 | #[allow(type_complexity)] // I know ... [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/record.rs:459:13 [INFO] [stderr] | [INFO] [stderr] 459 | #[allow(type_complexity)] // I know ... [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/serial.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | #[allow(should_implement_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/reader.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/scan.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | #[allow(wrong_self_convention)] // XXX Continue changing. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rdata/rfc4034.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | #[allow(too_many_arguments)] // XXX Consider changing. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/name/parsed.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | #[allow(len_without_is_empty)] // Clippy: It is never empty. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/compose.rs:591:9 [INFO] [stderr] | [INFO] [stderr] 591 | 0x12345678u32.compose(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x1234_5678u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/compose.rs:592:11 [INFO] [stderr] | [INFO] [stderr] 592 | (-0x12345678i32).compose(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x1234_5678i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `len_without_is_empty` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/bits/name/parsed.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | #[allow(len_without_is_empty)] // Clippy: It is never empty. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::len_without_is_empty` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/parse.rs:671:43 [INFO] [stderr] | [INFO] [stderr] 671 | assert_eq!(parser.parse_i32(), Ok(0x12345678)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/parse.rs:672:44 [INFO] [stderr] | [INFO] [stderr] 672 | assert_eq!(parser.parse_i32(), Ok(-42424242)); [INFO] [stderr] | ^^^^^^^^ help: consider: `42_424_242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/parse.rs:680:43 [INFO] [stderr] | [INFO] [stderr] 680 | assert_eq!(parser.parse_u32(), Ok(0x12345678)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/parse.rs:681:43 [INFO] [stderr] | [INFO] [stderr] 681 | assert_eq!(parser.parse_u32(), Ok(0xfd78a84e)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfd78_a84e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/master/source.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 43 | let mut buffer = Vec::with_capacity(CAP); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; CAP]` [INFO] [stderr] 44 | buffer.set_len(CAP); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/master/source.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 223 | let mut buffer = Vec::with_capacity(CAP); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; CAP]` [INFO] [stderr] 224 | buffer.set_len(CAP); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:677:25 [INFO] [stderr] | [INFO] [stderr] 677 | self.buf.as_ptr().offset(pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_ptr().add(pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:682:25 [INFO] [stderr] | [INFO] [stderr] 682 | self.buf.as_mut_ptr().offset(pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:708:25 [INFO] [stderr] | [INFO] [stderr] 708 | self.buf.as_ptr().offset(src_pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_ptr().add(src_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:709:25 [INFO] [stderr] | [INFO] [stderr] 709 | self.buf.as_mut_ptr().offset(dst_pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(dst_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `domain-core`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bits/charstr.rs:555:37 [INFO] [stderr] | [INFO] [stderr] 555 | assert!(CharStr::from_slice(&vec![0; 255]).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 255]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bits/charstr.rs:556:37 [INFO] [stderr] | [INFO] [stderr] 556 | assert!(CharStr::from_slice(&vec![0; 256]).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/bits/charstr.rs:601:13 [INFO] [stderr] | [INFO] [stderr] 601 | let foo = CharStr::parse(&mut parser).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/bits/charstr.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | let bar = CharStr::parse(&mut parser).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/bits/charstr.rs:621:13 [INFO] [stderr] | [INFO] [stderr] 621 | let foo = CharStr::parse_all(&mut parser, 4).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/bits/charstr.rs:622:13 [INFO] [stderr] | [INFO] [stderr] 622 | let bar = u8::parse_all(&mut parser, 1).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/bits/header.rs:677:5 [INFO] [stderr] | [INFO] [stderr] 677 | / fn header() { [INFO] [stderr] 678 | | test_field!(id, set_id, 0, 0x1234); [INFO] [stderr] 679 | | test_field!(qr, set_qr, false, true, false); [INFO] [stderr] 680 | | test_field!(opcode, set_opcode, Opcode::Query, Opcode::Notify); [INFO] [stderr] ... | [INFO] [stderr] 688 | | test_field!(rcode, set_rcode, Rcode::NoError, Rcode::Refused); [INFO] [stderr] 689 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/bits/name/builder.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | let _ = builder.clone().append_label(b"123").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/bits/name/parsed.rs:814:5 [INFO] [stderr] | [INFO] [stderr] 814 | / fn starts_with() { [INFO] [stderr] 815 | | let root = name!(root); [INFO] [stderr] 816 | | let flat_wec = name!(flat); [INFO] [stderr] 817 | | let once_wec = name!(once); [INFO] [stderr] ... | [INFO] [stderr] 877 | | assert!( twice_wec.starts_with(&test)); [INFO] [stderr] 878 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/bits/name/parsed.rs:976:5 [INFO] [stderr] | [INFO] [stderr] 976 | / fn parse_and_skip() { [INFO] [stderr] 977 | | // Correctly formatted names. [INFO] [stderr] 978 | | parse(name!(root).parser, name!(root), 1); [INFO] [stderr] 979 | | parse(name!(flat).parser, name!(flat), 17); [INFO] [stderr] ... | [INFO] [stderr] 1062 | | assert_eq!(parser.remaining(), 2); [INFO] [stderr] 1063 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bits/name/relative.rs:659:24 [INFO] [stderr] | [INFO] [stderr] 659 | Err(RelativeDnameError::CompressedName.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RelativeDnameError::CompressedName` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/bits/name/uncertain.rs:425:5 [INFO] [stderr] | [INFO] [stderr] 425 | / fn from_str() { [INFO] [stderr] 426 | | use std::str::FromStr; [INFO] [stderr] 427 | | [INFO] [stderr] 428 | | fn name(s: &str) -> UncertainDname { [INFO] [stderr] ... | [INFO] [stderr] 500 | | assert_eq!(UncertainDname::from_str(&s1), Err(FromStrError::LongName)); [INFO] [stderr] 501 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/master/source.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 43 | let mut buffer = Vec::with_capacity(CAP); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; CAP]` [INFO] [stderr] 44 | buffer.set_len(CAP); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/master/source.rs:224:17 [INFO] [stderr] | [INFO] [stderr] 223 | let mut buffer = Vec::with_capacity(CAP); [INFO] [stderr] | ----------------------- help: consider replace allocation with: `vec![0; CAP]` [INFO] [stderr] 224 | buffer.set_len(CAP); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:677:25 [INFO] [stderr] | [INFO] [stderr] 677 | self.buf.as_ptr().offset(pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_ptr().add(pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:682:25 [INFO] [stderr] | [INFO] [stderr] 682 | self.buf.as_mut_ptr().offset(pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:708:25 [INFO] [stderr] | [INFO] [stderr] 708 | self.buf.as_ptr().offset(src_pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_ptr().add(src_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rdata/rfc4034.rs:709:25 [INFO] [stderr] | [INFO] [stderr] 709 | self.buf.as_mut_ptr().offset(dst_pos as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buf.as_mut_ptr().add(dst_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `domain-core`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e5574c2207935ebd90ac8fe944e71d9d22f7d779403870d0fc39f829a13f7e94"` [INFO] running `"docker" "rm" "-f" "e5574c2207935ebd90ac8fe944e71d9d22f7d779403870d0fc39f829a13f7e94"` [INFO] [stdout] e5574c2207935ebd90ac8fe944e71d9d22f7d779403870d0fc39f829a13f7e94