[INFO] crate domain 0.2.4 is already in cache [INFO] extracting crate domain 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/domain/0.2.4 [INFO] extracting crate domain 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/domain/0.2.4 [INFO] validating manifest of domain-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of domain-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing domain-0.2.4 [INFO] finished frobbing domain-0.2.4 [INFO] frobbed toml for domain-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/domain/0.2.4/Cargo.toml [INFO] started frobbing domain-0.2.4 [INFO] finished frobbing domain-0.2.4 [INFO] frobbed toml for domain-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/domain/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting domain-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/domain/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a9d9492a5b6ce4d0083793ac6e18a844e9ef96fe258fedb64b5e4cb28fcf2c7 [INFO] running `"docker" "start" "-a" "4a9d9492a5b6ce4d0083793ac6e18a844e9ef96fe258fedb64b5e4cb28fcf2c7"` [INFO] [stderr] Checking domain v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | vec: vec, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | composer: composer [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `composer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:519:13 [INFO] [stderr] | [INFO] [stderr] 519 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:650:13 [INFO] [stderr] | [INFO] [stderr] 650 | section: section, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | parser: parser [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:731:20 [INFO] [stderr] | [INFO] [stderr] 731 | RecordIter{section: section, marker: PhantomData} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/builder.rs:72:40 [INFO] [stderr] | [INFO] [stderr] 72 | let mut res = DNameBuildInto { target: target, start: len, head: len, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/builder.rs:73:35 [INFO] [stderr] | [INFO] [stderr] 73 | origin: origin, absolute: false }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/label.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/parsed.rs:168:61 [INFO] [stderr] | [INFO] [stderr] 168 | Err(Some(ParsedDName{message: self.message, start: start})) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/parsed.rs:184:45 [INFO] [stderr] | [INFO] [stderr] 184 | start: start}))) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/parse.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | Parser{limit: bytes.len(), bytes: bytes, pos: 0} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/question.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | Question { qname: qname, qtype: qtype, qclass: qclass } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `qname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/question.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | Question { qname: qname, qtype: qtype, qclass: qclass } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `qtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/question.rs:49:48 [INFO] [stderr] | [INFO] [stderr] 49 | Question { qname: qname, qtype: qtype, qclass: qclass } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `qclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/rdata.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | rtype: rtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:42 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:52 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/bufscanner.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/entry.rs:126:37 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(Entry::Include { path: path, origin: origin }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/entry.rs:126:49 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(Entry::Include { path: path, origin: origin }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/entry.rs:135:37 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(Entry::Control { name: name, start: pos }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/error.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/reader.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/reader.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(Some(ReaderItem::Include { path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/reader.rs:84:58 [INFO] [stderr] | [INFO] [stderr] 84 | origin: origin })) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | MasterRecord { owner: owner, class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | MasterRecord { owner: owner, class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | ttl: ttl, rdata: rdata } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | ttl: ttl, rdata: rdata } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rdata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | A { addr: addr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:195:15 [INFO] [stderr] | [INFO] [stderr] 195 | Hinfo{cpu: cpu, os: os} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | Hinfo{cpu: cpu, os: os} [INFO] [stderr] | ^^^^^^ help: replace it with: `os` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | Minfo { rmailbx: rmailbx, emailbx: emailbx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `rmailbx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:320:35 [INFO] [stderr] | [INFO] [stderr] 320 | Minfo { rmailbx: rmailbx, emailbx: emailbx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emailbx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | Mx { preference: preference, exchange: exchange } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preference` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:412:38 [INFO] [stderr] | [INFO] [stderr] 412 | Mx { preference: preference, exchange: exchange } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `exchange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:494:16 [INFO] [stderr] | [INFO] [stderr] 494 | Null { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:576:15 [INFO] [stderr] | [INFO] [stderr] 576 | Soa { mname: mname, rname: rname, serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:576:29 [INFO] [stderr] | [INFO] [stderr] 576 | Soa { mname: mname, rname: rname, serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:576:43 [INFO] [stderr] | [INFO] [stderr] 576 | Soa { mname: mname, rname: rname, serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:577:15 [INFO] [stderr] | [INFO] [stderr] 577 | refresh: refresh, retry: retry, expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:577:33 [INFO] [stderr] | [INFO] [stderr] 577 | refresh: refresh, retry: retry, expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:577:47 [INFO] [stderr] | [INFO] [stderr] 577 | refresh: refresh, retry: retry, expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:578:15 [INFO] [stderr] | [INFO] [stderr] 578 | minimum: minimum } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minimum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:689:15 [INFO] [stderr] | [INFO] [stderr] 689 | Txt { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:799:19 [INFO] [stderr] | [INFO] [stderr] 799 | TxtIter { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:841:15 [INFO] [stderr] | [INFO] [stderr] 841 | Wks { address: address, protocol: protocol, bitmap: bitmap } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:841:33 [INFO] [stderr] | [INFO] [stderr] 841 | Wks { address: address, protocol: protocol, bitmap: bitmap } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:841:53 [INFO] [stderr] | [INFO] [stderr] 841 | Wks { address: address, protocol: protocol, bitmap: bitmap } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:1110:19 [INFO] [stderr] | [INFO] [stderr] 1110 | WksIter { bitmap: bitmap, octet: 0, bit: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:51 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:63 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc3596.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | Aaaa { addr: addr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/conf.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/conf.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/conf.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/error.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `while_let_on_iterator` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/lookup/addr.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | #[allow(while_let_on_iterator)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::while_let_on_iterator` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | resolver: resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | search: search [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | FoundHosts{canonical: canonical, addrs: addrs} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `canonical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:187:42 [INFO] [stderr] | [INFO] [stderr] 187 | FoundHosts{canonical: canonical, addrs: addrs} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `addrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:205:62 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(FoundHosts{canonical: name.to_cow().into_owned(), addrs: addrs}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `addrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | resolver: resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | search: search, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | rtype: rtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | class: class [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/search.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | resolv: resolv, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `resolv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/search.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | state: state [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `never_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/lookup/search.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | #[allow(never_loop)] // False positive by Clippy. It totally does loop [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::never_loop` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | fallback_port: fallback_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fallback_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | fallback_port: fallback_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fallback_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | search: search [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:408:33 [INFO] [stderr] | [INFO] [stderr] 408 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/channel.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | connect: connect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `connect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | tcp: tcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | conf: conf [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | resolver: resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | dgram: dgram, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dgram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | complete: complete, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `complete` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | tx: tx [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/tcp.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | TcpChannel(StreamChannel::new(ConnectTcp{addr: addr, handle: handle})) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/tcp.rs:44:62 [INFO] [stderr] | [INFO] [stderr] 44 | TcpChannel(StreamChannel::new(ConnectTcp{addr: addr, handle: handle})) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/multiplex.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/pending.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/sequential.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/sequential.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/sequential.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/single.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/single.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/single.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/udp.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/udp.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/udp.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | recv_size: recv_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | vec: vec, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/compose.rs:544:13 [INFO] [stderr] | [INFO] [stderr] 544 | composer: composer [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `composer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:519:13 [INFO] [stderr] | [INFO] [stderr] 519 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:650:13 [INFO] [stderr] | [INFO] [stderr] 650 | section: section, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | parser: parser [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/message.rs:731:20 [INFO] [stderr] | [INFO] [stderr] 731 | RecordIter{section: section, marker: PhantomData} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/builder.rs:72:40 [INFO] [stderr] | [INFO] [stderr] 72 | let mut res = DNameBuildInto { target: target, start: len, head: len, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/builder.rs:73:35 [INFO] [stderr] | [INFO] [stderr] 73 | origin: origin, absolute: false }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/label.rs:572:13 [INFO] [stderr] | [INFO] [stderr] 572 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/parsed.rs:168:61 [INFO] [stderr] | [INFO] [stderr] 168 | Err(Some(ParsedDName{message: self.message, start: start})) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/name/parsed.rs:184:45 [INFO] [stderr] | [INFO] [stderr] 184 | start: start}))) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/parse.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | Parser{limit: bytes.len(), bytes: bytes, pos: 0} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/question.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | Question { qname: qname, qtype: qtype, qclass: qclass } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `qname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/question.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | Question { qname: qname, qtype: qtype, qclass: qclass } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `qtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/question.rs:49:48 [INFO] [stderr] | [INFO] [stderr] 49 | Question { qname: qname, qtype: qtype, qclass: qclass } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `qclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/rdata.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | rtype: rtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:42 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bits/record.rs:86:52 [INFO] [stderr] | [INFO] [stderr] 86 | Record{name: name, class: class, ttl: ttl, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/bufscanner.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/entry.rs:126:37 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(Entry::Include { path: path, origin: origin }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/entry.rs:126:49 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(Entry::Include { path: path, origin: origin }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/entry.rs:135:37 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(Entry::Control { name: name, start: pos }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/error.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/reader.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/reader.rs:83:58 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(Some(ReaderItem::Include { path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/reader.rs:84:58 [INFO] [stderr] | [INFO] [stderr] 84 | origin: origin })) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | MasterRecord { owner: owner, class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | MasterRecord { owner: owner, class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | ttl: ttl, rdata: rdata } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/master/record.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | ttl: ttl, rdata: rdata } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rdata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | A { addr: addr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:195:15 [INFO] [stderr] | [INFO] [stderr] 195 | Hinfo{cpu: cpu, os: os} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | Hinfo{cpu: cpu, os: os} [INFO] [stderr] | ^^^^^^ help: replace it with: `os` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | Minfo { rmailbx: rmailbx, emailbx: emailbx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `rmailbx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:320:35 [INFO] [stderr] | [INFO] [stderr] 320 | Minfo { rmailbx: rmailbx, emailbx: emailbx } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `emailbx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:412:14 [INFO] [stderr] | [INFO] [stderr] 412 | Mx { preference: preference, exchange: exchange } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preference` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:412:38 [INFO] [stderr] | [INFO] [stderr] 412 | Mx { preference: preference, exchange: exchange } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `exchange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:494:16 [INFO] [stderr] | [INFO] [stderr] 494 | Null { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:576:15 [INFO] [stderr] | [INFO] [stderr] 576 | Soa { mname: mname, rname: rname, serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:576:29 [INFO] [stderr] | [INFO] [stderr] 576 | Soa { mname: mname, rname: rname, serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:576:43 [INFO] [stderr] | [INFO] [stderr] 576 | Soa { mname: mname, rname: rname, serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:577:15 [INFO] [stderr] | [INFO] [stderr] 577 | refresh: refresh, retry: retry, expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:577:33 [INFO] [stderr] | [INFO] [stderr] 577 | refresh: refresh, retry: retry, expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:577:47 [INFO] [stderr] | [INFO] [stderr] 577 | refresh: refresh, retry: retry, expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:578:15 [INFO] [stderr] | [INFO] [stderr] 578 | minimum: minimum } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minimum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:689:15 [INFO] [stderr] | [INFO] [stderr] 689 | Txt { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:799:19 [INFO] [stderr] | [INFO] [stderr] 799 | TxtIter { text: text } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:841:15 [INFO] [stderr] | [INFO] [stderr] 841 | Wks { address: address, protocol: protocol, bitmap: bitmap } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:841:33 [INFO] [stderr] | [INFO] [stderr] 841 | Wks { address: address, protocol: protocol, bitmap: bitmap } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `protocol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:841:53 [INFO] [stderr] | [INFO] [stderr] 841 | Wks { address: address, protocol: protocol, bitmap: bitmap } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc1035.rs:1110:19 [INFO] [stderr] | [INFO] [stderr] 1110 | WksIter { bitmap: bitmap, octet: 0, bit: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:51 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc2782.rs:26:63 [INFO] [stderr] | [INFO] [stderr] 26 | Srv { priority: priority, weight: weight, port: port, target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rdata/rfc3596.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | Aaaa { addr: addr } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/conf.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/conf.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/conf.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/error.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: lint name `while_let_on_iterator` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/lookup/addr.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | #[allow(while_let_on_iterator)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::while_let_on_iterator` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | resolver: resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | search: search [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | FoundHosts{canonical: canonical, addrs: addrs} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `canonical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:187:42 [INFO] [stderr] | [INFO] [stderr] 187 | FoundHosts{canonical: canonical, addrs: addrs} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `addrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/host.rs:205:62 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(FoundHosts{canonical: name.to_cow().into_owned(), addrs: addrs}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `addrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | resolver: resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | query: query, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | search: search, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | rtype: rtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/records.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | class: class [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/search.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | resolv: resolv, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `resolv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/search.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | state: state [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `never_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/resolv/lookup/search.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | #[allow(never_loop)] // False positive by Clippy. It totally does loop [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::never_loop` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | fallback_port: fallback_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fallback_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | fallback_port: fallback_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fallback_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | search: search [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/lookup/srv.rs:408:33 [INFO] [stderr] | [INFO] [stderr] 408 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/channel.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | connect: connect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `connect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | udp: udp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `udp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | tcp: tcp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tcp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | conf: conf [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | resolver: resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/public.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | dgram: dgram, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dgram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | rx: rx, [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:312:13 [INFO] [stderr] | [INFO] [stderr] 312 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | complete: complete, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `complete` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/request.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | tx: tx [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/tcp.rs:44:50 [INFO] [stderr] | [INFO] [stderr] 44 | TcpChannel(StreamChannel::new(ConnectTcp{addr: addr, handle: handle})) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/tcp.rs:44:62 [INFO] [stderr] | [INFO] [stderr] 44 | TcpChannel(StreamChannel::new(ConnectTcp{addr: addr, handle: handle})) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/multiplex.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/pending.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/sequential.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/sequential.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/sequential.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/single.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | receiver: receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/single.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/transport/single.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | reactor: reactor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `reactor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/udp.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | peer: peer, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `peer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/udp.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolv/udp.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | recv_size: recv_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/error.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/resolv/lookup/srv.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 182 | | if let Some(item) = self.results.get(self.current_idx).cloned() { [INFO] [stderr] 183 | | if let SrvItemState::Unresolved(host) = item.state { [INFO] [stderr] 184 | | self.lookup = Some(lookup_host(self.resolver.clone(), &host)); [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 181 | else if let Some(item) = self.results.get(self.current_idx).cloned() { [INFO] [stderr] 182 | if let SrvItemState::Unresolved(host) = item.state { [INFO] [stderr] 183 | self.lookup = Some(lookup_host(self.resolver.clone(), &host)); [INFO] [stderr] 184 | return self.poll() [INFO] [stderr] 185 | } [INFO] [stderr] 186 | else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/compose.rs:754:23 [INFO] [stderr] | [INFO] [stderr] 754 | c.compose_u32(0xdeadbeef).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/compose.rs:829:23 [INFO] [stderr] | [INFO] [stderr] 829 | c.compose_u32(0x12312819).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1231_2819` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/compose.rs:833:27 [INFO] [stderr] | [INFO] [stderr] 833 | c.update_u32(p32, 0xdeadbeef); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/compose.rs:844:34 [INFO] [stderr] | [INFO] [stderr] 844 | assert_eq!(c.compose_u32(0xdeadbeef), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/compose.rs:856:23 [INFO] [stderr] | [INFO] [stderr] 856 | c.compose_u32(0xdeadbeef).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bits/charstr.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_lowercase': use inherent methods instead [INFO] [stderr] --> src/bits/charstr.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | self.iter().map(AsciiExt::to_ascii_lowercase) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_lowercase': use inherent methods instead [INFO] [stderr] --> src/bits/charstr.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | .cmp(other.iter().map(AsciiExt::to_ascii_lowercase)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bits/parse.rs:282:49 [INFO] [stderr] | [INFO] [stderr] 282 | assert_eq!(parser.parse_u32().unwrap(), 0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/master/bufscanner.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/master/error.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | #[allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/resolv/lookup/srv.rs:181:14 [INFO] [stderr] | [INFO] [stderr] 181 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 182 | | if let Some(item) = self.results.get(self.current_idx).cloned() { [INFO] [stderr] 183 | | if let SrvItemState::Unresolved(host) = item.state { [INFO] [stderr] 184 | | self.lookup = Some(lookup_host(self.resolver.clone(), &host)); [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 181 | else if let Some(item) = self.results.get(self.current_idx).cloned() { [INFO] [stderr] 182 | if let SrvItemState::Unresolved(host) = item.state { [INFO] [stderr] 183 | self.lookup = Some(lookup_host(self.resolver.clone(), &host)); [INFO] [stderr] 184 | return self.poll() [INFO] [stderr] 185 | } [INFO] [stderr] 186 | else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bits/charstr.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_lowercase': use inherent methods instead [INFO] [stderr] --> src/bits/charstr.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | self.iter().map(AsciiExt::to_ascii_lowercase) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::to_ascii_lowercase': use inherent methods instead [INFO] [stderr] --> src/bits/charstr.rs:195:35 [INFO] [stderr] | [INFO] [stderr] 195 | .cmp(other.iter().map(AsciiExt::to_ascii_lowercase)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/charstr.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::charstr::CharStr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/charstr.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(bytes as *mut [u8] as *mut bits::charstr::CharStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bits/compose.rs:373:13 [INFO] [stderr] | [INFO] [stderr] 373 | self.checkpoint.map(|len| self.vec.truncate(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(len) = self.checkpoint { self.vec.truncate(len) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/message.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::message::Message)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/message.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(bytes as *mut [u8] as *mut bits::message::Message)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/message.rs:589:14 [INFO] [stderr] | [INFO] [stderr] 589 | fn count(&self, counts: &HeaderCounts) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bits/message_builder.rs:522:23 [INFO] [stderr] | [INFO] [stderr] 522 | let mut ttl = (rcode.ext() as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(rcode.ext())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bits/name/iter.rs:81:52 [INFO] [stderr] | [INFO] [stderr] 81 | Cow::Owned(DNameBuf::try_from_iter(labels.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `labels.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bits/name/iter.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | self.label.back() [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 218 | || .map(|iter| iter.push_name(&mut name).unwrap()); [INFO] [stderr] | ||_____________________________________________________________________^- help: try this: `if let Some(iter) = self.label.back() { iter.push_name(&mut name).unwrap() }` [INFO] [stderr] | |______________________________________________________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/name/label.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::name::label::Label)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/name/plain.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::name::plain::DNameSlice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/bits/name/plain.rs:506:9 [INFO] [stderr] | [INFO] [stderr] 506 | / if DNameSlice::from_bytes(&vec).is_none() { [INFO] [stderr] 507 | | return None [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `DNameSlice::from_bytes(&vec)?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/bits/name/plain.rs:678:41 [INFO] [stderr] | [INFO] [stderr] 678 | if let Err(err) = self.push(label.as_ref()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `label` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7314.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn expire(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7828.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn timeout(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `bits::opt::rfc7830::Padding` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/bits/opt/rfc7830.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / impl Padding { [INFO] [stderr] 28 | | pub fn new(len: u16, mode: PaddingMode) -> Self { [INFO] [stderr] 29 | | Padding { len, mode } [INFO] [stderr] 30 | | } [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7830.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn len(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7830.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn mode(&self) -> PaddingMode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 4]`) [INFO] [stderr] --> src/bits/opt/rfc7871.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | mem::transmute(parser.parse_bytes(4)?.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(parser.parse_bytes(4)?.as_ptr() as *const [u8; 4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 16]`) [INFO] [stderr] --> src/bits/opt/rfc7871.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | mem::transmute(parser.parse_bytes(16)?.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(parser.parse_bytes(16)?.as_ptr() as *const [u8; 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 8]`) [INFO] [stderr] --> src/bits/opt/rfc7873.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | mem::transmute(parser.parse_bytes(8)?.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(parser.parse_bytes(8)?.as_ptr() as *const [u8; 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bits::opt::rfc8145::KeyTag>` [INFO] [stderr] --> src/bits/opt/rfc8145.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | KeyTag(Vec::new()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/class.rs:66:40 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn compose>(&self, mut composer: C) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/iana/rcode.rs:541:32 [INFO] [stderr] | [INFO] [stderr] 541 | OptRcode::from_int((ext as u16) << 4 | (rcode.to_int() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(ext)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/iana/rcode.rs:541:52 [INFO] [stderr] | [INFO] [stderr] 541 | OptRcode::from_int((ext as u16) << 4 | (rcode.to_int() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(rcode.to_int())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/rcode.rs:552:18 [INFO] [stderr] | [INFO] [stderr] 552 | pub fn rcode(&self) -> Rcode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/rcode.rs:557:16 [INFO] [stderr] | [INFO] [stderr] 557 | pub fn ext(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/iana/rcode.rs:901:29 [INFO] [stderr] | [INFO] [stderr] 901 | TsigRcode::from_int(value.to_int() as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(value.to_int())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/rtype.rs:415:40 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn compose>(&self, mut composer: C) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/master/bufscanner.rs:199:27 [INFO] [stderr] | [INFO] [stderr] 199 | let res = ((ch - b'0') as u16) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/master/bufscanner.rs:200:27 [INFO] [stderr] | [INFO] [stderr] 200 | + ((ch2 - b'0') as u16) * 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch2 - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/master/bufscanner.rs:201:27 [INFO] [stderr] | [INFO] [stderr] 201 | + ((ch3 - b'0') as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch3 - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/master/record.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / match *origin { [INFO] [stderr] 119 | | Some(ref rc) => Some(rc), [INFO] [stderr] 120 | | None => None [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ help: try this: `*origin.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/rdata/rfc1035.rs:960:18 [INFO] [stderr] | [INFO] [stderr] 960 | unsafe { mem::transmute(bytes) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const rdata::rfc1035::WksBitmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rdata/mod.rs:81:25 [INFO] [stderr] | [INFO] [stderr] 81 | Some(res) => Ok(res), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 81 | Some(res) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/resolv/lookup/srv.rs:169:25 [INFO] [stderr] | [INFO] [stderr] 169 | let ref item = self.results[self.current_idx]; [INFO] [stderr] | ----^^^^^^^^---------------------------------- help: try: `let item = &self.results[self.current_idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/resolv/lookup/srv.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | / match self.txt_service { [INFO] [stderr] 255 | | Some(ref name) => Some(name), [INFO] [stderr] 256 | | None => None [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ help: try this: `self.txt_service.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resolv/lookup/srv.rs:282:12 [INFO] [stderr] | [INFO] [stderr] 282 | if rrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/resolv/lookup/srv.rs:353:27 [INFO] [stderr] | [INFO] [stderr] 353 | weight_sum += items[i].weight as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(items[i].weight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/resolv/lookup/srv.rs:367:24 [INFO] [stderr] | [INFO] [stderr] 367 | sum += items[j].weight as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(items[j].weight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/resolv/lookup/srv.rs:369:35 [INFO] [stderr] | [INFO] [stderr] 369 | weight_sum -= items[j].weight as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(items[j].weight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/charstr.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::charstr::CharStr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/charstr.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(bytes as *mut [u8] as *mut bits::charstr::CharStr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bits/charstr.rs:625:37 [INFO] [stderr] | [INFO] [stderr] 625 | assert!(CharStr::from_bytes(&vec![0; 255]).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 255]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/bits/charstr.rs:626:37 [INFO] [stderr] | [INFO] [stderr] 626 | assert!(CharStr::from_bytes(&vec![0; 256]).is_none()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 256]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/bits/charstr.rs:634:13 [INFO] [stderr] | [INFO] [stderr] 634 | let foo = CharStr::parse(&mut p).unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bits/compose.rs:373:13 [INFO] [stderr] | [INFO] [stderr] 373 | self.checkpoint.map(|len| self.vec.truncate(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(len) = self.checkpoint { self.vec.truncate(len) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: lint name `string_lit_as_bytes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/rusthome.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | #[allow(unknown_lints, string_lit_as_bytes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::string_lit_as_bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/dig.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | conf: conf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dig.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dig.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dig.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dig.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dig.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dig.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/bits/header.rs:617:5 [INFO] [stderr] | [INFO] [stderr] 617 | / fn header() { [INFO] [stderr] 618 | | test_field!(id, set_id, 0, 0x1234); [INFO] [stderr] 619 | | test_field!(qr, set_qr, false, true, false); [INFO] [stderr] 620 | | test_field!(opcode, set_opcode, Opcode::Query, Opcode::Notify); [INFO] [stderr] ... | [INFO] [stderr] 628 | | test_field!(rcode, set_rcode, Rcode::NoError, Rcode::Refused); [INFO] [stderr] 629 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/message.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::message::Message)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/message.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(bytes as *mut [u8] as *mut bits::message::Message)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/message.rs:589:14 [INFO] [stderr] | [INFO] [stderr] 589 | fn count(&self, counts: &HeaderCounts) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bits/message_builder.rs:522:23 [INFO] [stderr] | [INFO] [stderr] 522 | let mut ttl = (rcode.ext() as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(rcode.ext())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/bits/name/iter.rs:81:52 [INFO] [stderr] | [INFO] [stderr] 81 | Cow::Owned(DNameBuf::try_from_iter(labels.iter().map(|x| *x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `labels.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bits/name/iter.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | self.label.back() [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 218 | || .map(|iter| iter.push_name(&mut name).unwrap()); [INFO] [stderr] | ||_____________________________________________________________________^- help: try this: `if let Some(iter) = self.label.back() { iter.push_name(&mut name).unwrap() }` [INFO] [stderr] | |______________________________________________________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/name/label.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::name::label::Label)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/bits/name/plain.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | mem::transmute(bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const bits::name::plain::DNameSlice)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/bits/name/plain.rs:506:9 [INFO] [stderr] | [INFO] [stderr] 506 | / if DNameSlice::from_bytes(&vec).is_none() { [INFO] [stderr] 507 | | return None [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `DNameSlice::from_bytes(&vec)?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/bits/name/plain.rs:678:41 [INFO] [stderr] | [INFO] [stderr] 678 | if let Err(err) = self.push(label.as_ref()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try this: `label` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 114 [INFO] [stderr] --> src/bits/name/plain.rs:1040:5 [INFO] [stderr] | [INFO] [stderr] 1040 | / fn slice_methods() { [INFO] [stderr] 1041 | | let empty = slice(b""); [INFO] [stderr] 1042 | | let dot = slice(b"\x00"); [INFO] [stderr] 1043 | | let foo = slice(b"\x03foo"); [INFO] [stderr] ... | [INFO] [stderr] 1151 | | assert_eq!(foodot.join(&foodot).unwrap(), foodot); [INFO] [stderr] 1152 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/bits/name/plain.rs:1043:13 [INFO] [stderr] | [INFO] [stderr] 1043 | let foo = slice(b"\x03foo"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/bits/name/plain.rs:1044:13 [INFO] [stderr] | [INFO] [stderr] 1044 | let bar = slice(b"\x03bar"); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7314.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn expire(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7828.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn timeout(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `bits::opt::rfc7830::Padding` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/bits/opt/rfc7830.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / impl Padding { [INFO] [stderr] 28 | | pub fn new(len: u16, mode: PaddingMode) -> Self { [INFO] [stderr] 29 | | Padding { len, mode } [INFO] [stderr] 30 | | } [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7830.rs:32:16 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn len(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bits/opt/rfc7830.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn mode(&self) -> PaddingMode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 4]`) [INFO] [stderr] --> src/bits/opt/rfc7871.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | mem::transmute(parser.parse_bytes(4)?.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(parser.parse_bytes(4)?.as_ptr() as *const [u8; 4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 16]`) [INFO] [stderr] --> src/bits/opt/rfc7871.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | mem::transmute(parser.parse_bytes(16)?.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(parser.parse_bytes(16)?.as_ptr() as *const [u8; 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*const u8`) to a reference type (`&[u8; 8]`) [INFO] [stderr] --> src/bits/opt/rfc7873.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | mem::transmute(parser.parse_bytes(8)?.as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(parser.parse_bytes(8)?.as_ptr() as *const [u8; 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bits::opt::rfc8145::KeyTag>` [INFO] [stderr] --> src/bits/opt/rfc8145.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | KeyTag(Vec::new()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/class.rs:66:40 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn compose>(&self, mut composer: C) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/iana/rcode.rs:541:32 [INFO] [stderr] | [INFO] [stderr] 541 | OptRcode::from_int((ext as u16) << 4 | (rcode.to_int() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(ext)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/iana/rcode.rs:541:52 [INFO] [stderr] | [INFO] [stderr] 541 | OptRcode::from_int((ext as u16) << 4 | (rcode.to_int() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(rcode.to_int())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/rcode.rs:552:18 [INFO] [stderr] | [INFO] [stderr] 552 | pub fn rcode(&self) -> Rcode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/rcode.rs:557:16 [INFO] [stderr] | [INFO] [stderr] 557 | pub fn ext(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/iana/rcode.rs:901:29 [INFO] [stderr] | [INFO] [stderr] 901 | TsigRcode::from_int(value.to_int() as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(value.to_int())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/iana/rtype.rs:415:40 [INFO] [stderr] | [INFO] [stderr] 415 | pub fn compose>(&self, mut composer: C) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/master/bufscanner.rs:199:27 [INFO] [stderr] | [INFO] [stderr] 199 | let res = ((ch - b'0') as u16) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/master/bufscanner.rs:200:27 [INFO] [stderr] | [INFO] [stderr] 200 | + ((ch2 - b'0') as u16) * 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch2 - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/master/bufscanner.rs:201:27 [INFO] [stderr] | [INFO] [stderr] 201 | + ((ch3 - b'0') as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(ch3 - b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/master/bufscanner.rs:636:17 [INFO] [stderr] | [INFO] [stderr] 636 | if *left.get(0).unwrap() == ch { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&left[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/master/bufscanner.rs:659:21 [INFO] [stderr] | [INFO] [stderr] 659 | if *left.get(0).unwrap() == ch { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&left[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/master/bufscanner.rs:702:21 [INFO] [stderr] | [INFO] [stderr] 702 | if *left.get(0).unwrap() == ch { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&left[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/master/record.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | / match *origin { [INFO] [stderr] 119 | | Some(ref rc) => Some(rc), [INFO] [stderr] 120 | | None => None [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ help: try this: `*origin.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/rdata/rfc1035.rs:960:18 [INFO] [stderr] | [INFO] [stderr] 960 | unsafe { mem::transmute(bytes) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes as *const [u8] as *const rdata::rfc1035::WksBitmap)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rdata/mod.rs:81:25 [INFO] [stderr] | [INFO] [stderr] 81 | Some(res) => Ok(res), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 81 | Some(res) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/resolv/lookup/srv.rs:169:25 [INFO] [stderr] | [INFO] [stderr] 169 | let ref item = self.results[self.current_idx]; [INFO] [stderr] | ----^^^^^^^^---------------------------------- help: try: `let item = &self.results[self.current_idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/resolv/lookup/srv.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | / match self.txt_service { [INFO] [stderr] 255 | | Some(ref name) => Some(name), [INFO] [stderr] 256 | | None => None [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ help: try this: `self.txt_service.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/resolv/lookup/srv.rs:282:12 [INFO] [stderr] | [INFO] [stderr] 282 | if rrs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rrs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/resolv/lookup/srv.rs:353:27 [INFO] [stderr] | [INFO] [stderr] 353 | weight_sum += items[i].weight as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(items[i].weight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/resolv/lookup/srv.rs:367:24 [INFO] [stderr] | [INFO] [stderr] 367 | sum += items[j].weight as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(items[j].weight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/resolv/lookup/srv.rs:369:35 [INFO] [stderr] | [INFO] [stderr] 369 | weight_sum -= items[j].weight as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(items[j].weight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: lint name `string_lit_as_bytes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/rusthome.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | #[allow(unknown_lints, string_lit_as_bytes)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::string_lit_as_bytes` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.15s [INFO] running `"docker" "inspect" "4a9d9492a5b6ce4d0083793ac6e18a844e9ef96fe258fedb64b5e4cb28fcf2c7"` [INFO] running `"docker" "rm" "-f" "4a9d9492a5b6ce4d0083793ac6e18a844e9ef96fe258fedb64b5e4cb28fcf2c7"` [INFO] [stdout] 4a9d9492a5b6ce4d0083793ac6e18a844e9ef96fe258fedb64b5e4cb28fcf2c7