[INFO] crate dok 0.2.0 is already in cache [INFO] extracting crate dok 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dok/0.2.0 [INFO] extracting crate dok 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dok/0.2.0 [INFO] validating manifest of dok-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dok-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dok-0.2.0 [INFO] finished frobbing dok-0.2.0 [INFO] frobbed toml for dok-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dok/0.2.0/Cargo.toml [INFO] started frobbing dok-0.2.0 [INFO] finished frobbing dok-0.2.0 [INFO] frobbed toml for dok-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dok/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dok-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dok/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c09f06b39f740404dd86d3dddd7096139f053e32521b03758a42ef06cbb092f [INFO] running `"docker" "start" "-a" "4c09f06b39f740404dd86d3dddd7096139f053e32521b03758a42ef06cbb092f"` [INFO] [stderr] Checking reqwest v0.5.2 [INFO] [stderr] Checking dok v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | creds: creds, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `creds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | creds: creds, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `creds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | const REGISTRY_API_VERSION: &'static str = "v2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/credentials.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | let home = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | const REGISTRY_API_VERSION: &'static str = "v2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/credentials.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | let home = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match res.status() { [INFO] [stderr] 137 | | &reqwest::StatusCode::Ok => {} [INFO] [stderr] 138 | | _ => return Err(DokError::new(&format!("Request failed: {:?}", res))), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 136 | match *res.status() { [INFO] [stderr] 137 | reqwest::StatusCode::Ok => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match res.status() { [INFO] [stderr] 157 | | &reqwest::StatusCode::Ok => {} [INFO] [stderr] 158 | | &reqwest::StatusCode::Unauthorized => return self.try_request_token(url, res), [INFO] [stderr] 159 | | _ => return Err(DokError::new(&format!("Request failed: {:?}", res))), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *res.status() { [INFO] [stderr] 157 | reqwest::StatusCode::Ok => {} [INFO] [stderr] 158 | reqwest::StatusCode::Unauthorized => return self.try_request_token(url, res), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/credentials.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match tried["auth"] { [INFO] [stderr] 32 | | serde_json::Value::String(ref s) => return Ok(s.to_string()), [INFO] [stderr] 33 | | _ => {} [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____________^ help: try this: `if let serde_json::Value::String(ref s) = tried["auth"] { return Ok(s.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match res.status() { [INFO] [stderr] 137 | | &reqwest::StatusCode::Ok => {} [INFO] [stderr] 138 | | _ => return Err(DokError::new(&format!("Request failed: {:?}", res))), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 136 | match *res.status() { [INFO] [stderr] 137 | reqwest::StatusCode::Ok => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/api.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | / match res.status() { [INFO] [stderr] 157 | | &reqwest::StatusCode::Ok => {} [INFO] [stderr] 158 | | &reqwest::StatusCode::Unauthorized => return self.try_request_token(url, res), [INFO] [stderr] 159 | | _ => return Err(DokError::new(&format!("Request failed: {:?}", res))), [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 156 | match *res.status() { [INFO] [stderr] 157 | reqwest::StatusCode::Ok => {} [INFO] [stderr] 158 | reqwest::StatusCode::Unauthorized => return self.try_request_token(url, res), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/credentials.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match tried["auth"] { [INFO] [stderr] 32 | | serde_json::Value::String(ref s) => return Ok(s.to_string()), [INFO] [stderr] 33 | | _ => {} [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____________^ help: try this: `if let serde_json::Value::String(ref s) = tried["auth"] { return Ok(s.to_string()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.40s [INFO] running `"docker" "inspect" "4c09f06b39f740404dd86d3dddd7096139f053e32521b03758a42ef06cbb092f"` [INFO] running `"docker" "rm" "-f" "4c09f06b39f740404dd86d3dddd7096139f053e32521b03758a42ef06cbb092f"` [INFO] [stdout] 4c09f06b39f740404dd86d3dddd7096139f053e32521b03758a42ef06cbb092f