[INFO] crate doh 0.1.0 is already in cache [INFO] extracting crate doh 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/doh/0.1.0 [INFO] extracting crate doh 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/doh/0.1.0 [INFO] validating manifest of doh-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of doh-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing doh-0.1.0 [INFO] finished frobbing doh-0.1.0 [INFO] frobbed toml for doh-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/doh/0.1.0/Cargo.toml [INFO] started frobbing doh-0.1.0 [INFO] finished frobbing doh-0.1.0 [INFO] frobbed toml for doh-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/doh/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting doh-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/doh/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b640d21a7a55f32ee8db4809d5d6753874c766a2d7db15df3d5f35a833dc76e9 [INFO] running `"docker" "start" "-a" "b640d21a7a55f32ee8db4809d5d6753874c766a2d7db15df3d5f35a833dc76e9"` [INFO] [stderr] Compiling tinyfiledialogs v3.3.5 [INFO] [stderr] Checking getch v0.2.0 [INFO] [stderr] Checking rfsapi v0.2.0 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking doh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/util.rs:127:15 [INFO] [stderr] | [INFO] [stderr] 127 | let utc = from.as_ref().chars().last() == Some('Z'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `from.as_ref().ends_with('Z')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/util.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | p[0..p[0..p.len() - ((p.chars().last() == Some('/')) as usize)].rfind('/').unwrap()].parse().unwrap_or_else(|_| u.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `p.ends_with('/')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/util.rs:127:15 [INFO] [stderr] | [INFO] [stderr] 127 | let utc = from.as_ref().chars().last() == Some('Z'); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `from.as_ref().ends_with('Z')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/util.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | p[0..p[0..p.len() - ((p.chars().last() == Some('/')) as usize)].rfind('/').unwrap()].parse().unwrap_or_else(|_| u.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `p.ends_with('/')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.80s [INFO] running `"docker" "inspect" "b640d21a7a55f32ee8db4809d5d6753874c766a2d7db15df3d5f35a833dc76e9"` [INFO] running `"docker" "rm" "-f" "b640d21a7a55f32ee8db4809d5d6753874c766a2d7db15df3d5f35a833dc76e9"` [INFO] [stdout] b640d21a7a55f32ee8db4809d5d6753874c766a2d7db15df3d5f35a833dc76e9