[INFO] crate dmc 0.1.0 is already in cache [INFO] extracting crate dmc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dmc/0.1.0 [INFO] extracting crate dmc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dmc/0.1.0 [INFO] validating manifest of dmc-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmc-0.1.0 [INFO] finished frobbing dmc-0.1.0 [INFO] frobbed toml for dmc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dmc/0.1.0/Cargo.toml [INFO] started frobbing dmc-0.1.0 [INFO] finished frobbing dmc-0.1.0 [INFO] frobbed toml for dmc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dmc/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmc-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dmc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d89b9604251ed9053eda94097b663df1db9497e61fe87b4daf79345b6e5b3ebf [INFO] running `"docker" "start" "-a" "d89b9604251ed9053eda94097b663df1db9497e61fe87b4daf79345b6e5b3ebf"` [INFO] [stderr] Compiling dmc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Compiling x11 v2.18.1 [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/display/x11.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/display/x11.rs:452:32 [INFO] [stderr] | [INFO] [stderr] 452 | let border_color = 0xff0000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/display/x11.rs:453:28 [INFO] [stderr] | [INFO] [stderr] 453 | let bg_color = 0x00ff00; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/event/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:10:43 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/display/x11.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/display/x11.rs:452:32 [INFO] [stderr] | [INFO] [stderr] 452 | let border_color = 0xff0000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/display/x11.rs:453:28 [INFO] [stderr] | [INFO] [stderr] 453 | let bg_color = 0x00ff00; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/event/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/display/x11.rs:776:9 [INFO] [stderr] | [INFO] [stderr] 776 | / let attribs_arb = [ [INFO] [stderr] 777 | | glx::arb::GLX_CONTEXT_MAJOR_VERSION_ARB, 3, [INFO] [stderr] 778 | | glx::arb::GLX_CONTEXT_MINOR_VERSION_ARB, 0, [INFO] [stderr] 779 | | glx::arb::GLX_CONTEXT_FLAGS_ARB, [INFO] [stderr] ... | [INFO] [stderr] 786 | | xx::None [INFO] [stderr] 787 | | ]; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/display/x11.rs:776:9 [INFO] [stderr] | [INFO] [stderr] 776 | / let attribs_arb = [ [INFO] [stderr] 777 | | glx::arb::GLX_CONTEXT_MAJOR_VERSION_ARB, 3, [INFO] [stderr] 778 | | glx::arb::GLX_CONTEXT_MINOR_VERSION_ARB, 0, [INFO] [stderr] 779 | | glx::arb::GLX_CONTEXT_FLAGS_ARB, [INFO] [stderr] ... | [INFO] [stderr] 786 | | xx::None [INFO] [stderr] 787 | | ]; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `client_vendor` [INFO] [stderr] --> src/display/x11.rs:419:17 [INFO] [stderr] | [INFO] [stderr] 419 | let client_vendor = glx::glXGetClientString( x_dpy, xx::GLX_VENDOR); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_client_vendor` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `client_version` [INFO] [stderr] --> src/display/x11.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | let client_version = glx::glXGetClientString( x_dpy, xx::GLX_VERSION); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_client_version` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_vendor` [INFO] [stderr] --> src/display/x11.rs:421:17 [INFO] [stderr] | [INFO] [stderr] 421 | let server_vendor = glx::glXQueryServerString(x_dpy, screen_num, xx::GLX_VENDOR); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_server_vendor` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_version` [INFO] [stderr] --> src/display/x11.rs:422:17 [INFO] [stderr] | [INFO] [stderr] 422 | let server_version = glx::glXQueryServerString(x_dpy, screen_num, xx::GLX_VERSION); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_server_version` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `resizable` [INFO] [stderr] --> src/display/x11.rs:458:23 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^^^^ help: try ignoring the field: `resizable: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fully_opaque` [INFO] [stderr] --> src/display/x11.rs:458:34 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^^^^^^^ help: try ignoring the field: `fully_opaque: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `opengl` [INFO] [stderr] --> src/display/x11.rs:458:48 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^ help: try ignoring the field: `opengl: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `allow_high_dpi` [INFO] [stderr] --> src/display/x11.rs:458:56 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try ignoring the field: `allow_high_dpi: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `version` [INFO] [stderr] --> src/display/x11.rs:762:13 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `version: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `debug` [INFO] [stderr] --> src/display/x11.rs:762:22 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^ help: try ignoring the field: `debug: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `forward_compatible` [INFO] [stderr] --> src/display/x11.rs:762:29 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `forward_compatible: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `profile` [INFO] [stderr] --> src/display/x11.rs:762:49 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `profile: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msaa` [INFO] [stderr] --> src/display/x11.rs:762:58 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^ help: try ignoring the field: `msaa: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `best_fbc` [INFO] [stderr] --> src/display/x11.rs:775:13 [INFO] [stderr] | [INFO] [stderr] 775 | let best_fbc: glx::GLXFBConfig = unimplemented!(); // FIXME [INFO] [stderr] | ^^^^^^^^ help: consider using `_best_fbc` instead [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/display/mod.rs:830:5 [INFO] [stderr] | [INFO] [stderr] 830 | fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] ... [INFO] [stderr] 834 | .. Default::default() [INFO] [stderr] | ------------------ recursive call site [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unconditional_recursion)] on by default [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: unused variable: `client_vendor` [INFO] [stderr] --> src/display/x11.rs:419:17 [INFO] [stderr] | [INFO] [stderr] 419 | let client_vendor = glx::glXGetClientString( x_dpy, xx::GLX_VENDOR); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_client_vendor` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `client_version` [INFO] [stderr] --> src/display/x11.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | let client_version = glx::glXGetClientString( x_dpy, xx::GLX_VERSION); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_client_version` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_vendor` [INFO] [stderr] --> src/display/x11.rs:421:17 [INFO] [stderr] | [INFO] [stderr] 421 | let server_vendor = glx::glXQueryServerString(x_dpy, screen_num, xx::GLX_VENDOR); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_server_vendor` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server_version` [INFO] [stderr] --> src/display/x11.rs:422:17 [INFO] [stderr] | [INFO] [stderr] 422 | let server_version = glx::glXQueryServerString(x_dpy, screen_num, xx::GLX_VERSION); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_server_version` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `resizable` [INFO] [stderr] --> src/display/x11.rs:458:23 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^^^^ help: try ignoring the field: `resizable: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fully_opaque` [INFO] [stderr] --> src/display/x11.rs:458:34 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^^^^^^^ help: try ignoring the field: `fully_opaque: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `opengl` [INFO] [stderr] --> src/display/x11.rs:458:48 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^ help: try ignoring the field: `opengl: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `allow_high_dpi` [INFO] [stderr] --> src/display/x11.rs:458:56 [INFO] [stderr] | [INFO] [stderr] 458 | mode, resizable, fully_opaque, opengl, allow_high_dpi [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try ignoring the field: `allow_high_dpi: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `version` [INFO] [stderr] --> src/display/x11.rs:762:13 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `version: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `debug` [INFO] [stderr] --> src/display/x11.rs:762:22 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^ help: try ignoring the field: `debug: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `forward_compatible` [INFO] [stderr] --> src/display/x11.rs:762:29 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `forward_compatible: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `profile` [INFO] [stderr] --> src/display/x11.rs:762:49 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^^^^ help: try ignoring the field: `profile: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `msaa` [INFO] [stderr] --> src/display/x11.rs:762:58 [INFO] [stderr] | [INFO] [stderr] 762 | version, debug, forward_compatible, profile, msaa, .. [INFO] [stderr] | ^^^^ help: try ignoring the field: `msaa: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `best_fbc` [INFO] [stderr] --> src/display/x11.rs:775:13 [INFO] [stderr] | [INFO] [stderr] 775 | let best_fbc: glx::GLXFBConfig = unimplemented!(); // FIXME [INFO] [stderr] | ^^^^^^^^ help: consider using `_best_fbc` instead [INFO] [stderr] [INFO] [stderr] warning: function cannot return without recursing [INFO] [stderr] --> src/display/mod.rs:830:5 [INFO] [stderr] | [INFO] [stderr] 830 | fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ cannot return without recursing [INFO] [stderr] ... [INFO] [stderr] 834 | .. Default::default() [INFO] [stderr] | ------------------ recursive call site [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unconditional_recursion)] on by default [INFO] [stderr] = help: a `loop` may express intention better if this is on purpose [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GLX_EXTENSIONS` [INFO] [stderr] --> src/display/x11.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub const GLX_EXTENSIONS: i32 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `gen_fbconfig_attribs` [INFO] [stderr] --> src/display/x11.rs:690:5 [INFO] [stderr] | [INFO] [stderr] 690 | fn gen_fbconfig_attribs(settings: &GLContextSettings) -> [c_int; 37] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `None` should have an upper case name such as `NONE` [INFO] [stderr] --> src/display/x11.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub const None: i32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/display/x11.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | #[no_implicit_prelude] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/display/x11.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / match self { [INFO] [stderr] 144 | | &Error::NoXDisplayForName { ref name } => { [INFO] [stderr] 145 | | let name = unsafe { CString::from_raw(x::XDisplayName( [INFO] [stderr] 146 | | match name { [INFO] [stderr] ... | [INFO] [stderr] 162 | | }, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *self { [INFO] [stderr] 144 | Error::NoXDisplayForName { ref name } => { [INFO] [stderr] 145 | let name = unsafe { CString::from_raw(x::XDisplayName( [INFO] [stderr] 146 | match name { [INFO] [stderr] 147 | &None => ptr::null(), [INFO] [stderr] 148 | &Some(ref name) => &name as *const _ as *const i8, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/display/x11.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | / match name { [INFO] [stderr] 147 | | &None => ptr::null(), [INFO] [stderr] 148 | | &Some(ref name) => &name as *const _ as *const i8, [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *name { [INFO] [stderr] 147 | None => ptr::null(), [INFO] [stderr] 148 | Some(ref name) => &name as *const _ as *const i8, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/display/x11.rs:599:33 [INFO] [stderr] | [INFO] [stderr] 599 | self.dpy.x_dpy, mem::transmute(title_ptr), 1, x::XUTF8StringStyle, &mut title_prop [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `title_ptr as *mut *mut i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:601:26 [INFO] [stderr] | [INFO] [stderr] 601 | if status == x::Success as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(x::Success)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:662:35 [INFO] [stderr] | [INFO] [stderr] 662 | glx::GLX_AUX_BUFFERS, aux_buffers as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(aux_buffers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:663:32 [INFO] [stderr] | [INFO] [stderr] 663 | glx::GLX_RED_SIZE, red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:664:34 [INFO] [stderr] | [INFO] [stderr] 664 | glx::GLX_GREEN_SIZE, green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:665:33 [INFO] [stderr] | [INFO] [stderr] 665 | glx::GLX_BLUE_SIZE, blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:666:34 [INFO] [stderr] | [INFO] [stderr] 666 | glx::GLX_ALPHA_SIZE, alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:667:34 [INFO] [stderr] | [INFO] [stderr] 667 | glx::GLX_DEPTH_SIZE, depth_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(depth_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:668:36 [INFO] [stderr] | [INFO] [stderr] 668 | glx::GLX_STENCIL_SIZE, stencil_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:669:38 [INFO] [stderr] | [INFO] [stderr] 669 | glx::GLX_ACCUM_RED_SIZE, accum_red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:670:40 [INFO] [stderr] | [INFO] [stderr] 670 | glx::GLX_ACCUM_GREEN_SIZE, accum_green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:671:39 [INFO] [stderr] | [INFO] [stderr] 671 | glx::GLX_ACCUM_BLUE_SIZE, accum_blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:672:40 [INFO] [stderr] | [INFO] [stderr] 672 | glx::GLX_ACCUM_ALPHA_SIZE, accum_alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:701:35 [INFO] [stderr] | [INFO] [stderr] 701 | glx::GLX_AUX_BUFFERS, aux_buffers as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(aux_buffers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:702:32 [INFO] [stderr] | [INFO] [stderr] 702 | glx::GLX_RED_SIZE, red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:703:34 [INFO] [stderr] | [INFO] [stderr] 703 | glx::GLX_GREEN_SIZE, green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:704:33 [INFO] [stderr] | [INFO] [stderr] 704 | glx::GLX_BLUE_SIZE, blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:705:34 [INFO] [stderr] | [INFO] [stderr] 705 | glx::GLX_ALPHA_SIZE, alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:706:34 [INFO] [stderr] | [INFO] [stderr] 706 | glx::GLX_DEPTH_SIZE, depth_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(depth_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:707:36 [INFO] [stderr] | [INFO] [stderr] 707 | glx::GLX_STENCIL_SIZE, stencil_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:708:38 [INFO] [stderr] | [INFO] [stderr] 708 | glx::GLX_ACCUM_RED_SIZE, accum_red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:709:40 [INFO] [stderr] | [INFO] [stderr] 709 | glx::GLX_ACCUM_GREEN_SIZE, accum_green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:710:39 [INFO] [stderr] | [INFO] [stderr] 710 | glx::GLX_ACCUM_BLUE_SIZE, accum_blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:711:40 [INFO] [stderr] | [INFO] [stderr] 711 | glx::GLX_ACCUM_ALPHA_SIZE, accum_alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `glXCreateContextAttribsARB` should have a snake case name such as `gl_xcreate_context_attribs_arb` [INFO] [stderr] --> src/display/x11.rs:807:13 [INFO] [stderr] | [INFO] [stderr] 807 | let glXCreateContextAttribsARB = glx.ext.glXCreateContextAttribsARB.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:317:35 [INFO] [stderr] | [INFO] [stderr] 317 | pub fn to_axes(&self) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:412:30 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn to_normalized_f32(&self) -> f32 { unimplemented!() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:413:53 [INFO] [stderr] | [INFO] [stderr] 413 | pub fn to_normalized_signed_axis(&self) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:416:57 [INFO] [stderr] | [INFO] [stderr] 416 | pub fn to_normalized_unsigned_axis(&self) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GLX_EXTENSIONS` [INFO] [stderr] --> src/display/x11.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub const GLX_EXTENSIONS: i32 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `gen_fbconfig_attribs` [INFO] [stderr] --> src/display/x11.rs:690:5 [INFO] [stderr] | [INFO] [stderr] 690 | fn gen_fbconfig_attribs(settings: &GLContextSettings) -> [c_int; 37] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `None` should have an upper case name such as `NONE` [INFO] [stderr] --> src/display/x11.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub const None: i32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/display/x11.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | #[no_implicit_prelude] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/display/x11.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | / match self { [INFO] [stderr] 144 | | &Error::NoXDisplayForName { ref name } => { [INFO] [stderr] 145 | | let name = unsafe { CString::from_raw(x::XDisplayName( [INFO] [stderr] 146 | | match name { [INFO] [stderr] ... | [INFO] [stderr] 162 | | }, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *self { [INFO] [stderr] 144 | Error::NoXDisplayForName { ref name } => { [INFO] [stderr] 145 | let name = unsafe { CString::from_raw(x::XDisplayName( [INFO] [stderr] 146 | match name { [INFO] [stderr] 147 | &None => ptr::null(), [INFO] [stderr] 148 | &Some(ref name) => &name as *const _ as *const i8, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/display/x11.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | / match name { [INFO] [stderr] 147 | | &None => ptr::null(), [INFO] [stderr] 148 | | &Some(ref name) => &name as *const _ as *const i8, [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 146 | match *name { [INFO] [stderr] 147 | None => ptr::null(), [INFO] [stderr] 148 | Some(ref name) => &name as *const _ as *const i8, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/game_input_device/mod.rs:1067:9 [INFO] [stderr] | [INFO] [stderr] 1067 | / pub fn poll_iter<'a>(&'a mut self) -> PollIter<'a> { [INFO] [stderr] 1068 | | PollIter { _monitor: self } [INFO] [stderr] 1069 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/game_input_device/mod.rs:1072:9 [INFO] [stderr] | [INFO] [stderr] 1072 | / pub fn wait_iter<'a, T: Into>(&'a mut self, timeout: T) -> WaitIter<'a> { [INFO] [stderr] 1073 | | WaitIter { _monitor: self, _timeout: timeout.into() } [INFO] [stderr] 1074 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:1169:21 [INFO] [stderr] | [INFO] [stderr] 1169 | pub fn stop(&self) -> Result<(),()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:1174:27 [INFO] [stderr] | [INFO] [stderr] 1174 | pub fn is_playing(&self) -> Knowledge { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/display/x11.rs:599:33 [INFO] [stderr] | [INFO] [stderr] 599 | self.dpy.x_dpy, mem::transmute(title_ptr), 1, x::XUTF8StringStyle, &mut title_prop [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `title_ptr as *mut *mut i8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:601:26 [INFO] [stderr] | [INFO] [stderr] 601 | if status == x::Success as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(x::Success)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:662:35 [INFO] [stderr] | [INFO] [stderr] 662 | glx::GLX_AUX_BUFFERS, aux_buffers as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(aux_buffers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:663:32 [INFO] [stderr] | [INFO] [stderr] 663 | glx::GLX_RED_SIZE, red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:664:34 [INFO] [stderr] | [INFO] [stderr] 664 | glx::GLX_GREEN_SIZE, green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:665:33 [INFO] [stderr] | [INFO] [stderr] 665 | glx::GLX_BLUE_SIZE, blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:666:34 [INFO] [stderr] | [INFO] [stderr] 666 | glx::GLX_ALPHA_SIZE, alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:667:34 [INFO] [stderr] | [INFO] [stderr] 667 | glx::GLX_DEPTH_SIZE, depth_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(depth_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:668:36 [INFO] [stderr] | [INFO] [stderr] 668 | glx::GLX_STENCIL_SIZE, stencil_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:669:38 [INFO] [stderr] | [INFO] [stderr] 669 | glx::GLX_ACCUM_RED_SIZE, accum_red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:670:40 [INFO] [stderr] | [INFO] [stderr] 670 | glx::GLX_ACCUM_GREEN_SIZE, accum_green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:671:39 [INFO] [stderr] | [INFO] [stderr] 671 | glx::GLX_ACCUM_BLUE_SIZE, accum_blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:672:40 [INFO] [stderr] | [INFO] [stderr] 672 | glx::GLX_ACCUM_ALPHA_SIZE, accum_alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:701:35 [INFO] [stderr] | [INFO] [stderr] 701 | glx::GLX_AUX_BUFFERS, aux_buffers as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(aux_buffers)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:702:32 [INFO] [stderr] | [INFO] [stderr] 702 | glx::GLX_RED_SIZE, red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:703:34 [INFO] [stderr] | [INFO] [stderr] 703 | glx::GLX_GREEN_SIZE, green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:704:33 [INFO] [stderr] | [INFO] [stderr] 704 | glx::GLX_BLUE_SIZE, blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:705:34 [INFO] [stderr] | [INFO] [stderr] 705 | glx::GLX_ALPHA_SIZE, alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:706:34 [INFO] [stderr] | [INFO] [stderr] 706 | glx::GLX_DEPTH_SIZE, depth_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(depth_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:707:36 [INFO] [stderr] | [INFO] [stderr] 707 | glx::GLX_STENCIL_SIZE, stencil_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stencil_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:708:38 [INFO] [stderr] | [INFO] [stderr] 708 | glx::GLX_ACCUM_RED_SIZE, accum_red_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_red_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:709:40 [INFO] [stderr] | [INFO] [stderr] 709 | glx::GLX_ACCUM_GREEN_SIZE, accum_green_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_green_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:710:39 [INFO] [stderr] | [INFO] [stderr] 710 | glx::GLX_ACCUM_BLUE_SIZE, accum_blue_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_blue_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/display/x11.rs:711:40 [INFO] [stderr] | [INFO] [stderr] 711 | glx::GLX_ACCUM_ALPHA_SIZE, accum_alpha_bits as c_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(accum_alpha_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `glXCreateContextAttribsARB` should have a snake case name such as `gl_xcreate_context_attribs_arb` [INFO] [stderr] --> src/display/x11.rs:807:13 [INFO] [stderr] | [INFO] [stderr] 807 | let glXCreateContextAttribsARB = glx.ext.glXCreateContextAttribsARB.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/event/mod.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn get_raw_buffer<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 109 | | &self.raw_data [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &$name::$with(ref _val) = self { [INFO] [stderr] 47 | | true [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | false [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 125 | / option_alternative!{ [INFO] [stderr] 126 | | /// A value which is either known or unknown. [INFO] [stderr] 127 | | /// [INFO] [stderr] 128 | | /// APIs should use this instead [INFO] [stderr] ... | [INFO] [stderr] 138 | | is_unknown [INFO] [stderr] 139 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &$name::$with(ref opt) => opt.is_some(), [INFO] [stderr] 107 | | &$name::$without => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 125 | / option_alternative!{ [INFO] [stderr] 126 | | /// A value which is either known or unknown. [INFO] [stderr] 127 | | /// [INFO] [stderr] 128 | | /// APIs should use this instead [INFO] [stderr] ... | [INFO] [stderr] 138 | | is_unknown [INFO] [stderr] 139 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | / match self { [INFO] [stderr] 112 | | &$name::$with(ref opt) => opt.is_none(), [INFO] [stderr] 113 | | &$name::$without => false, [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 125 | / option_alternative!{ [INFO] [stderr] 126 | | /// A value which is either known or unknown. [INFO] [stderr] 127 | | /// [INFO] [stderr] 128 | | /// APIs should use this instead [INFO] [stderr] ... | [INFO] [stderr] 138 | | is_unknown [INFO] [stderr] 139 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &$name::$with(ref _val) = self { [INFO] [stderr] 47 | | true [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | false [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 142 | / option_alternative!{ [INFO] [stderr] 143 | | /// Type for values which may be either set manually or left for the [INFO] [stderr] 144 | | /// implementation to decide. [INFO] [stderr] 145 | | /// [INFO] [stderr] ... | [INFO] [stderr] 162 | | is_auto [INFO] [stderr] 163 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &$name::$with(ref opt) => opt.is_some(), [INFO] [stderr] 107 | | &$name::$without => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 142 | / option_alternative!{ [INFO] [stderr] 143 | | /// Type for values which may be either set manually or left for the [INFO] [stderr] 144 | | /// implementation to decide. [INFO] [stderr] 145 | | /// [INFO] [stderr] ... | [INFO] [stderr] 162 | | is_auto [INFO] [stderr] 163 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | / match self { [INFO] [stderr] 112 | | &$name::$with(ref opt) => opt.is_none(), [INFO] [stderr] 113 | | &$name::$without => false, [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 142 | / option_alternative!{ [INFO] [stderr] 143 | | /// Type for values which may be either set manually or left for the [INFO] [stderr] 144 | | /// implementation to decide. [INFO] [stderr] 145 | | /// [INFO] [stderr] ... | [INFO] [stderr] 162 | | is_auto [INFO] [stderr] 163 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:317:35 [INFO] [stderr] | [INFO] [stderr] 317 | pub fn to_axes(&self) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:412:30 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn to_normalized_f32(&self) -> f32 { unimplemented!() } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:413:53 [INFO] [stderr] | [INFO] [stderr] 413 | pub fn to_normalized_signed_axis(&self) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:416:57 [INFO] [stderr] | [INFO] [stderr] 416 | pub fn to_normalized_unsigned_axis(&self) -> T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/game_input_device/mod.rs:1067:9 [INFO] [stderr] | [INFO] [stderr] 1067 | / pub fn poll_iter<'a>(&'a mut self) -> PollIter<'a> { [INFO] [stderr] 1068 | | PollIter { _monitor: self } [INFO] [stderr] 1069 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/game_input_device/mod.rs:1072:9 [INFO] [stderr] | [INFO] [stderr] 1072 | / pub fn wait_iter<'a, T: Into>(&'a mut self, timeout: T) -> WaitIter<'a> { [INFO] [stderr] 1073 | | WaitIter { _monitor: self, _timeout: timeout.into() } [INFO] [stderr] 1074 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:1169:21 [INFO] [stderr] | [INFO] [stderr] 1169 | pub fn stop(&self) -> Result<(),()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_input_device/mod.rs:1174:27 [INFO] [stderr] | [INFO] [stderr] 1174 | pub fn is_playing(&self) -> Knowledge { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/event/mod.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn get_raw_buffer<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 109 | | &self.raw_data [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &$name::$with(ref _val) = self { [INFO] [stderr] 47 | | true [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | false [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 125 | / option_alternative!{ [INFO] [stderr] 126 | | /// A value which is either known or unknown. [INFO] [stderr] 127 | | /// [INFO] [stderr] 128 | | /// APIs should use this instead [INFO] [stderr] ... | [INFO] [stderr] 138 | | is_unknown [INFO] [stderr] 139 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &$name::$with(ref opt) => opt.is_some(), [INFO] [stderr] 107 | | &$name::$without => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 125 | / option_alternative!{ [INFO] [stderr] 126 | | /// A value which is either known or unknown. [INFO] [stderr] 127 | | /// [INFO] [stderr] 128 | | /// APIs should use this instead [INFO] [stderr] ... | [INFO] [stderr] 138 | | is_unknown [INFO] [stderr] 139 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | / match self { [INFO] [stderr] 112 | | &$name::$with(ref opt) => opt.is_none(), [INFO] [stderr] 113 | | &$name::$without => false, [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 125 | / option_alternative!{ [INFO] [stderr] 126 | | /// A value which is either known or unknown. [INFO] [stderr] 127 | | /// [INFO] [stderr] 128 | | /// APIs should use this instead [INFO] [stderr] ... | [INFO] [stderr] 138 | | is_unknown [INFO] [stderr] 139 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | / if let &$name::$with(ref _val) = self { [INFO] [stderr] 47 | | true [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | false [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 142 | / option_alternative!{ [INFO] [stderr] 143 | | /// Type for values which may be either set manually or left for the [INFO] [stderr] 144 | | /// implementation to decide. [INFO] [stderr] 145 | | /// [INFO] [stderr] ... | [INFO] [stderr] 162 | | is_auto [INFO] [stderr] 163 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match self { [INFO] [stderr] 106 | | &$name::$with(ref opt) => opt.is_some(), [INFO] [stderr] 107 | | &$name::$without => false, [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 142 | / option_alternative!{ [INFO] [stderr] 143 | | /// Type for values which may be either set manually or left for the [INFO] [stderr] 144 | | /// implementation to decide. [INFO] [stderr] 145 | | /// [INFO] [stderr] ... | [INFO] [stderr] 162 | | is_auto [INFO] [stderr] 163 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/option_alternatives.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | / match self { [INFO] [stderr] 112 | | &$name::$with(ref opt) => opt.is_none(), [INFO] [stderr] 113 | | &$name::$without => false, [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 142 | / option_alternative!{ [INFO] [stderr] 143 | | /// Type for values which may be either set manually or left for the [INFO] [stderr] 144 | | /// implementation to decide. [INFO] [stderr] 145 | | /// [INFO] [stderr] ... | [INFO] [stderr] 162 | | is_auto [INFO] [stderr] 163 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.41s [INFO] running `"docker" "inspect" "d89b9604251ed9053eda94097b663df1db9497e61fe87b4daf79345b6e5b3ebf"` [INFO] running `"docker" "rm" "-f" "d89b9604251ed9053eda94097b663df1db9497e61fe87b4daf79345b6e5b3ebf"` [INFO] [stdout] d89b9604251ed9053eda94097b663df1db9497e61fe87b4daf79345b6e5b3ebf