[INFO] crate dmap 0.2.1 is already in cache [INFO] extracting crate dmap 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/dmap/0.2.1 [INFO] extracting crate dmap 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dmap/0.2.1 [INFO] validating manifest of dmap-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmap-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmap-0.2.1 [INFO] finished frobbing dmap-0.2.1 [INFO] frobbed toml for dmap-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/dmap/0.2.1/Cargo.toml [INFO] started frobbing dmap-0.2.1 [INFO] finished frobbing dmap-0.2.1 [INFO] frobbed toml for dmap-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dmap/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmap-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dmap/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28f1be7f70139435315a3315612894357b3f6a9afbc6009b112ebec3b91a6b08 [INFO] running `"docker" "start" "-a" "28f1be7f70139435315a3315612894357b3f6a9afbc6009b112ebec3b91a6b08"` [INFO] [stderr] Checking dmap v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/de.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | let code = match &self.typedesc { [INFO] [stderr] | ____________________^ [INFO] [stderr] 22 | | &Ok(ref c) => &c.code, [INFO] [stderr] 23 | | &Err(x) => x, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | let code = match self.typedesc { [INFO] [stderr] 22 | Ok(ref c) => &c.code, [INFO] [stderr] 23 | Err(x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:47:48 [INFO] [stderr] | [INFO] [stderr] 47 | let code_ref = input.get(0..4).ok_or(err.clone())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:49:64 [INFO] [stderr] | [INFO] [stderr] 49 | let size = BigEndian::read_u32(input.get(4..8).ok_or(err.clone())?) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `copy_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/ser.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | buf.copy_from_slice(&mut self.output[offset..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | fn ser_content_code(code: &[u8; 4], s: S) -> Result [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/de.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | let code = match &self.typedesc { [INFO] [stderr] | ____________________^ [INFO] [stderr] 22 | | &Ok(ref c) => &c.code, [INFO] [stderr] 23 | | &Err(x) => x, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | let code = match self.typedesc { [INFO] [stderr] 22 | Ok(ref c) => &c.code, [INFO] [stderr] 23 | Err(x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:47:48 [INFO] [stderr] | [INFO] [stderr] 47 | let code_ref = input.get(0..4).ok_or(err.clone())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/de.rs:49:64 [INFO] [stderr] | [INFO] [stderr] 49 | let size = BigEndian::read_u32(input.get(4..8).ok_or(err.clone())?) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `copy_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/ser.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | buf.copy_from_slice(&mut self.output[offset..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | fn ser_content_code(code: &[u8; 4], s: S) -> Result [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.76s [INFO] running `"docker" "inspect" "28f1be7f70139435315a3315612894357b3f6a9afbc6009b112ebec3b91a6b08"` [INFO] running `"docker" "rm" "-f" "28f1be7f70139435315a3315612894357b3f6a9afbc6009b112ebec3b91a6b08"` [INFO] [stdout] 28f1be7f70139435315a3315612894357b3f6a9afbc6009b112ebec3b91a6b08