[INFO] crate dlopen_derive 0.1.3 is already in cache [INFO] extracting crate dlopen_derive 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/dlopen_derive/0.1.3 [INFO] extracting crate dlopen_derive 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dlopen_derive/0.1.3 [INFO] validating manifest of dlopen_derive-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dlopen_derive-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dlopen_derive-0.1.3 [INFO] finished frobbing dlopen_derive-0.1.3 [INFO] frobbed toml for dlopen_derive-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/dlopen_derive/0.1.3/Cargo.toml [INFO] started frobbing dlopen_derive-0.1.3 [INFO] finished frobbing dlopen_derive-0.1.3 [INFO] frobbed toml for dlopen_derive-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dlopen_derive/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dlopen_derive-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dlopen_derive/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53361ad5308fe63efac44bd37c3b3d5d2e34f060396b359ac2209cf7697bbbf7 [INFO] running `"docker" "start" "-a" "53361ad5308fe63efac44bd37c3b3d5d2e34f060396b359ac2209cf7697bbbf7"` [INFO] [stderr] Checking dlopen_derive v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/wrapper.rs:73:41 [INFO] [stderr] | [INFO] [stderr] 73 | fn allow_null_field(field: &Field, ptr: &Box) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&MutTy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wrapper.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / match &field.ty { [INFO] [stderr] 96 | | &Ty::BareFn(ref fun) => { [INFO] [stderr] 97 | | if fun.variadic { [INFO] [stderr] 98 | | None [INFO] [stderr] ... | [INFO] [stderr] 143 | | _ => panic!("Unknown field type, this should not happen!") [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | match field.ty { [INFO] [stderr] 96 | Ty::BareFn(ref fun) => { [INFO] [stderr] 97 | if fun.variadic { [INFO] [stderr] 98 | None [INFO] [stderr] 99 | } else { [INFO] [stderr] 100 | let ret_ty = match fun.output { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | return match it { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 20 | | &Lit::Str(ref val, ..) => { [INFO] [stderr] 21 | | Some(val.as_ref()) [INFO] [stderr] 22 | | }, [INFO] [stderr] 23 | | _ => panic!("{} attribute must be a string", attr_name) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | return match *it { [INFO] [stderr] 20 | Lit::Str(ref val, ..) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / match vd { [INFO] [stderr] 51 | | & VariantData::Struct( ref f) => f, [INFO] [stderr] 52 | | & VariantData::Tuple(_) | &VariantData::Unit => panic ! ("{} can be only implemented for structures", trait_name) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *vd { [INFO] [stderr] 51 | VariantData::Struct( ref f) => f, [INFO] [stderr] 52 | VariantData::Tuple(_) | VariantData::Unit => panic ! ("{} can be only implemented for structures", trait_name) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/wrapper.rs:73:41 [INFO] [stderr] | [INFO] [stderr] 73 | fn allow_null_field(field: &Field, ptr: &Box) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&MutTy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/wrapper.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / match &field.ty { [INFO] [stderr] 96 | | &Ty::BareFn(ref fun) => { [INFO] [stderr] 97 | | if fun.variadic { [INFO] [stderr] 98 | | None [INFO] [stderr] ... | [INFO] [stderr] 143 | | _ => panic!("Unknown field type, this should not happen!") [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | match field.ty { [INFO] [stderr] 96 | Ty::BareFn(ref fun) => { [INFO] [stderr] 97 | if fun.variadic { [INFO] [stderr] 98 | None [INFO] [stderr] 99 | } else { [INFO] [stderr] 100 | let ret_ty = match fun.output { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | return match it { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 20 | | &Lit::Str(ref val, ..) => { [INFO] [stderr] 21 | | Some(val.as_ref()) [INFO] [stderr] 22 | | }, [INFO] [stderr] 23 | | _ => panic!("{} attribute must be a string", attr_name) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | return match *it { [INFO] [stderr] 20 | Lit::Str(ref val, ..) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / match vd { [INFO] [stderr] 51 | | & VariantData::Struct( ref f) => f, [INFO] [stderr] 52 | | & VariantData::Tuple(_) | &VariantData::Unit => panic ! ("{} can be only implemented for structures", trait_name) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 50 | match *vd { [INFO] [stderr] 51 | VariantData::Struct( ref f) => f, [INFO] [stderr] 52 | VariantData::Tuple(_) | VariantData::Unit => panic ! ("{} can be only implemented for structures", trait_name) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "53361ad5308fe63efac44bd37c3b3d5d2e34f060396b359ac2209cf7697bbbf7"` [INFO] running `"docker" "rm" "-f" "53361ad5308fe63efac44bd37c3b3d5d2e34f060396b359ac2209cf7697bbbf7"` [INFO] [stdout] 53361ad5308fe63efac44bd37c3b3d5d2e34f060396b359ac2209cf7697bbbf7