[INFO] crate dlc-decrypter 0.2.1 is already in cache [INFO] extracting crate dlc-decrypter 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/dlc-decrypter/0.2.1 [INFO] extracting crate dlc-decrypter 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dlc-decrypter/0.2.1 [INFO] validating manifest of dlc-decrypter-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dlc-decrypter-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dlc-decrypter-0.2.1 [INFO] finished frobbing dlc-decrypter-0.2.1 [INFO] frobbed toml for dlc-decrypter-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/dlc-decrypter/0.2.1/Cargo.toml [INFO] started frobbing dlc-decrypter-0.2.1 [INFO] finished frobbing dlc-decrypter-0.2.1 [INFO] frobbed toml for dlc-decrypter-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dlc-decrypter/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dlc-decrypter-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dlc-decrypter/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 728b7aa7758372b9e0025ca273bbf12e8ea1074c319d765701bbb14f0b1cb030 [INFO] running `"docker" "start" "-a" "728b7aa7758372b9e0025ca273bbf12e8ea1074c319d765701bbb14f0b1cb030"` [INFO] [stderr] Checking dlc-decrypter v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | return Ok(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | return Ok(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(data)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return Ok(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DlcDecoder` [INFO] [stderr] --> src/lib.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new() -> DlcDecoder { [INFO] [stderr] 133 | | DlcDecoder { [INFO] [stderr] 134 | | jd_app_name: "pylo".to_string(), [INFO] [stderr] 135 | | jd_decryption_key: b"cb99b5cbc24db398".to_vec(), [INFO] [stderr] 136 | | jd_decryption_iv: b"9bc24cb995cb8db3".to_vec() [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:149:39 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn from_file>(&self, path: P) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn from_data(&self, data: &[u8]) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:295:46 [INFO] [stderr] | [INFO] [stderr] 295 | let details: Vec<&str> = f.split("<").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:298:49 [INFO] [stderr] | [INFO] [stderr] 298 | if d.len() > 3 && d[..3] == "url".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"url"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:301:56 [INFO] [stderr] | [INFO] [stderr] 301 | } else if d.len() > 8 && d[..8] == "filename".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `"filename"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:304:56 [INFO] [stderr] | [INFO] [stderr] 304 | } else if d.len() > 4 && d[..4] == "size".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"size"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DlcDecoder` [INFO] [stderr] --> src/lib.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new() -> DlcDecoder { [INFO] [stderr] 133 | | DlcDecoder { [INFO] [stderr] 134 | | jd_app_name: "pylo".to_string(), [INFO] [stderr] 135 | | jd_decryption_key: b"cb99b5cbc24db398".to_vec(), [INFO] [stderr] 136 | | jd_decryption_iv: b"9bc24cb995cb8db3".to_vec() [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:149:39 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn from_file>(&self, path: P) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:160:22 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn from_data(&self, data: &[u8]) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:295:46 [INFO] [stderr] | [INFO] [stderr] 295 | let details: Vec<&str> = f.split("<").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'<'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:298:49 [INFO] [stderr] | [INFO] [stderr] 298 | if d.len() > 3 && d[..3] == "url".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"url"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:301:56 [INFO] [stderr] | [INFO] [stderr] 301 | } else if d.len() > 8 && d[..8] == "filename".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `"filename"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:304:56 [INFO] [stderr] | [INFO] [stderr] 304 | } else if d.len() > 4 && d[..4] == "size".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"size"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.52s [INFO] running `"docker" "inspect" "728b7aa7758372b9e0025ca273bbf12e8ea1074c319d765701bbb14f0b1cb030"` [INFO] running `"docker" "rm" "-f" "728b7aa7758372b9e0025ca273bbf12e8ea1074c319d765701bbb14f0b1cb030"` [INFO] [stdout] 728b7aa7758372b9e0025ca273bbf12e8ea1074c319d765701bbb14f0b1cb030