[INFO] crate dkregistry 0.2.1 is already in cache [INFO] extracting crate dkregistry 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/dkregistry/0.2.1 [INFO] extracting crate dkregistry 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dkregistry/0.2.1 [INFO] validating manifest of dkregistry-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dkregistry-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dkregistry-0.2.1 [INFO] finished frobbing dkregistry-0.2.1 [INFO] frobbed toml for dkregistry-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/dkregistry/0.2.1/Cargo.toml [INFO] started frobbing dkregistry-0.2.1 [INFO] finished frobbing dkregistry-0.2.1 [INFO] frobbed toml for dkregistry-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dkregistry/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dkregistry-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dkregistry/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca5e2e381524eca2b44934d937809c043f6dd9467baa1817b0b604d9a6e3f54a [INFO] running `"docker" "start" "-a" "ca5e2e381524eca2b44934d937809c043f6dd9467baa1817b0b604d9a6e3f54a"` [INFO] [stderr] Checking tokio-rustls v0.7.2 [INFO] [stderr] Checking hyper-rustls v0.14.0 [INFO] [stderr] Checking dkregistry v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> examples/checkregistry.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match supported { [INFO] [stderr] 33 | | false => println!("{} does NOT support v2", host), [INFO] [stderr] 34 | | true => println!("{} supports v2", host), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if supported { println!("{} supports v2", host) } else { println!("{} does NOT support v2", host) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let r =` [INFO] [stderr] --> examples/image.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | let r = render::unpack(&blobs, &can_path).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> examples/image.rs:141:8 [INFO] [stderr] | [INFO] [stderr] 141 | Ok(r) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 141 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/trace.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | / return Err( [INFO] [stderr] 88 | | format!("{}:{} doesn't have a manifest", &image, &version).into() [INFO] [stderr] 89 | | ) [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 87 | Err( [INFO] [stderr] 88 | format!("{}:{} doesn't have a manifest", &image, &version).into() [INFO] [stderr] 89 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.43s [INFO] running `"docker" "inspect" "ca5e2e381524eca2b44934d937809c043f6dd9467baa1817b0b604d9a6e3f54a"` [INFO] running `"docker" "rm" "-f" "ca5e2e381524eca2b44934d937809c043f6dd9467baa1817b0b604d9a6e3f54a"` [INFO] [stdout] ca5e2e381524eca2b44934d937809c043f6dd9467baa1817b0b604d9a6e3f54a