[INFO] crate distro-info 0.3.0 is already in cache [INFO] extracting crate distro-info 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/distro-info/0.3.0 [INFO] extracting crate distro-info 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/distro-info/0.3.0 [INFO] validating manifest of distro-info-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of distro-info-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing distro-info-0.3.0 [INFO] finished frobbing distro-info-0.3.0 [INFO] frobbed toml for distro-info-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/distro-info/0.3.0/Cargo.toml [INFO] started frobbing distro-info-0.3.0 [INFO] finished frobbing distro-info-0.3.0 [INFO] frobbed toml for distro-info-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/distro-info/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting distro-info-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/distro-info/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] befb18b9ff827c611818ec33073495ad47a54ce6261c26550677eb802bdd55fa [INFO] running `"docker" "start" "-a" "befb18b9ff827c611818ec33073495ad47a54ce6261c26550677eb802bdd55fa"` [INFO] [stderr] Checking distro-info v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | codename: codename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `codename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | series: series, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `series` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | created: created, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `created` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | release: release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | eol: eol, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `eol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | eol_server: eol_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `eol_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | codename: codename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `codename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | series: series, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `series` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | created: created, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `created` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | release: release, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | eol: eol, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `eol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | eol_server: eol_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `eol_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/lib.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn released_at(&self, date: &NaiveDate) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:78:30 [INFO] [stderr] | [INFO] [stderr] 78 | Some(release) => date >= &release, [INFO] [stderr] | ^^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `release` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:83:38 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn supported_at(&self, date: &NaiveDate) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | None => date <= &eol, [INFO] [stderr] | ^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `eol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / match field { [INFO] [stderr] 115 | | &Some(field) => Ok(Some(NaiveDate::parse_from_str(field, "%Y-%m-%d")?)), [INFO] [stderr] 116 | | &None => Err(format_err!("unexpected error from: {:?}", field)), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *field { [INFO] [stderr] 115 | Some(field) => Ok(Some(NaiveDate::parse_from_str(field, "%Y-%m-%d")?)), [INFO] [stderr] 116 | None => Err(format_err!("unexpected error from: {:?}", field)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | / match field { [INFO] [stderr] 121 | | &Some(field) => parse_date(&Some(field)), [INFO] [stderr] 122 | | &None => Ok(None), [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | match *field { [INFO] [stderr] 121 | Some(field) => parse_date(&Some(field)), [INFO] [stderr] 122 | None => Ok(None), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / pub fn latest<'a>(&'a self, date: NaiveDate) -> &DistroRelease { [INFO] [stderr] 194 | | // This will only be None if there are no entries in the CSV, which means things are very [INFO] [stderr] 195 | | // broken [INFO] [stderr] 196 | | self.all_at(date).last().unwrap() [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn released_at(&self, date: &NaiveDate) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:78:30 [INFO] [stderr] | [INFO] [stderr] 78 | Some(release) => date >= &release, [INFO] [stderr] | ^^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `release` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:83:38 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn supported_at(&self, date: &NaiveDate) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | None => date <= &eol, [INFO] [stderr] | ^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `eol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / match field { [INFO] [stderr] 115 | | &Some(field) => Ok(Some(NaiveDate::parse_from_str(field, "%Y-%m-%d")?)), [INFO] [stderr] 116 | | &None => Err(format_err!("unexpected error from: {:?}", field)), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *field { [INFO] [stderr] 115 | Some(field) => Ok(Some(NaiveDate::parse_from_str(field, "%Y-%m-%d")?)), [INFO] [stderr] 116 | None => Err(format_err!("unexpected error from: {:?}", field)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | / match field { [INFO] [stderr] 121 | | &Some(field) => parse_date(&Some(field)), [INFO] [stderr] 122 | | &None => Ok(None), [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 120 | match *field { [INFO] [stderr] 121 | Some(field) => parse_date(&Some(field)), [INFO] [stderr] 122 | None => Ok(None), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / pub fn latest<'a>(&'a self, date: NaiveDate) -> &DistroRelease { [INFO] [stderr] 194 | | // This will only be None if there are no entries in the CSV, which means things are very [INFO] [stderr] 195 | | // broken [INFO] [stderr] 196 | | self.all_at(date).last().unwrap() [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/lib.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | / DistroRelease { [INFO] [stderr] 222 | | version: "version".to_string(), [INFO] [stderr] 223 | | codename: "codename".to_string(), [INFO] [stderr] 224 | | series: "series".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 228 | | eol_server: Some(NaiveDate::from_ymd(2018, 6, 14)), [INFO] [stderr] 229 | | }; [INFO] [stderr] | |__________^ help: replace it with: `"version".to_string();"codename".to_string();"series".to_string();Some(NaiveDate::from_ymd(2018, 6, 14));Some(NaiveDate::from_ymd(2018, 6, 14));Some(NaiveDate::from_ymd(2018, 6, 14));Some(NaiveDate::from_ymd(2018, 6, 14));` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | n = n - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.21s [INFO] running `"docker" "inspect" "befb18b9ff827c611818ec33073495ad47a54ce6261c26550677eb802bdd55fa"` [INFO] running `"docker" "rm" "-f" "befb18b9ff827c611818ec33073495ad47a54ce6261c26550677eb802bdd55fa"` [INFO] [stdout] befb18b9ff827c611818ec33073495ad47a54ce6261c26550677eb802bdd55fa