[INFO] crate display_derive 0.0.0 is already in cache [INFO] extracting crate display_derive 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/display_derive/0.0.0 [INFO] extracting crate display_derive 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/display_derive/0.0.0 [INFO] validating manifest of display_derive-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of display_derive-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing display_derive-0.0.0 [INFO] finished frobbing display_derive-0.0.0 [INFO] frobbed toml for display_derive-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/display_derive/0.0.0/Cargo.toml [INFO] started frobbing display_derive-0.0.0 [INFO] finished frobbing display_derive-0.0.0 [INFO] frobbed toml for display_derive-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/display_derive/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting display_derive-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/display_derive/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3f5c892fb86d10b74a08eef2f54d9a1055d817348375e88efd30e4ff798e2c2 [INFO] running `"docker" "start" "-a" "a3f5c892fb86d10b74a08eef2f54d9a1055d817348375e88efd30e4ff798e2c2"` [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Compiling display_derive v0.0.0 (/opt/crater/workdir) [INFO] [stderr] Checking synstructure v0.6.1 [INFO] [stderr] warning: All variants have the same postfix: `Variant` [INFO] [stderr] --> tests/tests.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / enum EnumError { [INFO] [stderr] 37 | | #[display(fmt = "Error code: {}", code)] [INFO] [stderr] 38 | | StructVariant { [INFO] [stderr] 39 | | code: i32, [INFO] [stderr] ... | [INFO] [stderr] 44 | | UnitVariant, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 88 | | if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 89 | | display_msg = Some(&list[..]); [INFO] [stderr] 90 | | } else { [INFO] [stderr] 91 | | panic!("Display attribute must take a list in parentheses") [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 88 | display_msg = Some(&list[..]); [INFO] [stderr] 89 | } else { [INFO] [stderr] 90 | panic!("Display attribute must take a list in parentheses") [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:59:44 [INFO] [stderr] | [INFO] [stderr] 59 | if id.as_ref().starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 88 | | if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 89 | | display_msg = Some(&list[..]); [INFO] [stderr] 90 | | } else { [INFO] [stderr] 91 | | panic!("Display attribute must take a list in parentheses") [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if let syn::MetaItem::List(_, ref list) = attr.value { [INFO] [stderr] 88 | display_msg = Some(&list[..]); [INFO] [stderr] 89 | } else { [INFO] [stderr] 90 | panic!("Display attribute must take a list in parentheses") [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:59:44 [INFO] [stderr] | [INFO] [stderr] 59 | if id.as_ref().starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.96s [INFO] running `"docker" "inspect" "a3f5c892fb86d10b74a08eef2f54d9a1055d817348375e88efd30e4ff798e2c2"` [INFO] running `"docker" "rm" "-f" "a3f5c892fb86d10b74a08eef2f54d9a1055d817348375e88efd30e4ff798e2c2"` [INFO] [stdout] a3f5c892fb86d10b74a08eef2f54d9a1055d817348375e88efd30e4ff798e2c2