[INFO] crate display-as 0.3.1 is already in cache [INFO] extracting crate display-as 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/display-as/0.3.1 [INFO] extracting crate display-as 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/display-as/0.3.1 [INFO] validating manifest of display-as-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of display-as-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing display-as-0.3.1 [INFO] finished frobbing display-as-0.3.1 [INFO] frobbed toml for display-as-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/display-as/0.3.1/Cargo.toml [INFO] started frobbing display-as-0.3.1 [INFO] finished frobbing display-as-0.3.1 [INFO] frobbed toml for display-as-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/display-as/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting display-as-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/display-as/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12c08c5c88ee9c8dfa8e8c69b835ca8cf3c220770cf6cd0a7bee051dc3a9ffb5 [INFO] running `"docker" "start" "-a" "12c08c5c88ee9c8dfa8e8c69b835ca8cf3c220770cf6cd0a7bee051dc3a9ffb5"` [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling proc-macro-hack v0.5.4 [INFO] [stderr] Compiling display-as-proc-macro v0.3.1 [INFO] [stderr] Checking display-as v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return mime::TEXT_HTML_UTF_8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mime::TEXT_HTML_UTF_8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/latex.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return "text/x-latex".parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"text/x-latex".parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mathlatex.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return "text/x-latex".parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"text/x-latex".parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return "text/x-rust".parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"text/x-rust".parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return mime::TEXT_HTML_UTF_8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `mime::TEXT_HTML_UTF_8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/float.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 149 | | if *exponent + 1 > mantissa.len() as i16 { [INFO] [stderr] 150 | | f.write_str(mantissa)?; [INFO] [stderr] 151 | | for _ in 0..*exponent as usize + 1 - mantissa.len() { [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | } else if *exponent + 1 > mantissa.len() as i16 { [INFO] [stderr] 149 | f.write_str(mantissa)?; [INFO] [stderr] 150 | for _ in 0..*exponent as usize + 1 - mantissa.len() { [INFO] [stderr] 151 | f.write_str("0")?; [INFO] [stderr] 152 | } [INFO] [stderr] 153 | Ok(()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/latex.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return "text/x-latex".parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"text/x-latex".parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mathlatex.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return "text/x-latex".parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"text/x-latex".parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rust.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return "text/x-rust".parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"text/x-rust".parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/float.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 149 | | if *exponent + 1 > mantissa.len() as i16 { [INFO] [stderr] 150 | | f.write_str(mantissa)?; [INFO] [stderr] 151 | | for _ in 0..*exponent as usize + 1 - mantissa.len() { [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | } else if *exponent + 1 > mantissa.len() as i16 { [INFO] [stderr] 149 | f.write_str(mantissa)?; [INFO] [stderr] 150 | for _ in 0..*exponent as usize + 1 - mantissa.len() { [INFO] [stderr] 151 | f.write_str("0")?; [INFO] [stderr] 152 | } [INFO] [stderr] 153 | Ok(()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/float.rs:193:46 [INFO] [stderr] | [INFO] [stderr] 193 | assert_eq!(&format!("{}", Floating::from(0.001234)), "0.001234"); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.001_234` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/float.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | let mut parts = x.splitn(2, "e"); [INFO] [stderr] | ^^^ help: try using a char instead: `'e'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/float.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | let mut parts = x.splitn(2, "e"); [INFO] [stderr] | ^^^ help: try using a char instead: `'e'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / fn display_as<'a>(&'a self, _format: F) -> As<'a, F, Self> { [INFO] [stderr] 269 | | As::from(self) [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/float.rs:37:37 [INFO] [stderr] | [INFO] [stderr] 37 | let mut parts = x.splitn(2, "e"); [INFO] [stderr] | ^^^ help: try using a char instead: `'e'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/float.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | let mut parts = x.splitn(2, "e"); [INFO] [stderr] | ^^^ help: try using a char instead: `'e'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / fn display_as<'a>(&'a self, _format: F) -> As<'a, F, Self> { [INFO] [stderr] 269 | | As::from(self) [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/loop_in_let.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | format_as!(HTML, let foo = { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/format_as.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | let foo = 3.0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/format_as.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | let bar = 2.0; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/format_as.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let foo = 3e6; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/format_as.rs:84:30 [INFO] [stderr] | [INFO] [stderr] 84 | format_as!(HTML, let foo = { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/format_as.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | let foo = { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.64s [INFO] running `"docker" "inspect" "12c08c5c88ee9c8dfa8e8c69b835ca8cf3c220770cf6cd0a7bee051dc3a9ffb5"` [INFO] running `"docker" "rm" "-f" "12c08c5c88ee9c8dfa8e8c69b835ca8cf3c220770cf6cd0a7bee051dc3a9ffb5"` [INFO] [stdout] 12c08c5c88ee9c8dfa8e8c69b835ca8cf3c220770cf6cd0a7bee051dc3a9ffb5