[INFO] crate discrimination 0.0.2 is already in cache [INFO] extracting crate discrimination 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/discrimination/0.0.2 [INFO] extracting crate discrimination 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/discrimination/0.0.2 [INFO] validating manifest of discrimination-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of discrimination-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing discrimination-0.0.2 [INFO] finished frobbing discrimination-0.0.2 [INFO] frobbed toml for discrimination-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/discrimination/0.0.2/Cargo.toml [INFO] started frobbing discrimination-0.0.2 [INFO] finished frobbing discrimination-0.0.2 [INFO] frobbed toml for discrimination-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/discrimination/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting discrimination-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/discrimination/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c36da533031c94f67f302c88492b91c8b08284e463426ccec311f49a04380df3 [INFO] running `"docker" "start" "-a" "c36da533031c94f67f302c88492b91c8b08284e463426ccec311f49a04380df3"` [INFO] [stderr] Checking discrimination v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/discriminator.rs:347:19 [INFO] [stderr] | [INFO] [stderr] 347 | Natural { limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/discriminator.rs:356:19 [INFO] [stderr] | [INFO] [stderr] 356 | Natural { limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/discriminator.rs:347:19 [INFO] [stderr] | [INFO] [stderr] 347 | Natural { limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/discriminator.rs:356:19 [INFO] [stderr] | [INFO] [stderr] 356 | Natural { limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/discriminator.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/discriminator.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/discriminator.rs:448:22 [INFO] [stderr] | [INFO] [stderr] 448 | const DESC: &'static Map usize, Natural> = [INFO] [stderr] | -^^^^^^^------------------------------ help: consider removing `'static`: `&Map usize, Natural>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/discriminator.rs:478:26 [INFO] [stderr] | [INFO] [stderr] 478 | const DESC: &'static Map usize, Natural> = [INFO] [stderr] | -^^^^^^^------------------------------- help: consider removing `'static`: `&Map usize, Natural>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/discriminator.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/discriminator.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | return buckets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/discriminator.rs:448:22 [INFO] [stderr] | [INFO] [stderr] 448 | const DESC: &'static Map usize, Natural> = [INFO] [stderr] | -^^^^^^^------------------------------ help: consider removing `'static`: `&Map usize, Natural>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/discriminator.rs:478:26 [INFO] [stderr] | [INFO] [stderr] 478 | const DESC: &'static Map usize, Natural> = [INFO] [stderr] | -^^^^^^^------------------------------- help: consider removing `'static`: `&Map usize, Natural>` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/discriminator.rs:631:40 [INFO] [stderr] | [INFO] [stderr] 631 | let (left_pairs, right_pairs): (SplitEitherLeft<(J, V), (K, V), _>, [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 632 | | SplitEitherRight<(J, V), (K, V), _>) = [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/split_either.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | -> (SplitEitherLeft, SplitEitherRight) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/discriminator.rs:631:40 [INFO] [stderr] | [INFO] [stderr] 631 | let (left_pairs, right_pairs): (SplitEitherLeft<(J, V), (K, V), _>, [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 632 | | SplitEitherRight<(J, V), (K, V), _>) = [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/split_either.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | -> (SplitEitherLeft, SplitEitherRight) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.97s [INFO] running `"docker" "inspect" "c36da533031c94f67f302c88492b91c8b08284e463426ccec311f49a04380df3"` [INFO] running `"docker" "rm" "-f" "c36da533031c94f67f302c88492b91c8b08284e463426ccec311f49a04380df3"` [INFO] [stdout] c36da533031c94f67f302c88492b91c8b08284e463426ccec311f49a04380df3