[INFO] crate discovery_rust 0.1.1 is already in cache
[INFO] extracting crate discovery_rust 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/discovery_rust/0.1.1
[INFO] extracting crate discovery_rust 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/discovery_rust/0.1.1
[INFO] validating manifest of discovery_rust-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of discovery_rust-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing discovery_rust-0.1.1
[INFO] finished frobbing discovery_rust-0.1.1
[INFO] frobbed toml for discovery_rust-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/discovery_rust/0.1.1/Cargo.toml
[INFO] started frobbing discovery_rust-0.1.1
[INFO] finished frobbing discovery_rust-0.1.1
[INFO] frobbed toml for discovery_rust-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/discovery_rust/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting discovery_rust-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/discovery_rust/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 55e758d2cbcdf73f12f001e6682eb420db9950006e02bace375bbe0354eef461
[INFO] running `"docker" "start" "-a" "55e758d2cbcdf73f12f001e6682eb420db9950006e02bace375bbe0354eef461"`
[INFO] [stderr] warning: only one of `license` or `license-file` is necessary
[INFO] [stderr]     Checking consul_rust v0.1.0
[INFO] [stderr]     Checking discovery_rust v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::collections::HashMap`
[INFO] [stderr]  --> src/lib.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Write`, `self`
[INFO] [stderr]  --> src/core/diplomat.rs:9:15
[INFO] [stderr]   |
[INFO] [stderr] 9 | use std::io::{self, Write};
[INFO] [stderr]   |               ^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::iter::FromIterator`
[INFO] [stderr]   --> src/core/diplomat.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use std::iter::FromIterator;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Host`
[INFO] [stderr]   --> src/core/diplomat.rs:11:11
[INFO] [stderr]    |
[INFO] [stderr] 11 | use url::{Host, Url};
[INFO] [stderr]    |           ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:14:31
[INFO] [stderr]    |
[INFO] [stderr] 14 | const SERVICE_DISCOVERY_URI: &'static str = "SERVICE_DISCOVERY_URI";
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:15:32
[INFO] [stderr]    |
[INFO] [stderr] 15 | const DEFAULT_DISCOVERY_HOST: &'static str = "127.0.0.1";
[INFO] [stderr]    |                               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 | const CONSISTENT: &'static str = "Consistent";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:19:15
[INFO] [stderr]    |
[INFO] [stderr] 19 | const STALE: &'static str = "Stale";
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/core/diplomat.rs:102:9
[INFO] [stderr]     |
[INFO] [stderr] 102 |         result
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/core/diplomat.rs:100:22
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let result = self.health(name, cfg);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core/diplomat.rs:133:17
[INFO] [stderr]     |
[INFO] [stderr] 133 |                 return self.health_with_cache(name, refresh, cfg);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.health_with_cache(name, refresh, cfg)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::collections::HashMap`
[INFO] [stderr]  --> src/lib.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `Write`, `self`
[INFO] [stderr]  --> src/core/diplomat.rs:9:15
[INFO] [stderr]   |
[INFO] [stderr] 9 | use std::io::{self, Write};
[INFO] [stderr]   |               ^^^^  ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::iter::FromIterator`
[INFO] [stderr]   --> src/core/diplomat.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use std::iter::FromIterator;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Host`
[INFO] [stderr]   --> src/core/diplomat.rs:11:11
[INFO] [stderr]    |
[INFO] [stderr] 11 | use url::{Host, Url};
[INFO] [stderr]    |           ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:14:31
[INFO] [stderr]    |
[INFO] [stderr] 14 | const SERVICE_DISCOVERY_URI: &'static str = "SERVICE_DISCOVERY_URI";
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:15:32
[INFO] [stderr]    |
[INFO] [stderr] 15 | const DEFAULT_DISCOVERY_HOST: &'static str = "127.0.0.1";
[INFO] [stderr]    |                               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 | const CONSISTENT: &'static str = "Consistent";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/core/diplomat.rs:19:15
[INFO] [stderr]    |
[INFO] [stderr] 19 | const STALE: &'static str = "Stale";
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/core/diplomat.rs:102:9
[INFO] [stderr]     |
[INFO] [stderr] 102 |         result
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/core/diplomat.rs:100:22
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let result = self.health(name, cfg);
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core/diplomat.rs:133:17
[INFO] [stderr]     |
[INFO] [stderr] 133 |                 return self.health_with_cache(name, refresh, cfg);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.health_with_cache(name, refresh, cfg)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/core/diplomat.rs:158:17
[INFO] [stderr]     |
[INFO] [stderr] 158 |                 _ => {  // default choose the first item
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `refresh`
[INFO] [stderr]   --> src/core/diplomat.rs:99:47
[INFO] [stderr]    |
[INFO] [stderr] 99 |     fn health_with_cache(&self, name: String, refresh: bool, cfg: ConsulConfig) -> Vec<ServiceEntry> {
[INFO] [stderr]    |                                               ^^^^^^^ help: consider using `_refresh` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/core/diplomat.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |         let mut discovery_uri: String;
[INFO] [stderr]    |             ----^^^^^^^^^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `cache_ttl`
[INFO] [stderr]   --> src/core/diplomat.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     cache_ttl: u16,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unreachable pattern
[INFO] [stderr]    --> src/core/diplomat.rs:158:17
[INFO] [stderr]     |
[INFO] [stderr] 158 |                 _ => {  // default choose the first item
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unreachable_patterns)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `refresh`
[INFO] [stderr]   --> src/core/diplomat.rs:99:47
[INFO] [stderr]    |
[INFO] [stderr] 99 |     fn health_with_cache(&self, name: String, refresh: bool, cfg: ConsulConfig) -> Vec<ServiceEntry> {
[INFO] [stderr]    |                                               ^^^^^^^ help: consider using `_refresh` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match address {
[INFO] [stderr] 79 | |             Some(x) => { addr = x; }
[INFO] [stderr] 80 | |             _ => {}
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(x) = address { addr = x; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/core/diplomat.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |         let mut discovery_uri: String;
[INFO] [stderr]    |             ----^^^^^^^^^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:121:35
[INFO] [stderr]     |
[INFO] [stderr] 121 |                         } else if self.discarded_addr.len() > 0 {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.discarded_addr.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `cache_ttl`
[INFO] [stderr]   --> src/core/diplomat.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     cache_ttl: u16,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match address {
[INFO] [stderr] 79 | |             Some(x) => { addr = x; }
[INFO] [stderr] 80 | |             _ => {}
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(x) = address { addr = x; }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:121:35
[INFO] [stderr]     |
[INFO] [stderr] 121 |                         } else if self.discarded_addr.len() > 0 {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.discarded_addr.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.38s
[INFO] running `"docker" "inspect" "55e758d2cbcdf73f12f001e6682eb420db9950006e02bace375bbe0354eef461"`
[INFO] running `"docker" "rm" "-f" "55e758d2cbcdf73f12f001e6682eb420db9950006e02bace375bbe0354eef461"`
[INFO] [stdout] 55e758d2cbcdf73f12f001e6682eb420db9950006e02bace375bbe0354eef461