[INFO] crate dire 0.3.1 is already in cache [INFO] extracting crate dire 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/dire/0.3.1 [INFO] extracting crate dire 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dire/0.3.1 [INFO] validating manifest of dire-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dire-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dire-0.3.1 [INFO] finished frobbing dire-0.3.1 [INFO] frobbed toml for dire-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/dire/0.3.1/Cargo.toml [INFO] started frobbing dire-0.3.1 [INFO] finished frobbing dire-0.3.1 [INFO] frobbed toml for dire-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dire/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dire-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dire/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa068d40fdac775f522348e2451dea1f9ff9cd21b1dfc230cf396a5d125380d1 [INFO] running `"docker" "start" "-a" "aa068d40fdac775f522348e2451dea1f9ff9cd21b1dfc230cf396a5d125380d1"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `dirs`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking dire v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/unix.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | let home = env::home_dir().ok_or(DirsError::HomeMissing)?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &HomeMissing => "unable to obtain the home directory", [INFO] [stderr] 44 | | &IoError(ref err) => err.description(), [INFO] [stderr] 45 | | &ParseError(ref why) => why, [INFO] [stderr] 46 | | &PlatformError(ref why) => why, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | HomeMissing => "unable to obtain the home directory", [INFO] [stderr] 44 | IoError(ref err) => err.description(), [INFO] [stderr] 45 | ParseError(ref why) => why, [INFO] [stderr] 46 | PlatformError(ref why) => why, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &IoError(ref why) => Some(why), [INFO] [stderr] 53 | | _ => None [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | IoError(ref why) => Some(why), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match self { [INFO] [stderr] 61 | | &HomeMissing => write!(f, "{}", self.description()), [INFO] [stderr] 62 | | &IoError(ref err) => err.fmt(f), [INFO] [stderr] 63 | | &ParseError(ref why) => write!(f, "{}", why), [INFO] [stderr] 64 | | &PlatformError(ref why) => write!(f, "{}", why), [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | HomeMissing => write!(f, "{}", self.description()), [INFO] [stderr] 62 | IoError(ref err) => err.fmt(f), [INFO] [stderr] 63 | ParseError(ref why) => write!(f, "{}", why), [INFO] [stderr] 64 | PlatformError(ref why) => write!(f, "{}", why), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/unix.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | let home = env::home_dir().ok_or(DirsError::HomeMissing)?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &HomeMissing => "unable to obtain the home directory", [INFO] [stderr] 44 | | &IoError(ref err) => err.description(), [INFO] [stderr] 45 | | &ParseError(ref why) => why, [INFO] [stderr] 46 | | &PlatformError(ref why) => why, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | HomeMissing => "unable to obtain the home directory", [INFO] [stderr] 44 | IoError(ref err) => err.description(), [INFO] [stderr] 45 | ParseError(ref why) => why, [INFO] [stderr] 46 | PlatformError(ref why) => why, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &IoError(ref why) => Some(why), [INFO] [stderr] 53 | | _ => None [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | IoError(ref why) => Some(why), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match self { [INFO] [stderr] 61 | | &HomeMissing => write!(f, "{}", self.description()), [INFO] [stderr] 62 | | &IoError(ref err) => err.fmt(f), [INFO] [stderr] 63 | | &ParseError(ref why) => write!(f, "{}", why), [INFO] [stderr] 64 | | &PlatformError(ref why) => write!(f, "{}", why), [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | HomeMissing => write!(f, "{}", self.description()), [INFO] [stderr] 62 | IoError(ref err) => err.fmt(f), [INFO] [stderr] 63 | ParseError(ref why) => write!(f, "{}", why), [INFO] [stderr] 64 | PlatformError(ref why) => write!(f, "{}", why), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "aa068d40fdac775f522348e2451dea1f9ff9cd21b1dfc230cf396a5d125380d1"` [INFO] running `"docker" "rm" "-f" "aa068d40fdac775f522348e2451dea1f9ff9cd21b1dfc230cf396a5d125380d1"` [INFO] [stdout] aa068d40fdac775f522348e2451dea1f9ff9cd21b1dfc230cf396a5d125380d1