[INFO] crate dircolors-hd 0.2.0 is already in cache [INFO] extracting crate dircolors-hd 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dircolors-hd/0.2.0 [INFO] extracting crate dircolors-hd 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dircolors-hd/0.2.0 [INFO] validating manifest of dircolors-hd-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dircolors-hd-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dircolors-hd-0.2.0 [INFO] finished frobbing dircolors-hd-0.2.0 [INFO] frobbed toml for dircolors-hd-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dircolors-hd/0.2.0/Cargo.toml [INFO] started frobbing dircolors-hd-0.2.0 [INFO] finished frobbing dircolors-hd-0.2.0 [INFO] frobbed toml for dircolors-hd-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dircolors-hd/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dircolors-hd-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dircolors-hd/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1e7a64da6870692fea38f9b0f8d96f6e836c70c936fffcfcf422ff696de115d [INFO] running `"docker" "start" "-a" "b1e7a64da6870692fea38f9b0f8d96f6e836c70c936fffcfcf422ff696de115d"` [INFO] [stderr] Compiling ansi_colours v1.0.1 [INFO] [stderr] Checking dircolors-hd v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/theme.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / if map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 77 | | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 78 | | || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stderr] 79 | | { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | if (map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 77 | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 78 | || map.contains_key(&Yaml::String("font-style".into()))) && map.get(&Yaml::String(key.clone())).is_none() { [INFO] [stderr] 79 | // We can not specialize further [INFO] [stderr] 80 | break; [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/theme.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | / if map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 77 | | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 78 | | || map.contains_key(&Yaml::String("font-style".into())) [INFO] [stderr] 79 | | { [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 76 | if (map.contains_key(&Yaml::String("foreground".into())) [INFO] [stderr] 77 | || map.contains_key(&Yaml::String("background".into())) [INFO] [stderr] 78 | || map.contains_key(&Yaml::String("font-style".into()))) && map.get(&Yaml::String(key.clone())).is_none() { [INFO] [stderr] 79 | // We can not specialize further [INFO] [stderr] 80 | break; [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/filetypes.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | fn get_mapping(value: &Yaml, category: &Category) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 58 | let mut child_category = category.clone(); [INFO] [stderr] | ---------------- help: change `category.clone()` to: `category.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/filetypes.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | if !result.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/theme.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn get_style(&self, category: &Category) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/filetypes.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | fn get_mapping(value: &Yaml, category: &Category) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 58 | let mut child_category = category.clone(); [INFO] [stderr] | ---------------- help: change `category.clone()` to: `category.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/filetypes.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | if !result.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/theme.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn get_style(&self, category: &Category) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.27s [INFO] running `"docker" "inspect" "b1e7a64da6870692fea38f9b0f8d96f6e836c70c936fffcfcf422ff696de115d"` [INFO] running `"docker" "rm" "-f" "b1e7a64da6870692fea38f9b0f8d96f6e836c70c936fffcfcf422ff696de115d"` [INFO] [stdout] b1e7a64da6870692fea38f9b0f8d96f6e836c70c936fffcfcf422ff696de115d