[INFO] crate dir-signature 0.2.9 is already in cache [INFO] extracting crate dir-signature 0.2.9 into work/ex/clippy-test-run/sources/stable/reg/dir-signature/0.2.9 [INFO] extracting crate dir-signature 0.2.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dir-signature/0.2.9 [INFO] validating manifest of dir-signature-0.2.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dir-signature-0.2.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dir-signature-0.2.9 [INFO] finished frobbing dir-signature-0.2.9 [INFO] frobbed toml for dir-signature-0.2.9 written to work/ex/clippy-test-run/sources/stable/reg/dir-signature/0.2.9/Cargo.toml [INFO] started frobbing dir-signature-0.2.9 [INFO] finished frobbing dir-signature-0.2.9 [INFO] frobbed toml for dir-signature-0.2.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dir-signature/0.2.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dir-signature-0.2.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dir-signature/0.2.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f4d86a2869107fe3be9f5197add522683727a59718d35bd12cbfc5f1925b46d [INFO] running `"docker" "start" "-a" "7f4d86a2869107fe3be9f5197add522683727a59718d35bd12cbfc5f1925b46d"` [INFO] [stderr] Checking openat v0.1.16 [INFO] [stderr] Checking digest-writer v0.3.1 [INFO] [stderr] Checking dir-signature v0.2.9 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/writer.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / write!(&mut self.file, " {} s {}\n", [INFO] [stderr] 78 | | Name(&Path::new(entry.file_name())), [INFO] [stderr] 79 | | Name(&dest), [INFO] [stderr] 80 | | ).map_err(EWrite)?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/writer.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | write!(&mut self.file.file, "{:x}\n", hash).map_err(EFile) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/writer.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/writer.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/progress.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / write!(&mut self.progress_dest, [INFO] [stderr] 81 | | "Done {:.8x}. Indexed {} dirs, \ [INFO] [stderr] 82 | | {} files, {} symlinks in {:.3} sec.\n", [INFO] [stderr] 83 | | hash, self.dirs, self.files, self.symlinks, [INFO] [stderr] 84 | | duration_float(Instant::now().duration_since(self.started)), [INFO] [stderr] 85 | | ).ok(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:369:13 [INFO] [stderr] | [INFO] [stderr] 369 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:524:21 [INFO] [stderr] | [INFO] [stderr] 524 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:527:21 [INFO] [stderr] | [INFO] [stderr] 527 | hashes: hashes }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hashes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:585:13 [INFO] [stderr] | [INFO] [stderr] 585 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:640:13 [INFO] [stderr] | [INFO] [stderr] 640 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:641:13 [INFO] [stderr] | [INFO] [stderr] 641 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/emitter.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / write!(self.out, " {} s {}\n", [INFO] [stderr] 112 | | Name(&Path::new(name)), [INFO] [stderr] 113 | | Name(dest), [INFO] [stderr] 114 | | )?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/merge.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | parsers: parsers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parsers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/threaded_writer.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/threaded_writer.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/threaded_writer.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / write!(&mut self.file, " {} {} {}{}\n", [INFO] [stderr] 84 | | Name(&entry.file_name), [INFO] [stderr] 85 | | if entry.exe { "x" } else { "f" }, [INFO] [stderr] 86 | | entry.size, [INFO] [stderr] 87 | | entry.hashes, // includes space [INFO] [stderr] 88 | | ).map_err(EWrite)?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/threaded_writer.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / write!(&mut self.file, " {} s {}\n", [INFO] [stderr] 93 | | Name(&Path::new(entry.file_name())), [INFO] [stderr] 94 | | Name(&dest), [INFO] [stderr] 95 | | ).map_err(EWrite)?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/threaded_writer.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | write!(&mut self.file.file, "{:x}\n", hash).map_err(EFile) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/writer.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / write!(&mut self.file, " {} s {}\n", [INFO] [stderr] 78 | | Name(&Path::new(entry.file_name())), [INFO] [stderr] 79 | | Name(&dest), [INFO] [stderr] 80 | | ).map_err(EWrite)?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/writer.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | write!(&mut self.file.file, "{:x}\n", hash).map_err(EFile) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/writer.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/writer.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/progress.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / write!(&mut self.progress_dest, [INFO] [stderr] 81 | | "Done {:.8x}. Indexed {} dirs, \ [INFO] [stderr] 82 | | {} files, {} symlinks in {:.3} sec.\n", [INFO] [stderr] 83 | | hash, self.dirs, self.files, self.symlinks, [INFO] [stderr] 84 | | duration_float(Instant::now().duration_since(self.started)), [INFO] [stderr] 85 | | ).ok(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:369:13 [INFO] [stderr] | [INFO] [stderr] 369 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:524:21 [INFO] [stderr] | [INFO] [stderr] 524 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:527:21 [INFO] [stderr] | [INFO] [stderr] 527 | hashes: hashes }, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hashes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:585:13 [INFO] [stderr] | [INFO] [stderr] 585 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:640:13 [INFO] [stderr] | [INFO] [stderr] 640 | hash_type: hash_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/parser.rs:641:13 [INFO] [stderr] | [INFO] [stderr] 641 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/emitter.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / write!(self.out, " {} s {}\n", [INFO] [stderr] 112 | | Name(&Path::new(name)), [INFO] [stderr] 113 | | Name(dest), [INFO] [stderr] 114 | | )?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/merge.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | parsers: parsers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `parsers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/threaded_writer.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | block_size: block_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1/threaded_writer.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/threaded_writer.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / write!(&mut self.file, " {} {} {}{}\n", [INFO] [stderr] 84 | | Name(&entry.file_name), [INFO] [stderr] 85 | | if entry.exe { "x" } else { "f" }, [INFO] [stderr] 86 | | entry.size, [INFO] [stderr] 87 | | entry.hashes, // includes space [INFO] [stderr] 88 | | ).map_err(EWrite)?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/threaded_writer.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | / write!(&mut self.file, " {} s {}\n", [INFO] [stderr] 93 | | Name(&Path::new(entry.file_name())), [INFO] [stderr] 94 | | Name(&dest), [INFO] [stderr] 95 | | ).map_err(EWrite)?; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/v1/threaded_writer.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | write!(&mut self.file.file, "{:x}\n", hash).map_err(EFile) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/v1/writer.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | pub(crate) const MAGIC: &'static str = "DIRSIGNATURE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/v1/writer.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | pub(crate) const VERSION: &'static str = "v1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/scan.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(root); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(root)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/parser.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | return Some(&self.data[off..end]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.data[off..end])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/parser.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/threaded_writer.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/v1/writer.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | pub(crate) const MAGIC: &'static str = "DIRSIGNATURE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/v1/writer.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | pub(crate) const VERSION: &'static str = "v1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/scan.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(root); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(root)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/parser.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | return Some(&self.data[off..end]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.data[off..end])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/parser.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/v1/threaded_writer.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return Ok(hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/read.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | const DATA: &'static [u8] = b"\ [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/v1/progress.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | d.as_secs() as f64 + d.subsec_nanos() as f64 / 1_000_000_000. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v1/scan.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | if root.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `root.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v1/scan.rs:39:11 [INFO] [stderr] | [INFO] [stderr] 39 | while queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/v1/scan.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | .unwrap_or(path.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| path.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/v1/parser.rs:206:40 [INFO] [stderr] | [INFO] [stderr] 206 | match path.cmp(other_parent.as_ref()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `other_parent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: item `v1::parser::Hashes` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/v1/parser.rs:364:1 [INFO] [stderr] | [INFO] [stderr] 364 | / impl Hashes { [INFO] [stderr] 365 | | fn new(data: Vec, hash_type: HashType, block_size: u64) -> Hashes { [INFO] [stderr] 366 | | Hashes { [INFO] [stderr] 367 | | data: data, [INFO] [stderr] ... | [INFO] [stderr] 467 | | } [INFO] [stderr] 468 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | / pub fn iter<'a>(&'a self) -> HashesIter<'a> { [INFO] [stderr] 402 | | HashesIter(self.data.chunks(self.hash_type.output_bytes())) [INFO] [stderr] 403 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | / pub(crate) fn hex_iter<'a>(&'a self) -> HexHashesIter<'a> { [INFO] [stderr] 407 | | HexHashesIter(self.data.chunks(self.hash_type.output_bytes())) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/v1/parser.rs:673:29 [INFO] [stderr] | [INFO] [stderr] 673 | format!("Found extra lines after the footer")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Found extra lines after the footer".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/v1/parser.rs:742:13 [INFO] [stderr] | [INFO] [stderr] 742 | format!("Every line must end with a newline"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Every line must end with a newline".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:759:1 [INFO] [stderr] | [INFO] [stderr] 759 | / fn parse_path_buf<'a>(data: &'a [u8]) [INFO] [stderr] 760 | | -> Result<(PathBuf, &'a [u8]), ParseRowError> [INFO] [stderr] 761 | | { [INFO] [stderr] 762 | | let (path, tail) = parse_os_str(data)?; [INFO] [stderr] 763 | | let unescaped_path = unescape_hex(path); [INFO] [stderr] 764 | | Ok((PathBuf::from(&unescaped_path), tail)) [INFO] [stderr] 765 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:774:1 [INFO] [stderr] | [INFO] [stderr] 774 | / fn parse_u64<'a>(data: &'a [u8]) [INFO] [stderr] 775 | | -> Result<(u64, &'a [u8]), ParseRowError> [INFO] [stderr] 776 | | { [INFO] [stderr] 777 | | let (field, tail) = parse_field(data)?; [INFO] [stderr] ... | [INFO] [stderr] 780 | | Ok((v, tail)) [INFO] [stderr] 781 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:783:1 [INFO] [stderr] | [INFO] [stderr] 783 | / fn parse_field<'a>(data: &'a [u8]) [INFO] [stderr] 784 | | -> Result<(&'a [u8], &'a [u8]), ParseRowError> [INFO] [stderr] 785 | | { [INFO] [stderr] 786 | | [INFO] [stderr] ... | [INFO] [stderr] 794 | | Ok((field, tail)) [INFO] [stderr] 795 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/v1/parser.rs:789:13 [INFO] [stderr] | [INFO] [stderr] 789 | format!("Row has multiple spaces"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Row has multiple spaces".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v1::merge::FileMergeBuilder` [INFO] [stderr] --> src/v1/merge.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> FileMergeBuilder { [INFO] [stderr] 55 | | FileMergeBuilder { [INFO] [stderr] 56 | | paths: vec!(), [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/merge.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn iter<'a>(&'a mut self) -> MergedEntriesIterator<'a, K, R> { [INFO] [stderr] 122 | | MergedEntriesIterator::new(self) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/v1/merge.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | let ref mut elem = self.iterators[ix]; [INFO] [stderr] | ----^^^^^^^^^^^^---------------------- help: try: `let elem = &mut self.iterators[ix];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/v1/merge.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | let ref mut iterator = elem.1; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^---------- help: try: `let iterator = &mut elem.1;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ScannerConfig` [INFO] [stderr] --> src/config.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> ScannerConfig { [INFO] [stderr] 12 | | ScannerConfig { [INFO] [stderr] 13 | | threads: 0, [INFO] [stderr] 14 | | queue_size: None, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | impl Default for ScannerConfig { [INFO] [stderr] 7 | fn default() -> Self { [INFO] [stderr] 8 | Self::new() [INFO] [stderr] 9 | } [INFO] [stderr] 10 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/read.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | f.read(&mut signature)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dir-signature`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/v1/progress.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | d.as_secs() as f64 + d.subsec_nanos() as f64 / 1_000_000_000. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v1/scan.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | if root.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `root.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/v1/scan.rs:39:11 [INFO] [stderr] | [INFO] [stderr] 39 | while queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/v1/scan.rs:59:30 [INFO] [stderr] | [INFO] [stderr] 59 | .unwrap_or(path.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| path.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/v1/parser.rs:206:40 [INFO] [stderr] | [INFO] [stderr] 206 | match path.cmp(other_parent.as_ref()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `other_parent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: item `v1::parser::Hashes` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/v1/parser.rs:364:1 [INFO] [stderr] | [INFO] [stderr] 364 | / impl Hashes { [INFO] [stderr] 365 | | fn new(data: Vec, hash_type: HashType, block_size: u64) -> Hashes { [INFO] [stderr] 366 | | Hashes { [INFO] [stderr] 367 | | data: data, [INFO] [stderr] ... | [INFO] [stderr] 467 | | } [INFO] [stderr] 468 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:401:5 [INFO] [stderr] | [INFO] [stderr] 401 | / pub fn iter<'a>(&'a self) -> HashesIter<'a> { [INFO] [stderr] 402 | | HashesIter(self.data.chunks(self.hash_type.output_bytes())) [INFO] [stderr] 403 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | / pub(crate) fn hex_iter<'a>(&'a self) -> HexHashesIter<'a> { [INFO] [stderr] 407 | | HexHashesIter(self.data.chunks(self.hash_type.output_bytes())) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/v1/parser.rs:673:29 [INFO] [stderr] | [INFO] [stderr] 673 | format!("Found extra lines after the footer")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Found extra lines after the footer".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/v1/parser.rs:742:13 [INFO] [stderr] | [INFO] [stderr] 742 | format!("Every line must end with a newline"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Every line must end with a newline".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:759:1 [INFO] [stderr] | [INFO] [stderr] 759 | / fn parse_path_buf<'a>(data: &'a [u8]) [INFO] [stderr] 760 | | -> Result<(PathBuf, &'a [u8]), ParseRowError> [INFO] [stderr] 761 | | { [INFO] [stderr] 762 | | let (path, tail) = parse_os_str(data)?; [INFO] [stderr] 763 | | let unescaped_path = unescape_hex(path); [INFO] [stderr] 764 | | Ok((PathBuf::from(&unescaped_path), tail)) [INFO] [stderr] 765 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:774:1 [INFO] [stderr] | [INFO] [stderr] 774 | / fn parse_u64<'a>(data: &'a [u8]) [INFO] [stderr] 775 | | -> Result<(u64, &'a [u8]), ParseRowError> [INFO] [stderr] 776 | | { [INFO] [stderr] 777 | | let (field, tail) = parse_field(data)?; [INFO] [stderr] ... | [INFO] [stderr] 780 | | Ok((v, tail)) [INFO] [stderr] 781 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/parser.rs:783:1 [INFO] [stderr] | [INFO] [stderr] 783 | / fn parse_field<'a>(data: &'a [u8]) [INFO] [stderr] 784 | | -> Result<(&'a [u8], &'a [u8]), ParseRowError> [INFO] [stderr] 785 | | { [INFO] [stderr] 786 | | [INFO] [stderr] ... | [INFO] [stderr] 794 | | Ok((field, tail)) [INFO] [stderr] 795 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/v1/parser.rs:789:13 [INFO] [stderr] | [INFO] [stderr] 789 | format!("Row has multiple spaces"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Row has multiple spaces".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `v1::merge::FileMergeBuilder` [INFO] [stderr] --> src/v1/merge.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> FileMergeBuilder { [INFO] [stderr] 55 | | FileMergeBuilder { [INFO] [stderr] 56 | | paths: vec!(), [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/v1/merge.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn iter<'a>(&'a mut self) -> MergedEntriesIterator<'a, K, R> { [INFO] [stderr] 122 | | MergedEntriesIterator::new(self) [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/v1/merge.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | let ref mut elem = self.iterators[ix]; [INFO] [stderr] | ----^^^^^^^^^^^^---------------------- help: try: `let elem = &mut self.iterators[ix];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/v1/merge.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | let ref mut iterator = elem.1; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^---------- help: try: `let iterator = &mut elem.1;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ScannerConfig` [INFO] [stderr] --> src/config.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> ScannerConfig { [INFO] [stderr] 12 | | ScannerConfig { [INFO] [stderr] 13 | | threads: 0, [INFO] [stderr] 14 | | queue_size: None, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | impl Default for ScannerConfig { [INFO] [stderr] 7 | fn default() -> Self { [INFO] [stderr] 8 | Self::new() [INFO] [stderr] 9 | } [INFO] [stderr] 10 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/read.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | f.read(&mut signature)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dir-signature`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7f4d86a2869107fe3be9f5197add522683727a59718d35bd12cbfc5f1925b46d"` [INFO] running `"docker" "rm" "-f" "7f4d86a2869107fe3be9f5197add522683727a59718d35bd12cbfc5f1925b46d"` [INFO] [stdout] 7f4d86a2869107fe3be9f5197add522683727a59718d35bd12cbfc5f1925b46d