[INFO] crate dipstick 0.6.11 is already in cache [INFO] extracting crate dipstick 0.6.11 into work/ex/clippy-test-run/sources/stable/reg/dipstick/0.6.11 [INFO] extracting crate dipstick 0.6.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dipstick/0.6.11 [INFO] validating manifest of dipstick-0.6.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dipstick-0.6.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dipstick-0.6.11 [INFO] finished frobbing dipstick-0.6.11 [INFO] frobbed toml for dipstick-0.6.11 written to work/ex/clippy-test-run/sources/stable/reg/dipstick/0.6.11/Cargo.toml [INFO] started frobbing dipstick-0.6.11 [INFO] finished frobbing dipstick-0.6.11 [INFO] frobbed toml for dipstick-0.6.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dipstick/0.6.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dipstick-0.6.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dipstick/0.6.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1555e38d0cf82657ab6b1ddb35852f649f972ce746041874622bd8fd5351852 [INFO] running `"docker" "start" "-a" "c1555e38d0cf82657ab6b1ddb35852f649f972ce746041874622bd8fd5351852"` [INFO] [stderr] Compiling dipstick v0.6.11 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | let seed = 5573589319906701683_u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `5_573_589_319_906_701_683_u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | let seed = seed.wrapping_mul(6364136223846793005) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | .wrapping_add(1442695040888963407) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | seed.wrapping_mul(6364136223846793005) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | .wrapping_add(1442695040888963407) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | .wrapping_mul(6364136223846793005) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | .wrapping_add(1442695040888963407); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | duration.as_secs() * 1000000 + (duration.subsec_nanos() / 1000) as Value [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:40:64 [INFO] [stderr] | [INFO] [stderr] 40 | duration.as_secs() * 1000 + (duration.subsec_nanos() / 1000000) as Value [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/scores.rs:61:40 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn update(&self, value: Value) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/namespace.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | const DEFAULT_SEPARATOR: &'static str = "."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | let seed = 5573589319906701683_u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `5_573_589_319_906_701_683_u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | let seed = seed.wrapping_mul(6364136223846793005) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | .wrapping_add(1442695040888963407) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | seed.wrapping_mul(6364136223846793005) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | .wrapping_add(1442695040888963407) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | .wrapping_mul(6364136223846793005) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg32.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | .wrapping_add(1442695040888963407); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_442_695_040_888_963_407` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | duration.as_secs() * 1000000 + (duration.subsec_nanos() / 1000) as Value [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core.rs:40:64 [INFO] [stderr] | [INFO] [stderr] 40 | duration.as_secs() * 1000 + (duration.subsec_nanos() / 1000000) as Value [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/scores.rs:61:40 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn update(&self, value: Value) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/namespace.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | const DEFAULT_SEPARATOR: &'static str = "."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pcg32.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | ((1.0 - float_rate) * ::std::u32::MAX as f64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lru_cache.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / if self.table.contains_key(&key) { [INFO] [stderr] 61 | | self.access(&key); [INFO] [stderr] 62 | | let entry = &mut self.entries[self.first.unwrap()]; [INFO] [stderr] 63 | | let old = entry.value.take(); [INFO] [stderr] ... | [INFO] [stderr] 84 | | None [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ help: consider using: `self.table.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lru_cache.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | self.first.map(|e| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 71 | || let prev = Some(idx); [INFO] [stderr] 72 | || self.entries[e].prev = prev; [INFO] [stderr] 73 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(e) = self.first { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lru_cache.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | let i = *self.table.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.table[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lru_cache.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let entry = self.entries.get_mut(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.entries[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | duration.as_secs() * 1000000 + (duration.subsec_nanos() / 1000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/core.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | duration.as_secs() * 1000000 + (duration.subsec_nanos() / 1000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:40:37 [INFO] [stderr] | [INFO] [stderr] 40 | duration.as_secs() * 1000 + (duration.subsec_nanos() / 1000000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/core.rs:40:37 [INFO] [stderr] | [INFO] [stderr] 40 | duration.as_secs() * 1000 + (duration.subsec_nanos() / 1000000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aggregate.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | let duration_seconds = (duration.subsec_nanos() / 1_000_000_000) as f64 + duration.as_secs() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos() / 1_000_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/pcg32.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | ((1.0 - float_rate) * ::std::u32::MAX as f64) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lru_cache.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / if self.table.contains_key(&key) { [INFO] [stderr] 61 | | self.access(&key); [INFO] [stderr] 62 | | let entry = &mut self.entries[self.first.unwrap()]; [INFO] [stderr] 63 | | let old = entry.value.take(); [INFO] [stderr] ... | [INFO] [stderr] 84 | | None [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ help: consider using: `self.table.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lru_cache.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | self.first.map(|e| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 71 | || let prev = Some(idx); [INFO] [stderr] 72 | || self.entries[e].prev = prev; [INFO] [stderr] 73 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(e) = self.first { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lru_cache.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | let i = *self.table.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.table[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lru_cache.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | let entry = self.entries.get_mut(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.entries[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | duration.as_secs() * 1000000 + (duration.subsec_nanos() / 1000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/core.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | duration.as_secs() * 1000000 + (duration.subsec_nanos() / 1000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core.rs:40:37 [INFO] [stderr] | [INFO] [stderr] 40 | duration.as_secs() * 1000 + (duration.subsec_nanos() / 1000000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1000000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/core.rs:40:37 [INFO] [stderr] | [INFO] [stderr] 40 | duration.as_secs() * 1000 + (duration.subsec_nanos() / 1000000) as Value [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/graphite.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | scale = scale * upsample; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scale *= upsample` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aggregate.rs:93:32 [INFO] [stderr] | [INFO] [stderr] 93 | let duration_seconds = (duration.subsec_nanos() / 1_000_000_000) as f64 + duration.as_secs() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos() / 1_000_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/graphite.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | scale = scale * upsample; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scale *= upsample` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/multi_outs.rs:29:56 [INFO] [stderr] | [INFO] [stderr] 29 | same_type_metrics.timer("timer_a").interval_us(2000000); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/static_metrics.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | metric::TIMER_B.interval_us(654654); [INFO] [stderr] | ^^^^^^ help: consider: `654_654` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/scoped_print.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let ref mut scope = metrics.open_scope(true); [INFO] [stderr] | ----^^^^^^^^^^^^^---------------------------- help: try: `let scope = &mut metrics.open_scope(true);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/graphite.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | metrics.timer("timer_a").interval_us(2000000); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/instruments.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/custom_publish.rs:50:27 [INFO] [stderr] | [INFO] [stderr] 50 | timer.interval_us(654654); [INFO] [stderr] | ^^^^^^ help: consider: `654_654` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> examples/async_print.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/macros_out.rs:28:48 [INFO] [stderr] | [INFO] [stderr] 28 | SAME_TYPE.timer("timer_a").interval_us(2000000); [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.76s [INFO] running `"docker" "inspect" "c1555e38d0cf82657ab6b1ddb35852f649f972ce746041874622bd8fd5351852"` [INFO] running `"docker" "rm" "-f" "c1555e38d0cf82657ab6b1ddb35852f649f972ce746041874622bd8fd5351852"` [INFO] [stdout] c1555e38d0cf82657ab6b1ddb35852f649f972ce746041874622bd8fd5351852