[INFO] crate dinghy-test 0.3.5 is already in cache [INFO] extracting crate dinghy-test 0.3.5 into work/ex/clippy-test-run/sources/stable/reg/dinghy-test/0.3.5 [INFO] extracting crate dinghy-test 0.3.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dinghy-test/0.3.5 [INFO] validating manifest of dinghy-test-0.3.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dinghy-test-0.3.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dinghy-test-0.3.5 [INFO] finished frobbing dinghy-test-0.3.5 [INFO] frobbed toml for dinghy-test-0.3.5 written to work/ex/clippy-test-run/sources/stable/reg/dinghy-test/0.3.5/Cargo.toml [INFO] started frobbing dinghy-test-0.3.5 [INFO] finished frobbing dinghy-test-0.3.5 [INFO] frobbed toml for dinghy-test-0.3.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dinghy-test/0.3.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dinghy-test-0.3.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dinghy-test/0.3.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e27e274598e77e1dceef80bf72b79497eaa8b87c4af3c9e3739f31d35aa5af5f [INFO] running `"docker" "start" "-a" "e27e274598e77e1dceef80bf72b79497eaa8b87c4af3c9e3739f31d35aa5af5f"` [INFO] [stderr] Checking dinghy-test v0.3.5 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | .expect(&format!("Current exe path is invalid {}", current_exe.display())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Current exe path is invalid {}", current_exe.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | .expect(&format!("Couldn't find test data {}", test_data_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Couldn't find test data {}", test_data_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let Err(_) = test_data_cfg { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 50 | | return None; [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________- help: try this: `if test_data_cfg.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | .map(|line| line.split(":")) [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:13:14 [INFO] [stderr] | [INFO] [stderr] 13 | .expect(&format!("Current exe path is invalid {}", current_exe.display())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Current exe path is invalid {}", current_exe.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | .expect(&format!("Couldn't find test data {}", test_data_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Couldn't find test data {}", test_data_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let Err(_) = test_data_cfg { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 50 | | return None; [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________- help: try this: `if test_data_cfg.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | .map(|line| line.split(":")) [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "e27e274598e77e1dceef80bf72b79497eaa8b87c4af3c9e3739f31d35aa5af5f"` [INFO] running `"docker" "rm" "-f" "e27e274598e77e1dceef80bf72b79497eaa8b87c4af3c9e3739f31d35aa5af5f"` [INFO] [stdout] e27e274598e77e1dceef80bf72b79497eaa8b87c4af3c9e3739f31d35aa5af5f