[INFO] crate dimacs 0.2.0 is already in cache [INFO] extracting crate dimacs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dimacs/0.2.0 [INFO] extracting crate dimacs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dimacs/0.2.0 [INFO] validating manifest of dimacs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dimacs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dimacs-0.2.0 [INFO] finished frobbing dimacs-0.2.0 [INFO] frobbed toml for dimacs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dimacs/0.2.0/Cargo.toml [INFO] started frobbing dimacs-0.2.0 [INFO] finished frobbing dimacs-0.2.0 [INFO] frobbed toml for dimacs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dimacs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dimacs-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dimacs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b21503e33e4d585118ec650b2b87203d8278b0983960682a61c13afbc0517dcc [INFO] running `"docker" "start" "-a" "b21503e33e4d585118ec650b2b87203d8278b0983960682a61c13afbc0517dcc"` [INFO] [stderr] Checking dimacs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | Instance::Cnf{num_vars: num_vars, clauses: clauses.into_boxed_slice()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_vars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | Instance::Sat{num_vars: num_vars, extensions: extensions, formula: formula} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:174:37 [INFO] [stderr] | [INFO] [stderr] 174 | Instance::Sat{num_vars: num_vars, extensions: extensions, formula: formula} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:174:61 [INFO] [stderr] | [INFO] [stderr] 174 | Instance::Sat{num_vars: num_vars, extensions: extensions, formula: formula} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:16:8 [INFO] [stderr] | [INFO] [stderr] 16 | Loc{ line: line, col: col } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | Loc{ line: line, col: col } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | ParseError { loc: loc, kind: kind } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | ParseError { loc: loc, kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:14:4 [INFO] [stderr] | [INFO] [stderr] 14 | loc : loc, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | kind: kind [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | input : input, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | Instance::Cnf{num_vars: num_vars, clauses: clauses.into_boxed_slice()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_vars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | Instance::Sat{num_vars: num_vars, extensions: extensions, formula: formula} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `num_vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:174:37 [INFO] [stderr] | [INFO] [stderr] 174 | Instance::Sat{num_vars: num_vars, extensions: extensions, formula: formula} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/items.rs:174:61 [INFO] [stderr] | [INFO] [stderr] 174 | Instance::Sat{num_vars: num_vars, extensions: extensions, formula: formula} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formula` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:16:8 [INFO] [stderr] | [INFO] [stderr] 16 | Loc{ line: line, col: col } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | Loc{ line: line, col: col } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | ParseError { loc: loc, kind: kind } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | ParseError { loc: loc, kind: kind } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:14:4 [INFO] [stderr] | [INFO] [stderr] 14 | loc : loc, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | kind: kind [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | input : input, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/items.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | const NONE = 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/items.rs:184:22 [INFO] [stderr] | [INFO] [stderr] 184 | const XOR = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/items.rs:186:22 [INFO] [stderr] | [INFO] [stderr] 186 | const EQ = 0b00000010 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/items.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | const NONE = 0b00000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/items.rs:184:22 [INFO] [stderr] | [INFO] [stderr] 184 | const XOR = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/items.rs:186:22 [INFO] [stderr] | [INFO] [stderr] 186 | const EQ = 0b00000010 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/items.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | match self.0 >= 0 { [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | true => Sign::Pos, [INFO] [stderr] 38 | | _ => Sign::Neg [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.0 >= 0 { Sign::Pos } else { Sign::Neg }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: item `items::Clause` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/items.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / impl Clause { [INFO] [stderr] 50 | | /// Creates a new clause from a vector of literals. [INFO] [stderr] 51 | | pub fn from_vec(lits: Vec) -> Clause { [INFO] [stderr] 52 | | Clause{ [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | let mut val = self.peek.to_digit(10) [INFO] [stderr] | _______________________^ [INFO] [stderr] 211 | | .expect("expected a digit to base 10: (0...9)") as u64; [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 210 | let mut val = u64::from(self.peek.to_digit(10) [INFO] [stderr] 211 | .expect("expected a digit to base 10: (0...9)")); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:214:11 [INFO] [stderr] | [INFO] [stderr] 214 | val += parsed as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(parsed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(Ok(Token::new(self.peek_loc(), TokenKind::EndOfFile))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(Token::new(self.peek_loc(), TokenKind::EndOfFile)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:141:2 [INFO] [stderr] | [INFO] [stderr] 141 | fn parse_sat_extensions<'a>(&'a mut self) -> Result { [INFO] [stderr] | _____^ [INFO] [stderr] 142 | | use self::TokenKind::{Ident}; [INFO] [stderr] 143 | | use self::Ident::{Sat, Sate, Satx, Satex}; [INFO] [stderr] 144 | | use self::ErrorKind::*; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/items.rs:36:3 [INFO] [stderr] | [INFO] [stderr] 36 | match self.0 >= 0 { [INFO] [stderr] | _________^ [INFO] [stderr] 37 | | true => Sign::Pos, [INFO] [stderr] 38 | | _ => Sign::Neg [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.0 >= 0 { Sign::Pos } else { Sign::Neg }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: item `items::Clause` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/items.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / impl Clause { [INFO] [stderr] 50 | | /// Creates a new clause from a vector of literals. [INFO] [stderr] 51 | | pub fn from_vec(lits: Vec) -> Clause { [INFO] [stderr] 52 | | Clause{ [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | let mut val = self.peek.to_digit(10) [INFO] [stderr] | _______________________^ [INFO] [stderr] 211 | | .expect("expected a digit to base 10: (0...9)") as u64; [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 210 | let mut val = u64::from(self.peek.to_digit(10) [INFO] [stderr] 211 | .expect("expected a digit to base 10: (0...9)")); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:214:11 [INFO] [stderr] | [INFO] [stderr] 214 | val += parsed as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(parsed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lexer.rs:308:2 [INFO] [stderr] | [INFO] [stderr] 308 | fn simple_cnf() { [INFO] [stderr] | _____^ [INFO] [stderr] 309 | | let sample = r" [INFO] [stderr] 310 | | c Sample DIMACS .cnf file [INFO] [stderr] 311 | | c holding some information [INFO] [stderr] ... | [INFO] [stderr] 354 | | assert_eq!(lexer.next(), None); [INFO] [stderr] 355 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lexer.rs:358:2 [INFO] [stderr] | [INFO] [stderr] 358 | fn simple_sat() { [INFO] [stderr] | _____^ [INFO] [stderr] 359 | | let sample = r" [INFO] [stderr] 360 | | c Sample DIMACS .sat file [INFO] [stderr] 361 | | p sat 42 1337 [INFO] [stderr] ... | [INFO] [stderr] 398 | | assert_eq!(lexer.next(), None); [INFO] [stderr] 399 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parser.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(Ok(Token::new(self.peek_loc(), TokenKind::EndOfFile))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(Token::new(self.peek_loc(), TokenKind::EndOfFile)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:141:2 [INFO] [stderr] | [INFO] [stderr] 141 | fn parse_sat_extensions<'a>(&'a mut self) -> Result { [INFO] [stderr] | _____^ [INFO] [stderr] 142 | | use self::TokenKind::{Ident}; [INFO] [stderr] 143 | | use self::Ident::{Sat, Sate, Satx, Satex}; [INFO] [stderr] 144 | | use self::ErrorKind::*; [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.12s [INFO] running `"docker" "inspect" "b21503e33e4d585118ec650b2b87203d8278b0983960682a61c13afbc0517dcc"` [INFO] running `"docker" "rm" "-f" "b21503e33e4d585118ec650b2b87203d8278b0983960682a61c13afbc0517dcc"` [INFO] [stdout] b21503e33e4d585118ec650b2b87203d8278b0983960682a61c13afbc0517dcc