[INFO] crate dilithium 0.2.0-alpha.3 is already in cache [INFO] extracting crate dilithium 0.2.0-alpha.3 into work/ex/clippy-test-run/sources/stable/reg/dilithium/0.2.0-alpha.3 [INFO] extracting crate dilithium 0.2.0-alpha.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dilithium/0.2.0-alpha.3 [INFO] validating manifest of dilithium-0.2.0-alpha.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dilithium-0.2.0-alpha.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dilithium-0.2.0-alpha.3 [INFO] finished frobbing dilithium-0.2.0-alpha.3 [INFO] frobbed toml for dilithium-0.2.0-alpha.3 written to work/ex/clippy-test-run/sources/stable/reg/dilithium/0.2.0-alpha.3/Cargo.toml [INFO] started frobbing dilithium-0.2.0-alpha.3 [INFO] finished frobbing dilithium-0.2.0-alpha.3 [INFO] frobbed toml for dilithium-0.2.0-alpha.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dilithium/0.2.0-alpha.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dilithium-0.2.0-alpha.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dilithium/0.2.0-alpha.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 62cd16f23317ae6ec6aba9bf83004f4e5a7e72a6bf07837c3d5f27184a67e561 [INFO] running `"docker" "start" "-a" "62cd16f23317ae6ec6aba9bf83004f4e5a7e72a6bf07837c3d5f27184a67e561"` [INFO] [stderr] Checking dilithium v0.2.0-alpha.3 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign.rs:138:14 [INFO] [stderr] | [INFO] [stderr] 138 | let (mut h, mut wcs2, mut wcs20, mut ct0, mut tmp) = [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | let mut c = [0; N]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | let r = packing::sign::unpack(sig, &mut z, &mut h, &mut c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign.rs:138:14 [INFO] [stderr] | [INFO] [stderr] 138 | let (mut h, mut wcs2, mut wcs20, mut ct0, mut tmp) = [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sign.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | let mut c = [0; N]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sign.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | let r = packing::sign::unpack(sig, &mut z, &mut h, &mut c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rounding.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/params.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rounding.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rounding.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/params.rs:1:45 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rounding.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | #[cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `p`. [INFO] [stderr] --> src/ntt.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | for j in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for in p.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/poly.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 15 | for in a.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/poly.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in a.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/poly.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in a.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:178:33 [INFO] [stderr] | [INFO] [stderr] 178 | t[0] = (Q + ETA - a[8*i+0]) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:187:15 [INFO] [stderr] | [INFO] [stderr] 187 | r[3*i+0] = t[0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:188:15 [INFO] [stderr] | [INFO] [stderr] 188 | r[3*i+0] |= t[1] << 3; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:189:15 [INFO] [stderr] | [INFO] [stderr] 189 | r[3*i+0] |= t[2] << 6; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:201:33 [INFO] [stderr] | [INFO] [stderr] 201 | t[0] = (Q + ETA - a[2*i+0]) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | r[8*i+0] = u32::from(a[3*i+0]) & 0x07; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:212:15 [INFO] [stderr] | [INFO] [stderr] 212 | r[8*i+0] = u32::from(a[3*i+0]) & 0x07; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:213:37 [INFO] [stderr] | [INFO] [stderr] 213 | r[8*i+1] = (u32::from(a[3*i+0]) >> 3) & 0x07; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:214:37 [INFO] [stderr] | [INFO] [stderr] 214 | r[8*i+2] = (u32::from(a[3*i+0]) >> 6) | ((u32::from(a[3*i+1]) & 0x01) << 2); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:221:36 [INFO] [stderr] | [INFO] [stderr] 221 | r[8*i+0] = Q + ETA - r[8*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:221:15 [INFO] [stderr] | [INFO] [stderr] 221 | r[8*i+0] = Q + ETA - r[8*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:232:15 [INFO] [stderr] | [INFO] [stderr] 232 | r[2*i+0] = u32::from(a[i]) & 0x0F; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:234:36 [INFO] [stderr] | [INFO] [stderr] 234 | r[2*i+0] = Q + ETA - r[2*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:234:15 [INFO] [stderr] | [INFO] [stderr] 234 | r[2*i+0] = Q + ETA - r[2*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:244:44 [INFO] [stderr] | [INFO] [stderr] 244 | t[0] = Q + (1 << (D-1) as u32) - a[4*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `7*i` [INFO] [stderr] --> src/poly.rs:249:11 [INFO] [stderr] | [INFO] [stderr] 249 | r[7*i+0] = t[0] as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `7*i` [INFO] [stderr] --> src/poly.rs:265:33 [INFO] [stderr] | [INFO] [stderr] 265 | r[4*i+0] = u32::from(a[7*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:265:11 [INFO] [stderr] | [INFO] [stderr] 265 | r[4*i+0] = u32::from(a[7*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:266:11 [INFO] [stderr] | [INFO] [stderr] 266 | r[4*i+0] |= (u32::from(a[7*i+1]) & 0x3F) << 8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:279:48 [INFO] [stderr] | [INFO] [stderr] 279 | r[4*i+0] = Q + (1 << (D-1) as u32) - r[4*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:279:11 [INFO] [stderr] | [INFO] [stderr] 279 | r[4*i+0] = Q + (1 << (D-1) as u32) - r[4*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:289:25 [INFO] [stderr] | [INFO] [stderr] 289 | r[9*i+0] = ( a[8*i+0] & 0xFF) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `9*i` [INFO] [stderr] --> src/poly.rs:289:11 [INFO] [stderr] | [INFO] [stderr] 289 | r[9*i+0] = ( a[8*i+0] & 0xFF) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | r[9*i+1] = ((a[8*i+0] >> 8) | ((a[8*i+1] & 0x7F) << 1)) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `9*i` [INFO] [stderr] --> src/poly.rs:304:33 [INFO] [stderr] | [INFO] [stderr] 304 | r[8*i+0] = u32::from(a[9*i+0]) | (u32::from(a[9*i+1] & 0x01) << 8); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:304:11 [INFO] [stderr] | [INFO] [stderr] 304 | r[8*i+0] = u32::from(a[9*i+0]) | (u32::from(a[9*i+1] & 0x01) << 8); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `a[9*i+8]` [INFO] [stderr] --> src/poly.rs:311:60 [INFO] [stderr] | [INFO] [stderr] 311 | r[8*i+7] = (u32::from(a[9*i+7]) >> 7) | (u32::from(a[9*i+8] & 0xFF) << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:319:44 [INFO] [stderr] | [INFO] [stderr] 319 | t[0] = (GAMMA1 - 1).wrapping_sub(a[2*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `5*i` [INFO] [stderr] --> src/poly.rs:324:11 [INFO] [stderr] | [INFO] [stderr] 324 | r[5*i+0] = t[0] as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `5*i` [INFO] [stderr] --> src/poly.rs:336:33 [INFO] [stderr] | [INFO] [stderr] 336 | r[2*i+0] = u32::from(a[5*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:336:11 [INFO] [stderr] | [INFO] [stderr] 336 | r[2*i+0] = u32::from(a[5*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:337:11 [INFO] [stderr] | [INFO] [stderr] 337 | r[2*i+0] |= u32::from(a[5*i+1]) << 8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:338:11 [INFO] [stderr] | [INFO] [stderr] 338 | r[2*i+0] |= u32::from(a[5*i+2] & 0x0F) << 16; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:344:48 [INFO] [stderr] | [INFO] [stderr] 344 | r[2*i+0] = (GAMMA1 - 1).wrapping_sub(r[2*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:344:11 [INFO] [stderr] | [INFO] [stderr] 344 | r[2*i+0] = (GAMMA1 - 1).wrapping_sub(r[2*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:345:22 [INFO] [stderr] | [INFO] [stderr] 345 | r[2*i+0] = r[2*i+0].wrapping_add(((r[2*i+0] as i32) >> 31) as u32 & Q); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:345:46 [INFO] [stderr] | [INFO] [stderr] 345 | r[2*i+0] = r[2*i+0].wrapping_add(((r[2*i+0] as i32) >> 31) as u32 & Q); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:345:11 [INFO] [stderr] | [INFO] [stderr] 345 | r[2*i+0] = r[2*i+0].wrapping_add(((r[2*i+0] as i32) >> 31) as u32 & Q); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `w`. [INFO] [stderr] --> src/polyvec.rs:112:14 [INFO] [stderr] | [INFO] [stderr] 112 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 112 | for in w.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t1` [INFO] [stderr] --> src/packing.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 18 | for (i, ) in t1.iter().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let (rho_bytes, t1s_bytes) = array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let (rho_bytes, t1s_bytes) = array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let (rho_bytes, t1s_bytes) = array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t1` [INFO] [stderr] --> src/packing.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for (i, ) in t1.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / mut_array_refs!( [INFO] [stderr] 49 | | sk, [INFO] [stderr] 50 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 51 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 52 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 53 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 54 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / mut_array_refs!( [INFO] [stderr] 49 | | sk, [INFO] [stderr] 50 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 51 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 52 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 53 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 54 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / mut_array_refs!( [INFO] [stderr] 49 | | sk, [INFO] [stderr] 50 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 51 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 52 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 53 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 54 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s1` [INFO] [stderr] --> src/packing.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for (i, ) in s1.iter().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s2` [INFO] [stderr] --> src/packing.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for (i, ) in s2.iter().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t0` [INFO] [stderr] --> src/packing.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 68 | for (i, ) in t0.iter().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / array_refs!( [INFO] [stderr] 85 | | sk, [INFO] [stderr] 86 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 87 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 88 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 89 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 90 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / array_refs!( [INFO] [stderr] 85 | | sk, [INFO] [stderr] 86 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 87 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 88 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 89 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 90 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / array_refs!( [INFO] [stderr] 85 | | sk, [INFO] [stderr] 86 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 87 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 88 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 89 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 90 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s1` [INFO] [stderr] --> src/packing.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for (i, ) in s1.iter_mut().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s2` [INFO] [stderr] --> src/packing.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for (i, ) in s2.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t0` [INFO] [stderr] --> src/packing.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for (i, ) in t0.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / mut_array_refs!( [INFO] [stderr] 117 | | sign, [INFO] [stderr] 118 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 119 | | OMEGA + K, [INFO] [stderr] 120 | | N / 8 + 8 [INFO] [stderr] 121 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / mut_array_refs!( [INFO] [stderr] 117 | | sign, [INFO] [stderr] 118 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 119 | | OMEGA + K, [INFO] [stderr] 120 | | N / 8 + 8 [INFO] [stderr] 121 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / mut_array_refs!( [INFO] [stderr] 117 | | sign, [INFO] [stderr] 118 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 119 | | OMEGA + K, [INFO] [stderr] 120 | | N / 8 + 8 [INFO] [stderr] 121 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `z` [INFO] [stderr] --> src/packing.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (i, ) in z.iter().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / array_refs!( [INFO] [stderr] 160 | | sign, [INFO] [stderr] 161 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 162 | | OMEGA + K, [INFO] [stderr] 163 | | N / 8 + 8 [INFO] [stderr] 164 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / array_refs!( [INFO] [stderr] 160 | | sign, [INFO] [stderr] 161 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 162 | | OMEGA + K, [INFO] [stderr] 163 | | N / 8 + 8 [INFO] [stderr] 164 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / array_refs!( [INFO] [stderr] 160 | | sign, [INFO] [stderr] 161 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 162 | | OMEGA + K, [INFO] [stderr] 163 | | N / 8 + 8 [INFO] [stderr] 164 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `z` [INFO] [stderr] --> src/packing.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 166 | for (i, ) in z.iter_mut().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `mat` [INFO] [stderr] --> src/sign.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for (i, ) in mat.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s1`. [INFO] [stderr] --> src/sign.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 101 | for in s1.iter_mut().take(L) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s2`. [INFO] [stderr] --> src/sign.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in s2.iter_mut().take(K) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | let mut s1hat = s1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `s1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `y`. [INFO] [stderr] --> src/sign.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 157 | for in y.iter_mut().take(L) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | let mut yhat = y.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | let mut chat = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:247:20 [INFO] [stderr] | [INFO] [stderr] 247 | let mut chat = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `p`. [INFO] [stderr] --> src/ntt.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | for j in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for in p.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/poly.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 15 | for in a.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/poly.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in a.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/poly.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in a.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:178:33 [INFO] [stderr] | [INFO] [stderr] 178 | t[0] = (Q + ETA - a[8*i+0]) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:187:15 [INFO] [stderr] | [INFO] [stderr] 187 | r[3*i+0] = t[0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:188:15 [INFO] [stderr] | [INFO] [stderr] 188 | r[3*i+0] |= t[1] << 3; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:189:15 [INFO] [stderr] | [INFO] [stderr] 189 | r[3*i+0] |= t[2] << 6; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:201:33 [INFO] [stderr] | [INFO] [stderr] 201 | t[0] = (Q + ETA - a[2*i+0]) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:212:36 [INFO] [stderr] | [INFO] [stderr] 212 | r[8*i+0] = u32::from(a[3*i+0]) & 0x07; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:212:15 [INFO] [stderr] | [INFO] [stderr] 212 | r[8*i+0] = u32::from(a[3*i+0]) & 0x07; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:213:37 [INFO] [stderr] | [INFO] [stderr] 213 | r[8*i+1] = (u32::from(a[3*i+0]) >> 3) & 0x07; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3*i` [INFO] [stderr] --> src/poly.rs:214:37 [INFO] [stderr] | [INFO] [stderr] 214 | r[8*i+2] = (u32::from(a[3*i+0]) >> 6) | ((u32::from(a[3*i+1]) & 0x01) << 2); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:221:36 [INFO] [stderr] | [INFO] [stderr] 221 | r[8*i+0] = Q + ETA - r[8*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:221:15 [INFO] [stderr] | [INFO] [stderr] 221 | r[8*i+0] = Q + ETA - r[8*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:232:15 [INFO] [stderr] | [INFO] [stderr] 232 | r[2*i+0] = u32::from(a[i]) & 0x0F; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:234:36 [INFO] [stderr] | [INFO] [stderr] 234 | r[2*i+0] = Q + ETA - r[2*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:234:15 [INFO] [stderr] | [INFO] [stderr] 234 | r[2*i+0] = Q + ETA - r[2*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:244:44 [INFO] [stderr] | [INFO] [stderr] 244 | t[0] = Q + (1 << (D-1) as u32) - a[4*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `7*i` [INFO] [stderr] --> src/poly.rs:249:11 [INFO] [stderr] | [INFO] [stderr] 249 | r[7*i+0] = t[0] as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `7*i` [INFO] [stderr] --> src/poly.rs:265:33 [INFO] [stderr] | [INFO] [stderr] 265 | r[4*i+0] = u32::from(a[7*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:265:11 [INFO] [stderr] | [INFO] [stderr] 265 | r[4*i+0] = u32::from(a[7*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:266:11 [INFO] [stderr] | [INFO] [stderr] 266 | r[4*i+0] |= (u32::from(a[7*i+1]) & 0x3F) << 8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:279:48 [INFO] [stderr] | [INFO] [stderr] 279 | r[4*i+0] = Q + (1 << (D-1) as u32) - r[4*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4*i` [INFO] [stderr] --> src/poly.rs:279:11 [INFO] [stderr] | [INFO] [stderr] 279 | r[4*i+0] = Q + (1 << (D-1) as u32) - r[4*i+0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:289:25 [INFO] [stderr] | [INFO] [stderr] 289 | r[9*i+0] = ( a[8*i+0] & 0xFF) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `9*i` [INFO] [stderr] --> src/poly.rs:289:11 [INFO] [stderr] | [INFO] [stderr] 289 | r[9*i+0] = ( a[8*i+0] & 0xFF) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:290:25 [INFO] [stderr] | [INFO] [stderr] 290 | r[9*i+1] = ((a[8*i+0] >> 8) | ((a[8*i+1] & 0x7F) << 1)) as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `9*i` [INFO] [stderr] --> src/poly.rs:304:33 [INFO] [stderr] | [INFO] [stderr] 304 | r[8*i+0] = u32::from(a[9*i+0]) | (u32::from(a[9*i+1] & 0x01) << 8); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8*i` [INFO] [stderr] --> src/poly.rs:304:11 [INFO] [stderr] | [INFO] [stderr] 304 | r[8*i+0] = u32::from(a[9*i+0]) | (u32::from(a[9*i+1] & 0x01) << 8); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `a[9*i+8]` [INFO] [stderr] --> src/poly.rs:311:60 [INFO] [stderr] | [INFO] [stderr] 311 | r[8*i+7] = (u32::from(a[9*i+7]) >> 7) | (u32::from(a[9*i+8] & 0xFF) << 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:319:44 [INFO] [stderr] | [INFO] [stderr] 319 | t[0] = (GAMMA1 - 1).wrapping_sub(a[2*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `5*i` [INFO] [stderr] --> src/poly.rs:324:11 [INFO] [stderr] | [INFO] [stderr] 324 | r[5*i+0] = t[0] as u8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `5*i` [INFO] [stderr] --> src/poly.rs:336:33 [INFO] [stderr] | [INFO] [stderr] 336 | r[2*i+0] = u32::from(a[5*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:336:11 [INFO] [stderr] | [INFO] [stderr] 336 | r[2*i+0] = u32::from(a[5*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:337:11 [INFO] [stderr] | [INFO] [stderr] 337 | r[2*i+0] |= u32::from(a[5*i+1]) << 8; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:338:11 [INFO] [stderr] | [INFO] [stderr] 338 | r[2*i+0] |= u32::from(a[5*i+2] & 0x0F) << 16; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:344:48 [INFO] [stderr] | [INFO] [stderr] 344 | r[2*i+0] = (GAMMA1 - 1).wrapping_sub(r[2*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:344:11 [INFO] [stderr] | [INFO] [stderr] 344 | r[2*i+0] = (GAMMA1 - 1).wrapping_sub(r[2*i+0]); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:345:22 [INFO] [stderr] | [INFO] [stderr] 345 | r[2*i+0] = r[2*i+0].wrapping_add(((r[2*i+0] as i32) >> 31) as u32 & Q); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:345:46 [INFO] [stderr] | [INFO] [stderr] 345 | r[2*i+0] = r[2*i+0].wrapping_add(((r[2*i+0] as i32) >> 31) as u32 & Q); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2*i` [INFO] [stderr] --> src/poly.rs:345:11 [INFO] [stderr] | [INFO] [stderr] 345 | r[2*i+0] = r[2*i+0].wrapping_add(((r[2*i+0] as i32) >> 31) as u32 & Q); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `w`. [INFO] [stderr] --> src/polyvec.rs:112:14 [INFO] [stderr] | [INFO] [stderr] 112 | for i in 0..N { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 112 | for in w.iter_mut().take(N) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:15:38 [INFO] [stderr] | [INFO] [stderr] 15 | let (rho_bytes, t1s_bytes) = mut_array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t1` [INFO] [stderr] --> src/packing.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 18 | for (i, ) in t1.iter().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let (rho_bytes, t1s_bytes) = array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let (rho_bytes, t1s_bytes) = array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let (rho_bytes, t1s_bytes) = array_refs!(pk, SEEDBYTES, POLT1_SIZE_PACKED * K); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t1` [INFO] [stderr] --> src/packing.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for (i, ) in t1.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / mut_array_refs!( [INFO] [stderr] 49 | | sk, [INFO] [stderr] 50 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 51 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 52 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 53 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 54 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / mut_array_refs!( [INFO] [stderr] 49 | | sk, [INFO] [stderr] 50 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 51 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 52 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 53 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 54 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / mut_array_refs!( [INFO] [stderr] 49 | | sk, [INFO] [stderr] 50 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 51 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 52 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 53 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 54 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s1` [INFO] [stderr] --> src/packing.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for (i, ) in s1.iter().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s2` [INFO] [stderr] --> src/packing.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for (i, ) in s2.iter().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t0` [INFO] [stderr] --> src/packing.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 68 | for (i, ) in t0.iter().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / array_refs!( [INFO] [stderr] 85 | | sk, [INFO] [stderr] 86 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 87 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 88 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 89 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 90 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / array_refs!( [INFO] [stderr] 85 | | sk, [INFO] [stderr] 86 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 87 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 88 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 89 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 90 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / array_refs!( [INFO] [stderr] 85 | | sk, [INFO] [stderr] 86 | | SEEDBYTES, SEEDBYTES, CRHBYTES, [INFO] [stderr] 87 | | POLETA_SIZE_PACKED * L, [INFO] [stderr] 88 | | POLETA_SIZE_PACKED * K, [INFO] [stderr] 89 | | POLT0_SIZE_PACKED * K [INFO] [stderr] 90 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s1` [INFO] [stderr] --> src/packing.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for (i, ) in s1.iter_mut().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s2` [INFO] [stderr] --> src/packing.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for (i, ) in s2.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t0` [INFO] [stderr] --> src/packing.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for (i, ) in t0.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / mut_array_refs!( [INFO] [stderr] 117 | | sign, [INFO] [stderr] 118 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 119 | | OMEGA + K, [INFO] [stderr] 120 | | N / 8 + 8 [INFO] [stderr] 121 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / mut_array_refs!( [INFO] [stderr] 117 | | sign, [INFO] [stderr] 118 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 119 | | OMEGA + K, [INFO] [stderr] 120 | | N / 8 + 8 [INFO] [stderr] 121 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / mut_array_refs!( [INFO] [stderr] 117 | | sign, [INFO] [stderr] 118 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 119 | | OMEGA + K, [INFO] [stderr] 120 | | N / 8 + 8 [INFO] [stderr] 121 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `z` [INFO] [stderr] --> src/packing.rs:123:18 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (i, ) in z.iter().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/packing.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / array_refs!( [INFO] [stderr] 160 | | sign, [INFO] [stderr] 161 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 162 | | OMEGA + K, [INFO] [stderr] 163 | | N / 8 + 8 [INFO] [stderr] 164 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/packing.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / array_refs!( [INFO] [stderr] 160 | | sign, [INFO] [stderr] 161 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 162 | | OMEGA + K, [INFO] [stderr] 163 | | N / 8 + 8 [INFO] [stderr] 164 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/packing.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / array_refs!( [INFO] [stderr] 160 | | sign, [INFO] [stderr] 161 | | POLZ_SIZE_PACKED * L, [INFO] [stderr] 162 | | OMEGA + K, [INFO] [stderr] 163 | | N / 8 + 8 [INFO] [stderr] 164 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `z` [INFO] [stderr] --> src/packing.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 166 | for (i, ) in z.iter_mut().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `mat` [INFO] [stderr] --> src/sign.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for (i, ) in mat.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s1`. [INFO] [stderr] --> src/sign.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 101 | for in s1.iter_mut().take(L) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s2`. [INFO] [stderr] --> src/sign.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in s2.iter_mut().take(K) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | let mut s1hat = s1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `s1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `y`. [INFO] [stderr] --> src/sign.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 157 | for in y.iter_mut().take(L) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | let mut yhat = y.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | let mut chat = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sign.rs:247:20 [INFO] [stderr] | [INFO] [stderr] 247 | let mut chat = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/test_vectors.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | assert!(&mat == &tv.mat); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 127 | assert!(mat == tv.mat); [INFO] [stderr] | ^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `s` [INFO] [stderr] --> src/test_vectors.rs:129:18 [INFO] [stderr] | [INFO] [stderr] 129 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 129 | for (i, ) in s.iter_mut().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/test_vectors.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | assert!(&s == &tv.s); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 132 | assert!(s == tv.s); [INFO] [stderr] | ^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `y` [INFO] [stderr] --> src/test_vectors.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | for i in 0..L { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 134 | for (i, ) in y.iter_mut().enumerate().take(L) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/test_vectors.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | assert!(&y == &tv.y); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 137 | assert!(y == tv.y); [INFO] [stderr] | ^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/test_vectors.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | assert!(&w1 == &tv.w1); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 146 | assert!(w1 == tv.w1); [INFO] [stderr] | ^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/test_vectors.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | assert!(&c[..] == &tv.c[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 149 | assert!(c[..] == tv.c[..]); [INFO] [stderr] | ^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.90s [INFO] running `"docker" "inspect" "62cd16f23317ae6ec6aba9bf83004f4e5a7e72a6bf07837c3d5f27184a67e561"` [INFO] running `"docker" "rm" "-f" "62cd16f23317ae6ec6aba9bf83004f4e5a7e72a6bf07837c3d5f27184a67e561"` [INFO] [stdout] 62cd16f23317ae6ec6aba9bf83004f4e5a7e72a6bf07837c3d5f27184a67e561