[INFO] crate diet 0.1.0 is already in cache [INFO] extracting crate diet 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/diet/0.1.0 [INFO] extracting crate diet 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/diet/0.1.0 [INFO] validating manifest of diet-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of diet-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing diet-0.1.0 [INFO] finished frobbing diet-0.1.0 [INFO] frobbed toml for diet-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/diet/0.1.0/Cargo.toml [INFO] started frobbing diet-0.1.0 [INFO] finished frobbing diet-0.1.0 [INFO] frobbed toml for diet-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/diet/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting diet-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/diet/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1927d7c0a89e25de7b8899511d0c88bfe9520606dc947eb3badaa64dfc8c96b [INFO] running `"docker" "start" "-a" "d1927d7c0a89e25de7b8899511d0c88bfe9520606dc947eb3badaa64dfc8c96b"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/diet.rs` was erroneously implicitly accepted for library `diet`, [INFO] [stderr] please rename the file to `src/lib.rs` or set lib.path in Cargo.toml [INFO] [stderr] Checking diet v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | Interval { lower: lower, upper: lower } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lower` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | Interval { lower: lower, upper: upper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | Interval { lower: lower, upper: upper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `upper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:173:63 [INFO] [stderr] | [INFO] [stderr] 173 | node.right = Some(Box::new(Node { left: None, right: right, value: right_value })); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | Interval { lower: lower, upper: lower } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lower` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | Interval { lower: lower, upper: upper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | Interval { lower: lower, upper: upper } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `upper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet.rs:173:63 [INFO] [stderr] | [INFO] [stderr] 173 | node.right = Some(Box::new(Node { left: None, right: right, value: right_value })); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/diet.rs:197:45 [INFO] [stderr] | [INFO] [stderr] 197 | pub fn insert(&mut self, new_item: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/diet.rs:201:41 [INFO] [stderr] | [INFO] [stderr] 201 | pub fn delete(&mut self, item: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Diet` [INFO] [stderr] --> src/diet.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / pub fn new() -> Diet { [INFO] [stderr] 190 | | Diet { root: None } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/diet.rs:197:45 [INFO] [stderr] | [INFO] [stderr] 197 | pub fn insert(&mut self, new_item: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/diet.rs:201:41 [INFO] [stderr] | [INFO] [stderr] 201 | pub fn delete(&mut self, item: i32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Diet` [INFO] [stderr] --> src/diet.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | / pub fn new() -> Diet { [INFO] [stderr] 190 | | Diet { root: None } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "d1927d7c0a89e25de7b8899511d0c88bfe9520606dc947eb3badaa64dfc8c96b"` [INFO] running `"docker" "rm" "-f" "d1927d7c0a89e25de7b8899511d0c88bfe9520606dc947eb3badaa64dfc8c96b"` [INFO] [stdout] d1927d7c0a89e25de7b8899511d0c88bfe9520606dc947eb3badaa64dfc8c96b