[INFO] crate diesel_codegen_shared 0.10.0 is already in cache [INFO] extracting crate diesel_codegen_shared 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/diesel_codegen_shared/0.10.0 [INFO] extracting crate diesel_codegen_shared 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/diesel_codegen_shared/0.10.0 [INFO] validating manifest of diesel_codegen_shared-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of diesel_codegen_shared-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing diesel_codegen_shared-0.10.0 [INFO] finished frobbing diesel_codegen_shared-0.10.0 [INFO] frobbed toml for diesel_codegen_shared-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/diesel_codegen_shared/0.10.0/Cargo.toml [INFO] started frobbing diesel_codegen_shared-0.10.0 [INFO] finished frobbing diesel_codegen_shared-0.10.0 [INFO] frobbed toml for diesel_codegen_shared-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/diesel_codegen_shared/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting diesel_codegen_shared-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/diesel_codegen_shared/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55f4de3288aa3de90d58c3dfdcdb7dd690bf063886f6368b05ba836d21b392c7 [INFO] running `"docker" "start" "-a" "55f4de3288aa3de90d58c3dfdcdb7dd690bf063886f6368b05ba836d21b392c7"` [INFO] [stderr] Checking diesel v0.10.1 [INFO] [stderr] Checking dotenv v0.8.0 [INFO] [stderr] Checking diesel_codegen_shared v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database_url.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return extract_database_url(&url[3..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `extract_database_url(&url[3..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/database_url.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn extract_database_url<'a>(url: &'a str) -> Result, String> { [INFO] [stderr] 6 | | if url.starts_with("dotenv:") { [INFO] [stderr] 7 | | try!(load_dotenv_file()); [INFO] [stderr] 8 | | return extract_database_url(&url[3..]); [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database_url.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | return extract_database_url(&url[3..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `extract_database_url(&url[3..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/database_url.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn extract_database_url<'a>(url: &'a str) -> Result, String> { [INFO] [stderr] 6 | | if url.starts_with("dotenv:") { [INFO] [stderr] 7 | | try!(load_dotenv_file()); [INFO] [stderr] 8 | | return extract_database_url(&url[3..]); [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.82s [INFO] running `"docker" "inspect" "55f4de3288aa3de90d58c3dfdcdb7dd690bf063886f6368b05ba836d21b392c7"` [INFO] running `"docker" "rm" "-f" "55f4de3288aa3de90d58c3dfdcdb7dd690bf063886f6368b05ba836d21b392c7"` [INFO] [stdout] 55f4de3288aa3de90d58c3dfdcdb7dd690bf063886f6368b05ba836d21b392c7