[INFO] crate diesel-derive-more 1.1.3 is already in cache [INFO] extracting crate diesel-derive-more 1.1.3 into work/ex/clippy-test-run/sources/stable/reg/diesel-derive-more/1.1.3 [INFO] extracting crate diesel-derive-more 1.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/diesel-derive-more/1.1.3 [INFO] validating manifest of diesel-derive-more-1.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of diesel-derive-more-1.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing diesel-derive-more-1.1.3 [INFO] finished frobbing diesel-derive-more-1.1.3 [INFO] frobbed toml for diesel-derive-more-1.1.3 written to work/ex/clippy-test-run/sources/stable/reg/diesel-derive-more/1.1.3/Cargo.toml [INFO] started frobbing diesel-derive-more-1.1.3 [INFO] finished frobbing diesel-derive-more-1.1.3 [INFO] frobbed toml for diesel-derive-more-1.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/diesel-derive-more/1.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting diesel-derive-more-1.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/diesel-derive-more/1.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] edbc72e0cb2b32802f0537649fa1f809e393ff3be565fb0fe87cf4c49bf20647 [INFO] running `"docker" "start" "-a" "edbc72e0cb2b32802f0537649fa1f809e393ff3be565fb0fe87cf4c49bf20647"` [INFO] [stderr] Checking proc-macro2 v0.2.3 [INFO] [stderr] Compiling chrono v0.4.6 [INFO] [stderr] Compiling diesel_derives v1.4.0 [INFO] [stderr] Checking quote v0.4.2 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Compiling diesel v1.4.1 [INFO] [stderr] Compiling diesel-derive-more v1.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/default_insertable.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match self.get_attribute_by_name(attribute_name) { [INFO] [stderr] 12 | | Some(_) => true, [INFO] [stderr] 13 | | None => false, [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ help: try this: `self.get_attribute_by_name(attribute_name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/default_insertable.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | let name = Ident::from(String::from("New") + &ast.ident.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ast.ident.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db_enum.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | fn impl_diesel_traits(name: &Ident, variants: &Punctuated) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db_enum.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | fn impl_value_matcher_read(name: &Ident, variants: &Punctuated) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/default_insertable.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match self.get_attribute_by_name(attribute_name) { [INFO] [stderr] 12 | | Some(_) => true, [INFO] [stderr] 13 | | None => false, [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ help: try this: `self.get_attribute_by_name(attribute_name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/default_insertable.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | let name = Ident::from(String::from("New") + &ast.ident.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `ast.ident.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db_enum.rs:70:35 [INFO] [stderr] | [INFO] [stderr] 70 | fn impl_value_matcher_write(name: &Ident, variants: &Punctuated) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db_enum.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | fn impl_diesel_traits(name: &Ident, variants: &Punctuated) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db_enum.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | fn impl_value_matcher_read(name: &Ident, variants: &Punctuated) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/db_enum.rs:70:35 [INFO] [stderr] | [INFO] [stderr] 70 | fn impl_value_matcher_write(name: &Ident, variants: &Punctuated) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 27s [INFO] running `"docker" "inspect" "edbc72e0cb2b32802f0537649fa1f809e393ff3be565fb0fe87cf4c49bf20647"` [INFO] running `"docker" "rm" "-f" "edbc72e0cb2b32802f0537649fa1f809e393ff3be565fb0fe87cf4c49bf20647"` [INFO] [stdout] edbc72e0cb2b32802f0537649fa1f809e393ff3be565fb0fe87cf4c49bf20647