[INFO] crate dictcc-cli 0.2.0 is already in cache [INFO] extracting crate dictcc-cli 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dictcc-cli/0.2.0 [INFO] extracting crate dictcc-cli 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dictcc-cli/0.2.0 [INFO] validating manifest of dictcc-cli-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dictcc-cli-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dictcc-cli-0.2.0 [INFO] finished frobbing dictcc-cli-0.2.0 [INFO] frobbed toml for dictcc-cli-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dictcc-cli/0.2.0/Cargo.toml [INFO] started frobbing dictcc-cli-0.2.0 [INFO] finished frobbing dictcc-cli-0.2.0 [INFO] frobbed toml for dictcc-cli-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dictcc-cli/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dictcc-cli-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dictcc-cli/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34e2380efa66e91ecf62d7f0969dbb46b70ca98afe1856c1ae4de8478a9c1444 [INFO] running `"docker" "start" "-a" "34e2380efa66e91ecf62d7f0969dbb46b70ca98afe1856c1ae4de8478a9c1444"` [INFO] [stderr] Compiling dictcc-cli v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking pkg-config v0.3.14 [INFO] [stderr] Compiling sqlite3-src v0.2.10 [INFO] [stderr] Checking sqlite3-sys v0.12.0 [INFO] [stderr] Checking sqlite v0.23.9 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Error::GetoptsFail(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::GetoptsFail(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return Error::SqlError(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::SqlError(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | match *&self { [INFO] [stderr] | ^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return Error::GetoptsFail(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::GetoptsFail(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return Error::SqlError(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::SqlError(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | match *&self { [INFO] [stderr] | ^^^^^^ help: try this: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match *&self { [INFO] [stderr] 60 | | &Error::GetoptsFail(ref e) => return write!(f, "Argument error: {}", e), [INFO] [stderr] 61 | | &Error::SqlError(ref e) => return write!(f, "SQL error: {}", e), [INFO] [stderr] 62 | | &Error::Error(ref e) => return write!(f, "{}", e), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *(*&self) { [INFO] [stderr] 60 | Error::GetoptsFail(ref e) => return write!(f, "Argument error: {}", e), [INFO] [stderr] 61 | Error::SqlError(ref e) => return write!(f, "SQL error: {}", e), [INFO] [stderr] 62 | Error::Error(ref e) => return write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | let src_term = row[0].as_string().ok_or(Error::Error(format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 106 | | "Invalid first column in result: {:?}", [INFO] [stderr] 107 | | row [INFO] [stderr] 108 | | )))?; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | let src_term = row[0].as_string().ok_or_else(|| Error::Error(format!( [INFO] [stderr] 106 | "Invalid first column in result: {:?}", [INFO] [stderr] 107 | row [INFO] [stderr] 108 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:109:39 [INFO] [stderr] | [INFO] [stderr] 109 | let dst_term = row[1].as_string().ok_or(Error::Error(format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 110 | | "Invalid second column in result: {:?}", [INFO] [stderr] 111 | | row [INFO] [stderr] 112 | | )))?; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | let dst_term = row[1].as_string().ok_or_else(|| Error::Error(format!( [INFO] [stderr] 110 | "Invalid second column in result: {:?}", [INFO] [stderr] 111 | row [INFO] [stderr] 112 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:113:36 [INFO] [stderr] | [INFO] [stderr] 113 | let type_ = row[2].as_string().ok_or(Error::Error(format!( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 114 | | "Invalid third column in result: {:?}", [INFO] [stderr] 115 | | row [INFO] [stderr] 116 | | )))?; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | let type_ = row[2].as_string().ok_or_else(|| Error::Error(format!( [INFO] [stderr] 114 | "Invalid third column in result: {:?}", [INFO] [stderr] 115 | row [INFO] [stderr] 116 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:127:28 [INFO] [stderr] | [INFO] [stderr] 127 | let path = db.to_str().ok_or( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 128 | | Error::Error("No database given".to_string()), [INFO] [stderr] 129 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Error("No database given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:261:36 [INFO] [stderr] | [INFO] [stderr] 261 | let program = env::args().nth(0).unwrap_or("dictcc-cli".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "dictcc-cli".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:319:56 [INFO] [stderr] | [INFO] [stderr] 319 | fn translate(db: &path::Path, to_translate: &str, mut callback: F) -> Result<()> [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match *&self { [INFO] [stderr] 60 | | &Error::GetoptsFail(ref e) => return write!(f, "Argument error: {}", e), [INFO] [stderr] 61 | | &Error::SqlError(ref e) => return write!(f, "SQL error: {}", e), [INFO] [stderr] 62 | | &Error::Error(ref e) => return write!(f, "{}", e), [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *(*&self) { [INFO] [stderr] 60 | Error::GetoptsFail(ref e) => return write!(f, "Argument error: {}", e), [INFO] [stderr] 61 | Error::SqlError(ref e) => return write!(f, "SQL error: {}", e), [INFO] [stderr] 62 | Error::Error(ref e) => return write!(f, "{}", e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | let src_term = row[0].as_string().ok_or(Error::Error(format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 106 | | "Invalid first column in result: {:?}", [INFO] [stderr] 107 | | row [INFO] [stderr] 108 | | )))?; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | let src_term = row[0].as_string().ok_or_else(|| Error::Error(format!( [INFO] [stderr] 106 | "Invalid first column in result: {:?}", [INFO] [stderr] 107 | row [INFO] [stderr] 108 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:109:39 [INFO] [stderr] | [INFO] [stderr] 109 | let dst_term = row[1].as_string().ok_or(Error::Error(format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 110 | | "Invalid second column in result: {:?}", [INFO] [stderr] 111 | | row [INFO] [stderr] 112 | | )))?; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | let dst_term = row[1].as_string().ok_or_else(|| Error::Error(format!( [INFO] [stderr] 110 | "Invalid second column in result: {:?}", [INFO] [stderr] 111 | row [INFO] [stderr] 112 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:113:36 [INFO] [stderr] | [INFO] [stderr] 113 | let type_ = row[2].as_string().ok_or(Error::Error(format!( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 114 | | "Invalid third column in result: {:?}", [INFO] [stderr] 115 | | row [INFO] [stderr] 116 | | )))?; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | let type_ = row[2].as_string().ok_or_else(|| Error::Error(format!( [INFO] [stderr] 114 | "Invalid third column in result: {:?}", [INFO] [stderr] 115 | row [INFO] [stderr] 116 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:127:28 [INFO] [stderr] | [INFO] [stderr] 127 | let path = db.to_str().ok_or( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 128 | | Error::Error("No database given".to_string()), [INFO] [stderr] 129 | | )?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::Error("No database given".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:261:36 [INFO] [stderr] | [INFO] [stderr] 261 | let program = env::args().nth(0).unwrap_or("dictcc-cli".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "dictcc-cli".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.33s [INFO] running `"docker" "inspect" "34e2380efa66e91ecf62d7f0969dbb46b70ca98afe1856c1ae4de8478a9c1444"` [INFO] running `"docker" "rm" "-f" "34e2380efa66e91ecf62d7f0969dbb46b70ca98afe1856c1ae4de8478a9c1444"` [INFO] [stdout] 34e2380efa66e91ecf62d7f0969dbb46b70ca98afe1856c1ae4de8478a9c1444