[INFO] crate dicom_dictionary_parser 0.2.0 is already in cache [INFO] extracting crate dicom_dictionary_parser 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dicom_dictionary_parser/0.2.0 [INFO] extracting crate dicom_dictionary_parser 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dicom_dictionary_parser/0.2.0 [INFO] validating manifest of dicom_dictionary_parser-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dicom_dictionary_parser-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dicom_dictionary_parser-0.2.0 [INFO] finished frobbing dicom_dictionary_parser-0.2.0 [INFO] frobbed toml for dicom_dictionary_parser-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dicom_dictionary_parser/0.2.0/Cargo.toml [INFO] started frobbing dicom_dictionary_parser-0.2.0 [INFO] finished frobbing dicom_dictionary_parser-0.2.0 [INFO] frobbed toml for dicom_dictionary_parser-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dicom_dictionary_parser/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dicom_dictionary_parser-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dicom_dictionary_parser/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 82b51187d0925cc4a2c9c2c71c85f8e3801312eaf577735abcd7dcea4c44a667 [INFO] running `"docker" "start" "-a" "82b51187d0925cc4a2c9c2c71c85f8e3801312eaf577735abcd7dcea4c44a667"` [INFO] [stderr] Checking xmltree v0.8.0 [INFO] [stderr] Checking dicom_dictionary_parser v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: the variable `counter` is used as a loop counter. Consider using `for (counter, item) in &tr.children.enumerate()` or similar iterators [INFO] [stderr] --> src/parser.rs:140:23 [INFO] [stderr] | [INFO] [stderr] 140 | for td in &tr.children { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/parser.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | val @ _ => return Err(From::from(format!("Unknown UID type '{}'", val))), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:306:41 [INFO] [stderr] | [INFO] [stderr] 306 | if normalized_uid_name.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:307:56 [INFO] [stderr] | [INFO] [stderr] 307 | let colon_index = normalized_uid_name.find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `uid::UID` [INFO] [stderr] --> src/uid.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Self { [INFO] [stderr] 49 | | UID { [INFO] [stderr] 50 | | value: String::new(), [INFO] [stderr] 51 | | normalized_name: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for uid::UID { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `counter` is used as a loop counter. Consider using `for (counter, item) in &tr.children.enumerate()` or similar iterators [INFO] [stderr] --> src/parser.rs:140:23 [INFO] [stderr] | [INFO] [stderr] 140 | for td in &tr.children { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the `val @ _` pattern can be written as just `val` [INFO] [stderr] --> src/parser.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | val @ _ => return Err(From::from(format!("Unknown UID type '{}'", val))), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:306:41 [INFO] [stderr] | [INFO] [stderr] 306 | if normalized_uid_name.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:307:56 [INFO] [stderr] | [INFO] [stderr] 307 | let colon_index = normalized_uid_name.find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `uid::UID` [INFO] [stderr] --> src/uid.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Self { [INFO] [stderr] 49 | | UID { [INFO] [stderr] 50 | | value: String::new(), [INFO] [stderr] 51 | | normalized_name: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for uid::UID { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.44s [INFO] running `"docker" "inspect" "82b51187d0925cc4a2c9c2c71c85f8e3801312eaf577735abcd7dcea4c44a667"` [INFO] running `"docker" "rm" "-f" "82b51187d0925cc4a2c9c2c71c85f8e3801312eaf577735abcd7dcea4c44a667"` [INFO] [stdout] 82b51187d0925cc4a2c9c2c71c85f8e3801312eaf577735abcd7dcea4c44a667