[INFO] crate dia-go 0.2.1 is already in cache [INFO] extracting crate dia-go 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/dia-go/0.2.1 [INFO] extracting crate dia-go 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dia-go/0.2.1 [INFO] validating manifest of dia-go-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dia-go-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dia-go-0.2.1 [INFO] finished frobbing dia-go-0.2.1 [INFO] frobbed toml for dia-go-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/dia-go/0.2.1/Cargo.toml [INFO] started frobbing dia-go-0.2.1 [INFO] finished frobbing dia-go-0.2.1 [INFO] frobbed toml for dia-go-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dia-go/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dia-go-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dia-go/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07ccad08ba11bb4d1628b3452ee3211ebd2071a54da6aca6b23cb4a8177a30de [INFO] running `"docker" "start" "-a" "07ccad08ba11bb4d1628b3452ee3211ebd2071a54da6aca6b23cb4a8177a30de"` [INFO] [stderr] Checking dia-go v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub const CRATE_NAME: &'static str = "Dia-go"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub const CRATE_CODE_NAME: &'static str = crate_code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | pub const CRATE_VERSION_NAME: &'static str = crate_version_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | pub const UUID: &'static str = "7f00c74f-c4b7-490f-b886-c7eb8c6cd1ee"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | pub const TAG: &'static str = concat!(crate_code_name!(), "_ebb126a0_", crate_version_name!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | / match f(self) { [INFO] [stderr] 255 | | true => self.level.store(new_level, Self::DEFAULT_ORDERING), [INFO] [stderr] 256 | | false => self.level.store(old_level, Self::DEFAULT_ORDERING), [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if f(self) { self.level.store(new_level, Self::DEFAULT_ORDERING) } else { self.level.store(old_level, Self::DEFAULT_ORDERING) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / loop { [INFO] [stderr] 319 | | match lines.next() { [INFO] [stderr] 320 | | Some(line) => match lines.peek() { [INFO] [stderr] 321 | | Some(_) => match use_stderr { [INFO] [stderr] ... | [INFO] [stderr] 343 | | }; [INFO] [stderr] 344 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(line) = lines.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:321:32 [INFO] [stderr] | [INFO] [stderr] 321 | Some(_) => match use_stderr { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 322 | | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] 323 | | false => println!("{}{}", &tag, line), [INFO] [stderr] 324 | | }, [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if use_stderr { eprintln!("{}{}", &tag, line) } else { println!("{}{}", &tag, line) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:325:29 [INFO] [stderr] | [INFO] [stderr] 325 | None => match use_stderr { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 326 | | true => { [INFO] [stderr] 327 | | match end_with_new_line { [INFO] [stderr] 328 | | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] ... | [INFO] [stderr] 339 | | }, [INFO] [stderr] 340 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 325 | None => if use_stderr { [INFO] [stderr] 326 | match end_with_new_line { [INFO] [stderr] 327 | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] 328 | false => eprint!("{}{}", &tag, line), [INFO] [stderr] 329 | }; [INFO] [stderr] 330 | just_flush_stderr(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:327:29 [INFO] [stderr] | [INFO] [stderr] 327 | / match end_with_new_line { [INFO] [stderr] 328 | | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] 329 | | false => eprint!("{}{}", &tag, line), [INFO] [stderr] 330 | | }; [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if end_with_new_line { eprintln!("{}{}", &tag, line) } else { eprint!("{}{}", &tag, line) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:334:29 [INFO] [stderr] | [INFO] [stderr] 334 | / match end_with_new_line { [INFO] [stderr] 335 | | true => println!("{}{}", &tag, line), [INFO] [stderr] 336 | | false => print!("{}{}", &tag, line), [INFO] [stderr] 337 | | }; [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if end_with_new_line { println!("{}{}", &tag, line) } else { print!("{}{}", &tag, line) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | pub const CRATE_NAME: &'static str = "Dia-go"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub const CRATE_CODE_NAME: &'static str = crate_code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | pub const CRATE_VERSION_NAME: &'static str = crate_version_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | pub const UUID: &'static str = "7f00c74f-c4b7-490f-b886-c7eb8c6cd1ee"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | pub const TAG: &'static str = concat!(crate_code_name!(), "_ebb126a0_", crate_version_name!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | / match f(self) { [INFO] [stderr] 255 | | true => self.level.store(new_level, Self::DEFAULT_ORDERING), [INFO] [stderr] 256 | | false => self.level.store(old_level, Self::DEFAULT_ORDERING), [INFO] [stderr] 257 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if f(self) { self.level.store(new_level, Self::DEFAULT_ORDERING) } else { self.level.store(old_level, Self::DEFAULT_ORDERING) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / loop { [INFO] [stderr] 319 | | match lines.next() { [INFO] [stderr] 320 | | Some(line) => match lines.peek() { [INFO] [stderr] 321 | | Some(_) => match use_stderr { [INFO] [stderr] ... | [INFO] [stderr] 343 | | }; [INFO] [stderr] 344 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(line) = lines.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:321:32 [INFO] [stderr] | [INFO] [stderr] 321 | Some(_) => match use_stderr { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 322 | | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] 323 | | false => println!("{}{}", &tag, line), [INFO] [stderr] 324 | | }, [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if use_stderr { eprintln!("{}{}", &tag, line) } else { println!("{}{}", &tag, line) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:325:29 [INFO] [stderr] | [INFO] [stderr] 325 | None => match use_stderr { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 326 | | true => { [INFO] [stderr] 327 | | match end_with_new_line { [INFO] [stderr] 328 | | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] ... | [INFO] [stderr] 339 | | }, [INFO] [stderr] 340 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 325 | None => if use_stderr { [INFO] [stderr] 326 | match end_with_new_line { [INFO] [stderr] 327 | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] 328 | false => eprint!("{}{}", &tag, line), [INFO] [stderr] 329 | }; [INFO] [stderr] 330 | just_flush_stderr(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:327:29 [INFO] [stderr] | [INFO] [stderr] 327 | / match end_with_new_line { [INFO] [stderr] 328 | | true => eprintln!("{}{}", &tag, line), [INFO] [stderr] 329 | | false => eprint!("{}{}", &tag, line), [INFO] [stderr] 330 | | }; [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if end_with_new_line { eprintln!("{}{}", &tag, line) } else { eprint!("{}{}", &tag, line) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:334:29 [INFO] [stderr] | [INFO] [stderr] 334 | / match end_with_new_line { [INFO] [stderr] 335 | | true => println!("{}{}", &tag, line), [INFO] [stderr] 336 | | false => print!("{}{}", &tag, line), [INFO] [stderr] 337 | | }; [INFO] [stderr] | |_____________________________^ help: consider using an if/else expression: `if end_with_new_line { println!("{}{}", &tag, line) } else { print!("{}{}", &tag, line) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.43s [INFO] running `"docker" "inspect" "07ccad08ba11bb4d1628b3452ee3211ebd2071a54da6aca6b23cb4a8177a30de"` [INFO] running `"docker" "rm" "-f" "07ccad08ba11bb4d1628b3452ee3211ebd2071a54da6aca6b23cb4a8177a30de"` [INFO] [stdout] 07ccad08ba11bb4d1628b3452ee3211ebd2071a54da6aca6b23cb4a8177a30de