[INFO] crate dia-assert 1.3.0 is already in cache [INFO] extracting crate dia-assert 1.3.0 into work/ex/clippy-test-run/sources/stable/reg/dia-assert/1.3.0 [INFO] extracting crate dia-assert 1.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dia-assert/1.3.0 [INFO] validating manifest of dia-assert-1.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dia-assert-1.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dia-assert-1.3.0 [INFO] finished frobbing dia-assert-1.3.0 [INFO] frobbed toml for dia-assert-1.3.0 written to work/ex/clippy-test-run/sources/stable/reg/dia-assert/1.3.0/Cargo.toml [INFO] started frobbing dia-assert-1.3.0 [INFO] finished frobbing dia-assert-1.3.0 [INFO] frobbed toml for dia-assert-1.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dia-assert/1.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dia-assert-1.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dia-assert/1.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 62ede93db842e61de483f412e1ab4c4539e4ab295a076408bf3456749b3e621d [INFO] running `"docker" "start" "-a" "62ede93db842e61de483f412e1ab4c4539e4ab295a076408bf3456749b3e621d"` [INFO] [stderr] Checking dia-assert v1.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | pub const NAME: &'static str = "Dia-assert"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | pub const CODE_NAME: &'static str = code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | pub const VERSION: &'static str = version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | pub const UUID: &'static str = "c4f0e8bd-8731-4699-9cbd-9a53cc4b3471"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | pub const TAG: &'static str = concat!(code_name!(), "::83221b81::", version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const UUID: &'static str = "3ec2df31-b5fb-49a9-b91f-de63ec69a058"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub const VERSION: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | const PATH: &'static str = "/dev/urandom"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(v) = result.checked_mul(*v as u128) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u128::from(*v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:100:32 [INFO] [stderr] | [INFO] [stderr] 100 | result.checked_mul(d.as_secs() as u128).unwrap_or_else(|| result.checked_add(d.as_secs() as u128).unwrap_or(result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(d.as_secs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:100:90 [INFO] [stderr] | [INFO] [stderr] 100 | result.checked_mul(d.as_secs() as u128).unwrap_or_else(|| result.checked_add(d.as_secs() as u128).unwrap_or(result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(d.as_secs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:31 [INFO] [stderr] | [INFO] [stderr] 105 | let value = ((value % u64::max_value() as u128) as u64).to_le(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(u64::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | Ok(file_type) => match [INFO] [stderr] | ______________________________^ [INFO] [stderr] 141 | | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] 142 | | { [INFO] [stderr] 143 | | true => match OpenOptions::new().read(true).write(true).open(PATH) { [INFO] [stderr] ... | [INFO] [stderr] 165 | | }, [INFO] [stderr] 166 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 140 | Ok(file_type) => if file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false { match OpenOptions::new().read(true).write(true).open(PATH) { [INFO] [stderr] 141 | Ok(mut file) => { [INFO] [stderr] 142 | let mut result = [0_u8; mem::size_of::()]; [INFO] [stderr] 143 | match file.read_exact(&mut result) { [INFO] [stderr] 144 | Ok(()) => { [INFO] [stderr] 145 | // Be a good friend, send something back [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_type.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_type.is_file()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:141:110 [INFO] [stderr] | [INFO] [stderr] 141 | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_type.is_socket()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | / match code.to_lowercase() == input.trim().to_lowercase() { [INFO] [stderr] 272 | | true => Ok(()), [INFO] [stderr] 273 | | false => Err(Error::new(ErrorKind::InvalidInput, format!("Assertion failed: {:?} != {:?}", code, input))), [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if code.to_lowercase() == input.trim().to_lowercase() { Ok(()) } else { Err(Error::new(ErrorKind::InvalidInput, format!("Assertion failed: {:?} != {:?}", code, input))) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | io::stdout().write(format!("To continue, type '{}': ", &rand_s).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dia-assert`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | pub const NAME: &'static str = "Dia-assert"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | pub const CODE_NAME: &'static str = code_name!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | pub const VERSION: &'static str = version!(); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | pub const UUID: &'static str = "c4f0e8bd-8731-4699-9cbd-9a53cc4b3471"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | pub const TAG: &'static str = concat!(code_name!(), "::83221b81::", version!()); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const UUID: &'static str = "3ec2df31-b5fb-49a9-b91f-de63ec69a058"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/__.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub const VERSION: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | const PATH: &'static str = "/dev/urandom"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(v) = result.checked_mul(*v as u128) { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u128::from(*v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:100:32 [INFO] [stderr] | [INFO] [stderr] 100 | result.checked_mul(d.as_secs() as u128).unwrap_or_else(|| result.checked_add(d.as_secs() as u128).unwrap_or(result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(d.as_secs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:100:90 [INFO] [stderr] | [INFO] [stderr] 100 | result.checked_mul(d.as_secs() as u128).unwrap_or_else(|| result.checked_add(d.as_secs() as u128).unwrap_or(result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(d.as_secs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:105:31 [INFO] [stderr] | [INFO] [stderr] 105 | let value = ((value % u64::max_value() as u128) as u64).to_le(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(u64::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:140:30 [INFO] [stderr] | [INFO] [stderr] 140 | Ok(file_type) => match [INFO] [stderr] | ______________________________^ [INFO] [stderr] 141 | | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] 142 | | { [INFO] [stderr] 143 | | true => match OpenOptions::new().read(true).write(true).open(PATH) { [INFO] [stderr] ... | [INFO] [stderr] 165 | | }, [INFO] [stderr] 166 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 140 | Ok(file_type) => if file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false { match OpenOptions::new().read(true).write(true).open(PATH) { [INFO] [stderr] 141 | Ok(mut file) => { [INFO] [stderr] 142 | let mut result = [0_u8; mem::size_of::()]; [INFO] [stderr] 143 | match file.read_exact(&mut result) { [INFO] [stderr] 144 | Ok(()) => { [INFO] [stderr] 145 | // Be a good friend, send something back [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_type.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_type.is_file()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:141:110 [INFO] [stderr] | [INFO] [stderr] 141 | file_type.is_dir() == false && file_type.is_file() == false && file_type.is_char_device() && file_type.is_socket() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!file_type.is_socket()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | / match code.to_lowercase() == input.trim().to_lowercase() { [INFO] [stderr] 272 | | true => Ok(()), [INFO] [stderr] 273 | | false => Err(Error::new(ErrorKind::InvalidInput, format!("Assertion failed: {:?} != {:?}", code, input))), [INFO] [stderr] 274 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if code.to_lowercase() == input.trim().to_lowercase() { Ok(()) } else { Err(Error::new(ErrorKind::InvalidInput, format!("Assertion failed: {:?} != {:?}", code, input))) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | io::stdout().write(format!("To continue, type '{}': ", &rand_s).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dia-assert`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "62ede93db842e61de483f412e1ab4c4539e4ab295a076408bf3456749b3e621d"` [INFO] running `"docker" "rm" "-f" "62ede93db842e61de483f412e1ab4c4539e4ab295a076408bf3456749b3e621d"` [INFO] [stdout] 62ede93db842e61de483f412e1ab4c4539e4ab295a076408bf3456749b3e621d