[INFO] crate dht 0.0.6 is already in cache [INFO] extracting crate dht 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/dht/0.0.6 [INFO] extracting crate dht 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dht/0.0.6 [INFO] validating manifest of dht-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dht-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dht-0.0.6 [INFO] finished frobbing dht-0.0.6 [INFO] frobbed toml for dht-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/dht/0.0.6/Cargo.toml [INFO] started frobbing dht-0.0.6 [INFO] finished frobbing dht-0.0.6 [INFO] frobbed toml for dht-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dht/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dht-0.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dht/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cca460a19a0113f24e08d9e1111eddd3f0d4857aeee2c306ead18be5422c47bc [INFO] running `"docker" "start" "-a" "cca460a19a0113f24e08d9e1111eddd3f0d4857aeee2c306ead18be5422c47bc"` [INFO] [stderr] Checking dht v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base.rs:202:38 [INFO] [stderr] | [INFO] [stderr] 202 | Ok(Node { address: addr, id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/knodetable.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | this_id: this_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `this_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/knodetable.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | hash_size: hash_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | node_id: node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/base.rs:202:38 [INFO] [stderr] | [INFO] [stderr] 202 | Ok(Node { address: addr, id: id }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/knodetable.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | this_id: this_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `this_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/knodetable.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | hash_size: hash_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | handler: handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | node_id: node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/service.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/service.rs:157:19 [INFO] [stderr] | [INFO] [stderr] 157 | let res = match data.get(&id) { [INFO] [stderr] | ___________________^ [INFO] [stderr] 158 | | Some(value) => FindResult::Value(value.clone()), [INFO] [stderr] 159 | | None => FindResult::ClosestNodes(table.find(&id, MAX_NODE_COUNT)) [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/service.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/service.rs:157:19 [INFO] [stderr] | [INFO] [stderr] 157 | let res = match data.get(&id) { [INFO] [stderr] | ___________________^ [INFO] [stderr] 158 | | Some(value) => FindResult::Value(value.clone()), [INFO] [stderr] 159 | | None => FindResult::ClosestNodes(table.find(&id, MAX_NODE_COUNT)) [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | rng.fill_bytes(&mut res[1..nb_full_digits+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=nb_full_digits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/knodetable.rs:160:37 [INFO] [stderr] | [INFO] [stderr] 160 | let mut data_copy: Vec<_> = self.data.iter().map(|n| n.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.data.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/knodetable.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | new_data.extend(self.data.iter() [INFO] [stderr] | _________________________^ [INFO] [stderr] 176 | | .filter(|x| x.id != node.id) [INFO] [stderr] 177 | | .map(|x| x.clone())); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 175 | new_data.extend(self.data.iter() [INFO] [stderr] 176 | .filter(|x| x.id != node.id).cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | rng.fill_bytes(&mut res[1..nb_full_digits+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=nb_full_digits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/knodetable.rs:160:37 [INFO] [stderr] | [INFO] [stderr] 160 | let mut data_copy: Vec<_> = self.data.iter().map(|n| n.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.data.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/knodetable.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | new_data.extend(self.data.iter() [INFO] [stderr] | _________________________^ [INFO] [stderr] 176 | | .filter(|x| x.id != node.id) [INFO] [stderr] 177 | | .map(|x| x.clone())); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 175 | new_data.extend(self.data.iter() [INFO] [stderr] 176 | .filter(|x| x.id != node.id).cloned()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/knodetable.rs:207:86 [INFO] [stderr] | [INFO] [stderr] 207 | fn assert_node_list_eq(expected: &[&Node], actual: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Node]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/service.rs:254:39 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(test::make_id(43), result.get(0).unwrap().id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/service.rs:274:39 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(test::make_id(43), result.get(0).unwrap().id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/service.rs:287:39 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(test::make_id(43), result.get(0).unwrap().id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.59s [INFO] running `"docker" "inspect" "cca460a19a0113f24e08d9e1111eddd3f0d4857aeee2c306ead18be5422c47bc"` [INFO] running `"docker" "rm" "-f" "cca460a19a0113f24e08d9e1111eddd3f0d4857aeee2c306ead18be5422c47bc"` [INFO] [stdout] cca460a19a0113f24e08d9e1111eddd3f0d4857aeee2c306ead18be5422c47bc