[INFO] crate dhl 0.1.2 is already in cache
[INFO] extracting crate dhl 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/dhl/0.1.2
[INFO] extracting crate dhl 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dhl/0.1.2
[INFO] validating manifest of dhl-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dhl-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dhl-0.1.2
[INFO] finished frobbing dhl-0.1.2
[INFO] frobbed toml for dhl-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/dhl/0.1.2/Cargo.toml
[INFO] started frobbing dhl-0.1.2
[INFO] finished frobbing dhl-0.1.2
[INFO] frobbed toml for dhl-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dhl/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dhl-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dhl/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0c6329828c6058130190644644aa1194ac10ff6cef5c050f1b587cbd58628032
[INFO] running `"docker" "start" "-a" "0c6329828c6058130190644644aa1194ac10ff6cef5c050f1b587cbd58628032"`
[INFO] [stderr]    Compiling dhl v0.1.2 (/opt/crater/workdir)
[INFO] [stderr]     Checking dhltest v1.0.0
[INFO] [stderr]     Checking dhltest-dash v1.0.0
[INFO] [stderr]     Checking dhltest_underscore v1.0.0
[INFO] [stderr]     Checking xattr v0.2.2
[INFO] [stderr]     Checking handlebars v0.28.3
[INFO] [stderr]     Checking tar v0.4.20
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/depot.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | const DEFAULT_EXPORT: &'static str = "export.rlib";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/depot.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | const DEFAULT_EXPORT: &'static str = "export.rlib";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/manifest.rs:443:24
[INFO] [stderr]     |
[INFO] [stderr] 443 |     const MANIFEST_1: &'static str = r#"
[INFO] [stderr]     |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/depot.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | / quick_error! {
[INFO] [stderr] 20 | |     #[derive(Debug)]
[INFO] [stderr] 21 | |     pub enum DepotError {
[INFO] [stderr] 22 | |         FileError(crate_name: String, source: FileData, err: io::Error) {
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |     }
[INFO] [stderr] 54 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]   --> src/depot.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | / quick_error! {
[INFO] [stderr] 20 | |     #[derive(Debug)]
[INFO] [stderr] 21 | |     pub enum DepotError {
[INFO] [stderr] 22 | |         FileError(crate_name: String, source: FileData, err: io::Error) {
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |     }
[INFO] [stderr] 54 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `depot::Depot`
[INFO] [stderr]    --> src/depot.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 | /     pub fn new() -> Self {
[INFO] [stderr] 118 | |         Depot {
[INFO] [stderr] 119 | |             #[cfg(feature = "reqwest")]
[INFO] [stderr] 120 | |             http_client: HttpClient::new().map_err(Arc::new),
[INFO] [stderr] 121 | |         }
[INFO] [stderr] 122 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 116 | impl Default for depot::Depot {
[INFO] [stderr] 117 |     fn default() -> Self {
[INFO] [stderr] 118 |         Self::new()
[INFO] [stderr] 119 |     }
[INFO] [stderr] 120 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/manifest.rs:41:1
[INFO] [stderr]    |
[INFO] [stderr] 41 | / quick_error! {
[INFO] [stderr] 42 | |     #[derive(Debug)]
[INFO] [stderr] 43 | |     pub enum ManifestInspectionError {
[INFO] [stderr] 44 | |         TemplateGeneration(err: TemplateGenerationError) {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |     }
[INFO] [stderr] 65 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]   --> src/manifest.rs:41:1
[INFO] [stderr]    |
[INFO] [stderr] 41 | / quick_error! {
[INFO] [stderr] 42 | |     #[derive(Debug)]
[INFO] [stderr] 43 | |     pub enum ManifestInspectionError {
[INFO] [stderr] 44 | |         TemplateGeneration(err: TemplateGenerationError) {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |     }
[INFO] [stderr] 65 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/lib.rs:37:1
[INFO] [stderr]    |
[INFO] [stderr] 37 | / quick_error! {
[INFO] [stderr] 38 | |     #[derive(Debug)]
[INFO] [stderr] 39 | |     pub enum Error {
[INFO] [stderr] 40 | |         RecipientsError(err: RecipientsError) {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |     }
[INFO] [stderr] 65 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/depot.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | / quick_error! {
[INFO] [stderr] 20 | |     #[derive(Debug)]
[INFO] [stderr] 21 | |     pub enum DepotError {
[INFO] [stderr] 22 | |         FileError(crate_name: String, source: FileData, err: io::Error) {
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |     }
[INFO] [stderr] 54 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::large_enum_variant)] on by default
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]   --> src/depot.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | / quick_error! {
[INFO] [stderr] 20 | |     #[derive(Debug)]
[INFO] [stderr] 21 | |     pub enum DepotError {
[INFO] [stderr] 22 | |         FileError(crate_name: String, source: FileData, err: io::Error) {
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |     }
[INFO] [stderr] 54 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `depot::Depot`
[INFO] [stderr]    --> src/depot.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 | /     pub fn new() -> Self {
[INFO] [stderr] 118 | |         Depot {
[INFO] [stderr] 119 | |             #[cfg(feature = "reqwest")]
[INFO] [stderr] 120 | |             http_client: HttpClient::new().map_err(Arc::new),
[INFO] [stderr] 121 | |         }
[INFO] [stderr] 122 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 116 | impl Default for depot::Depot {
[INFO] [stderr] 117 |     fn default() -> Self {
[INFO] [stderr] 118 |         Self::new()
[INFO] [stderr] 119 |     }
[INFO] [stderr] 120 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/manifest.rs:41:1
[INFO] [stderr]    |
[INFO] [stderr] 41 | / quick_error! {
[INFO] [stderr] 42 | |     #[derive(Debug)]
[INFO] [stderr] 43 | |     pub enum ManifestInspectionError {
[INFO] [stderr] 44 | |         TemplateGeneration(err: TemplateGenerationError) {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |     }
[INFO] [stderr] 65 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum
[INFO] [stderr]   --> src/manifest.rs:41:1
[INFO] [stderr]    |
[INFO] [stderr] 41 | / quick_error! {
[INFO] [stderr] 42 | |     #[derive(Debug)]
[INFO] [stderr] 43 | |     pub enum ManifestInspectionError {
[INFO] [stderr] 44 | |         TemplateGeneration(err: TemplateGenerationError) {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |     }
[INFO] [stderr] 65 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/template.rs:130:38
[INFO] [stderr]     |
[INFO] [stderr] 130 |         assert_eq!(t.render("", Some("10".into())).unwrap(), "");
[INFO] [stderr]     |                                      ^^^^^^^^^^^ help: consider removing `.into()`: `"10"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/template.rs:133:41
[INFO] [stderr]     |
[INFO] [stderr] 133 |         assert_eq!(t.render("foo", Some("10".into())).unwrap(), "foo");
[INFO] [stderr]     |                                         ^^^^^^^^^^^ help: consider removing `.into()`: `"10"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/template.rs:136:49
[INFO] [stderr]     |
[INFO] [stderr] 136 |         assert_eq!(t.render("{{version}}", Some("10".into())).unwrap(), "10");
[INFO] [stderr]     |                                                 ^^^^^^^^^^^ help: consider removing `.into()`: `"10"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/template.rs:138:45
[INFO] [stderr]     |
[INFO] [stderr] 138 |             t.render("foo{{version}}", Some("10".into())).unwrap(),
[INFO] [stderr]     |                                             ^^^^^^^^^^^ help: consider removing `.into()`: `"10"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: large size difference between variants
[INFO] [stderr]   --> src/lib.rs:37:1
[INFO] [stderr]    |
[INFO] [stderr] 37 | / quick_error! {
[INFO] [stderr] 38 | |     #[derive(Debug)]
[INFO] [stderr] 39 | |     pub enum Error {
[INFO] [stderr] 40 | |         RecipientsError(err: RecipientsError) {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |     }
[INFO] [stderr] 65 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.44s
[INFO] running `"docker" "inspect" "0c6329828c6058130190644644aa1194ac10ff6cef5c050f1b587cbd58628032"`
[INFO] running `"docker" "rm" "-f" "0c6329828c6058130190644644aa1194ac10ff6cef5c050f1b587cbd58628032"`
[INFO] [stdout] 0c6329828c6058130190644644aa1194ac10ff6cef5c050f1b587cbd58628032