[INFO] crate dhcp4r 0.1.0 is already in cache
[INFO] extracting crate dhcp4r 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dhcp4r/0.1.0
[INFO] extracting crate dhcp4r 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dhcp4r/0.1.0
[INFO] validating manifest of dhcp4r-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dhcp4r-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dhcp4r-0.1.0
[INFO] finished frobbing dhcp4r-0.1.0
[INFO] frobbed toml for dhcp4r-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dhcp4r/0.1.0/Cargo.toml
[INFO] started frobbing dhcp4r-0.1.0
[INFO] finished frobbing dhcp4r-0.1.0
[INFO] frobbed toml for dhcp4r-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dhcp4r/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dhcp4r-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dhcp4r/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1b817d59436e76543cbade752102e945001490991d7e70000a5c5fbf83808b87
[INFO] running `"docker" "start" "-a" "1b817d59436e76543cbade752102e945001490991d7e70000a5c5fbf83808b87"`
[INFO] [stderr]     Checking dhcp4r v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/packet.rs:45:25
[INFO] [stderr]    |
[INFO] [stderr] 45 |                         code: code,
[INFO] [stderr]    |                         ^^^^^^^^^^ help: replace it with: `code`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/packet.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         reply: reply,
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `reply`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/packet.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 |         options: options,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `options`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             server_ip: server_ip,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_ip`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/packet.rs:45:25
[INFO] [stderr]    |
[INFO] [stderr] 45 |                         code: code,
[INFO] [stderr]    |                         ^^^^^^^^^^ help: replace it with: `code`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/packet.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         reply: reply,
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `reply`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/packet.rs:64:9
[INFO] [stderr]    |
[INFO] [stderr] 64 |         options: options,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `options`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             server_ip: server_ip,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `server_ip`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:58:16
[INFO] [stderr]    |
[INFO] [stderr] 58 |         secs: ((p[8] as u16) << 8) + p[9] as u16,
[INFO] [stderr]    |                ^^^^^^^^^^^^^ help: try: `u16::from(p[8])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:58:38
[INFO] [stderr]    |
[INFO] [stderr] 58 |         secs: ((p[8] as u16) << 8) + p[9] as u16,
[INFO] [stderr]    |                                      ^^^^^^^^^^^ help: try: `u16::from(p[9])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/packet.rs:84:16
[INFO] [stderr]    |
[INFO] [stderr] 84 |             if x.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/server.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 pos = pos + 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^ help: replace it with: `pos += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/server.rs:127:24
[INFO] [stderr]     |
[INFO] [stderr] 127 |             Some(x) => (x == &self.server_ip),
[INFO] [stderr]     |                        ^^^^^^---------------^
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: use the right value directly: `self.server_ip`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:58:16
[INFO] [stderr]    |
[INFO] [stderr] 58 |         secs: ((p[8] as u16) << 8) + p[9] as u16,
[INFO] [stderr]    |                ^^^^^^^^^^^^^ help: try: `u16::from(p[8])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/packet.rs:58:38
[INFO] [stderr]    |
[INFO] [stderr] 58 |         secs: ((p[8] as u16) << 8) + p[9] as u16,
[INFO] [stderr]    |                                      ^^^^^^^^^^^ help: try: `u16::from(p[9])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/packet.rs:84:16
[INFO] [stderr]    |
[INFO] [stderr] 84 |             if x.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/server.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 pos = pos + 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^ help: replace it with: `pos += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/server.rs:127:24
[INFO] [stderr]     |
[INFO] [stderr] 127 |             Some(x) => (x == &self.server_ip),
[INFO] [stderr]     |                        ^^^^^^---------------^
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: use the right value directly: `self.server_ip`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> examples/server.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 | /         return pos >= IP_START_NUM && pos < IP_START_NUM + LEASE_NUM &&
[INFO] [stderr] 119 | |                match self.leases.get(&pos) {
[INFO] [stderr] 120 | |             Some(x) => x.0 == *chaddr && Instant::now().gt(&x.1),
[INFO] [stderr] 121 | |             None => true,
[INFO] [stderr] 122 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 118 |         pos >= IP_START_NUM && pos < IP_START_NUM + LEASE_NUM &&
[INFO] [stderr] 119 |                match self.leases.get(&pos) {
[INFO] [stderr] 120 |             Some(x) => x.0 == *chaddr && Instant::now().gt(&x.1),
[INFO] [stderr] 121 |             None => true,
[INFO] [stderr] 122 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> examples/server.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> examples/monitor.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 | /         match msg_type {
[INFO] [stderr] 16 | |             dhcp4r::REQUEST => {
[INFO] [stderr] 17 | |                 let req_ip = match in_packet.option(options::REQUESTED_IP_ADDRESS) {
[INFO] [stderr] 18 | |                     None => in_packet.ciaddr,
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |             _ => {}
[INFO] [stderr] 31 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 15 |         if let dhcp4r::REQUEST = msg_type {
[INFO] [stderr] 16 |     let req_ip = match in_packet.option(options::REQUESTED_IP_ADDRESS) {
[INFO] [stderr] 17 |         None => in_packet.ciaddr,
[INFO] [stderr] 18 |         Some(x) => {
[INFO] [stderr] 19 |             if x.len() != 4 {
[INFO] [stderr] 20 |                 return;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> examples/server.rs:31:39
[INFO] [stderr]    |
[INFO] [stderr] 31 |         lease_duration: Duration::new(LEASE_DURATION_SECS as u64, 0),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LEASE_DURATION_SECS)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> examples/server.rs:65:58
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     if self.available(&in_packet.chaddr, IP_START_NUM + &self.last_lease) {
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^----------------
[INFO] [stderr]    |                                                                         |
[INFO] [stderr]    |                                                                         help: use the right value directly: `self.last_lease`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> examples/server.rs:69:42
[INFO] [stderr]    |
[INFO] [stderr] 69 |                               u32_bytes!(IP_START_NUM + &self.last_lease));
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^^^----------------
[INFO] [stderr]    |                                                         |
[INFO] [stderr]    |                                                         help: use the right value directly: `self.last_lease`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> examples/server.rs:117:33
[INFO] [stderr]     |
[INFO] [stderr] 117 |     fn available(&self, chaddr: &[u8; 6], pos: u32) -> bool {
[INFO] [stderr]     |                                 ^^^^^^^^ help: consider passing by value instead: `[u8; 6]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> examples/server.rs:125:37
[INFO] [stderr]     |
[INFO] [stderr] 125 |     fn current_lease(&self, chaddr: &[u8; 6]) -> Option<u32> {
[INFO] [stderr]     |                                     ^^^^^^^^ help: consider passing by value instead: `[u8; 6]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.95s
[INFO] running `"docker" "inspect" "1b817d59436e76543cbade752102e945001490991d7e70000a5c5fbf83808b87"`
[INFO] running `"docker" "rm" "-f" "1b817d59436e76543cbade752102e945001490991d7e70000a5c5fbf83808b87"`
[INFO] [stdout] 1b817d59436e76543cbade752102e945001490991d7e70000a5c5fbf83808b87