[INFO] crate devp2p-secp256k1 0.5.6 is already in cache [INFO] extracting crate devp2p-secp256k1 0.5.6 into work/ex/clippy-test-run/sources/stable/reg/devp2p-secp256k1/0.5.6 [INFO] extracting crate devp2p-secp256k1 0.5.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/devp2p-secp256k1/0.5.6 [INFO] validating manifest of devp2p-secp256k1-0.5.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of devp2p-secp256k1-0.5.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing devp2p-secp256k1-0.5.6 [INFO] finished frobbing devp2p-secp256k1-0.5.6 [INFO] frobbed toml for devp2p-secp256k1-0.5.6 written to work/ex/clippy-test-run/sources/stable/reg/devp2p-secp256k1/0.5.6/Cargo.toml [INFO] started frobbing devp2p-secp256k1-0.5.6 [INFO] finished frobbing devp2p-secp256k1-0.5.6 [INFO] frobbed toml for devp2p-secp256k1-0.5.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/devp2p-secp256k1/0.5.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting devp2p-secp256k1-0.5.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/devp2p-secp256k1/0.5.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cf4bde02a8628ea86d3a0d74e9ef066943ffc6c5f74751d8b84dee67e9aea2f [INFO] running `"docker" "start" "-a" "2cf4bde02a8628ea86d3a0d74e9ef066943ffc6c5f74751d8b84dee67e9aea2f"` [INFO] [stderr] Compiling devp2p-secp256k1 v0.5.6 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Config': gcc::Config has been renamed to gcc::Build [INFO] [stderr] --> build.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | fn setup_android(config: &mut gcc::Config) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Config': gcc::Config has been renamed to gcc::Build [INFO] [stderr] --> build.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | let mut base_config = gcc::Config::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | let mut base_config = gcc::Config::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: In file included from depend/secp256k1/src/secp256k1.c:13:0, [INFO] [stderr] warning: from depend/secp256k1/src/ext.c:8: [INFO] [stderr] warning: depend/secp256k1/src/group_impl.h:636:12: warning: 'secp256k1_gej_has_quad_y_var' defined but not used [-Wunused-function] [INFO] [stderr] warning: static int secp256k1_gej_has_quad_y_var(const secp256k1_gej *a) { [INFO] [stderr] warning: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/group_impl.h:217:12: warning: 'secp256k1_gej_is_valid_var' defined but not used [-Wunused-function] [INFO] [stderr] warning: static int secp256k1_gej_is_valid_var(const secp256k1_gej *a) { [INFO] [stderr] warning: ^~~~~~~~~~~~~~~~~~~~~~~~~~ [INFO] [stderr] warning: In file included from depend/secp256k1/src/field_impl.h:17:0, [INFO] [stderr] warning: from depend/secp256k1/src/secp256k1.c:11, [INFO] [stderr] warning: from depend/secp256k1/src/ext.c:8: [INFO] [stderr] warning: depend/secp256k1/src/field_10x26_impl.h:42:13: warning: 'secp256k1_fe_verify' defined but not used [-Wunused-function] [INFO] [stderr] warning: static void secp256k1_fe_verify(const secp256k1_fe *a) { [INFO] [stderr] warning: ^~~~~~~~~~~~~~~~~~~ [INFO] [stderr] warning: In file included from depend/secp256k1/src/ext.c:8:0: [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_pubkey_parse': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:154:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'input' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:156:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(input != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_pubkey_serialize': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'output' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:175:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(output != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'outputlen' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:171:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(outputlen != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:177:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_signature_parse_der': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:216:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'input' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:217:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(input != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_signature_parse_compact': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:234:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'input64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:235:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(input64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_signature_serialize_der': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'output' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:253:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(output != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'outputlen' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:254:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(outputlen != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:255:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_signature_serialize_compact': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'output64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:265:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(output64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:266:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_signature_normalize': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sigin' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:279:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sigin != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_verify': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:300:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:299:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:301:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_sign': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'signature' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:353:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(signature != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:352:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:354:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(seckey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_seckey_verify': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:396:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(seckey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_pubkey_create': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:411:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:414:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(seckey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_privkey_tweak_add': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:433:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(seckey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:434:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(tweak != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_pubkey_tweak_add': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:457:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:458:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(tweak != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_privkey_tweak_mul': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:480:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(seckey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:481:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(tweak != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_pubkey_tweak_mul': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:503:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'tweak' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:504:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(tweak != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ec_pubkey_combine': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubnonce' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:532:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubnonce != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubnonces' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:535:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubnonces != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdh': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'result' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/ecdh/main_impl.h:19:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(result != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'point' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/ecdh/main_impl.h:20:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(point != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'scalar' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/ecdh/main_impl.h:21:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(scalar != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_schnorr_sign': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:31:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:30:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:32:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(seckey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_schnorr_verify': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:66:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:65:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:67:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_schnorr_recover': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:80:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:79:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:78:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_schnorr_generate_nonce_pair': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubnonce' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:102:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubnonce != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'privnonce32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:103:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(privnonce32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_schnorr_partial_sign': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:140:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:139:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sec32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:141:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sec32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubnonce_others' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:143:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubnonce_others != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'secnonce32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:142:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(secnonce32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_schnorr_partial_combine': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:158:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig64sin' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/schnorr/main_impl.h:160:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig64sin != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_recoverable_signature_parse_compact': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:44:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'input64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:45:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(input64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_recoverable_signature_serialize_compact': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'output64' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:64:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(output64 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'recid' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:66:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(recid != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:65:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_recoverable_signature_convert': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sig' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:79:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sig != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'sigin' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:80:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(sigin != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_sign_recoverable': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'signature' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:132:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(signature != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:131:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'seckey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:133:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(seckey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/ext.c: In function 'secp256k1_ecdsa_recover': [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'pubkey' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:179:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(pubkey != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'signature' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:178:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(signature != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: depend/secp256k1/src/secp256k1.c:22:8: warning: nonnull argument 'msg32' compared to NULL [-Wnonnull-compare] [INFO] [stderr] warning: if (EXPECT(!(cond), 0)) { \ [INFO] [stderr] warning: ^ [INFO] [stderr] warning: depend/secp256k1/src/modules/recovery/main_impl.h:177:5: note: in expansion of macro 'ARG_CHECK' [INFO] [stderr] warning: ARG_CHECK(msg32 != NULL); [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:418:74 [INFO] [stderr] | [INFO] [stderr] 418 | Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(flag) }, caps: caps } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `caps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:418:74 [INFO] [stderr] | [INFO] [stderr] 418 | Secp256k1 { ctx: unsafe { ffi::secp256k1_context_create(flag) }, caps: caps } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `caps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/key.rs:486:31 [INFO] [stderr] | [INFO] [stderr] 486 | use std::hash::{Hash, SipHasher, Hasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/key.rs:490:25 [INFO] [stderr] | [INFO] [stderr] 490 | let mut s = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)` [INFO] [stderr] --> src/ffi.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:27:44 [INFO] [stderr] | [INFO] [stderr] 27 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)` [INFO] [stderr] --> src/ffi.rs:31:48 [INFO] [stderr] | [INFO] [stderr] 31 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey` [INFO] [stderr] --> src/ffi.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn new() -> PublicKey { PublicKey([0; 64]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | impl Default for ffi::PublicKey { [INFO] [stderr] 64 | fn default() -> Self { [INFO] [stderr] 65 | Self::new() [INFO] [stderr] 66 | } [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature` [INFO] [stderr] --> src/ffi.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn new() -> Signature { Signature([0; 64]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | impl Default for ffi::Signature { [INFO] [stderr] 89 | fn default() -> Self { [INFO] [stderr] 90 | Self::new() [INFO] [stderr] 91 | } [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature` [INFO] [stderr] --> src/ffi.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | impl Default for ffi::RecoverableSignature { [INFO] [stderr] 96 | fn default() -> Self { [INFO] [stderr] 97 | Self::new() [INFO] [stderr] 98 | } [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret` [INFO] [stderr] --> src/ffi.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn new() -> SharedSecret { SharedSecret([0; 32]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/key.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | let original = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `key::PublicKey` [INFO] [stderr] --> src/key.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn new() -> PublicKey { [INFO] [stderr] 152 | | PublicKey(ffi::PublicKey::new()) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 148 | impl Default for key::PublicKey { [INFO] [stderr] 149 | fn default() -> Self { [INFO] [stderr] 150 | Self::new() [INFO] [stderr] 151 | } [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn to_i32(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1` [INFO] [stderr] --> src/lib.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | / pub fn new() -> Secp256k1 { [INFO] [stderr] 407 | | Secp256k1::with_caps(ContextFlag::Full) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 403 | impl Default for Secp256k1 { [INFO] [stderr] 404 | fn default() -> Self { [INFO] [stderr] 405 | Self::new() [INFO] [stderr] 406 | } [INFO] [stderr] 407 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/key.rs:490:25 [INFO] [stderr] | [INFO] [stderr] 490 | let mut s = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 0)` [INFO] [stderr] --> src/ffi.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:25:42 [INFO] [stderr] | [INFO] [stderr] 25 | pub const SECP256K1_START_NONE: c_uint = (1 << 0) | 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:27:44 [INFO] [stderr] | [INFO] [stderr] 27 | pub const SECP256K1_START_VERIFY: c_uint = (1 << 0) | (1 << 8); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | pub const SECP256K1_START_SIGN: c_uint = (1 << 0) | (1 << 9); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(1 << 1)` [INFO] [stderr] --> src/ffi.rs:31:48 [INFO] [stderr] | [INFO] [stderr] 31 | pub const SECP256K1_SER_UNCOMPRESSED: c_uint = (1 << 1) | 0; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::PublicKey` [INFO] [stderr] --> src/ffi.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn new() -> PublicKey { PublicKey([0; 64]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 63 | impl Default for ffi::PublicKey { [INFO] [stderr] 64 | fn default() -> Self { [INFO] [stderr] 65 | Self::new() [INFO] [stderr] 66 | } [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::Signature` [INFO] [stderr] --> src/ffi.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn new() -> Signature { Signature([0; 64]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | impl Default for ffi::Signature { [INFO] [stderr] 89 | fn default() -> Self { [INFO] [stderr] 90 | Self::new() [INFO] [stderr] 91 | } [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ffi::RecoverableSignature` [INFO] [stderr] --> src/ffi.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new() -> RecoverableSignature { RecoverableSignature([0; 65]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | impl Default for ffi::RecoverableSignature { [INFO] [stderr] 96 | fn default() -> Self { [INFO] [stderr] 97 | Self::new() [INFO] [stderr] 98 | } [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ffi::SharedSecret` [INFO] [stderr] --> src/ffi.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn new() -> SharedSecret { SharedSecret([0; 32]) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 104 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/key.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | let original = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `key::PublicKey` [INFO] [stderr] --> src/key.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn new() -> PublicKey { [INFO] [stderr] 152 | | PublicKey(ffi::PublicKey::new()) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 148 | impl Default for key::PublicKey { [INFO] [stderr] 149 | fn default() -> Self { [INFO] [stderr] 150 | Self::new() [INFO] [stderr] 151 | } [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:19 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn to_i32(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Secp256k1` [INFO] [stderr] --> src/lib.rs:406:5 [INFO] [stderr] | [INFO] [stderr] 406 | / pub fn new() -> Secp256k1 { [INFO] [stderr] 407 | | Secp256k1::with_caps(ContextFlag::Full) [INFO] [stderr] 408 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 403 | impl Default for Secp256k1 { [INFO] [stderr] 404 | fn default() -> Self { [INFO] [stderr] 405 | Self::new() [INFO] [stderr] 406 | } [INFO] [stderr] 407 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/lib.rs:551:5 [INFO] [stderr] | [INFO] [stderr] 551 | / fn capabilities() { [INFO] [stderr] 552 | | let none = Secp256k1::with_caps(ContextFlag::None); [INFO] [stderr] 553 | | let sign = Secp256k1::with_caps(ContextFlag::SignOnly); [INFO] [stderr] 554 | | let vrfy = Secp256k1::with_caps(ContextFlag::VerifyOnly); [INFO] [stderr] ... | [INFO] [stderr] 603 | | assert_eq!(pk, new_pk); [INFO] [stderr] 604 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:609:25 [INFO] [stderr] | [INFO] [stderr] 609 | assert_eq!(one, one.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `one` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.14s [INFO] running `"docker" "inspect" "2cf4bde02a8628ea86d3a0d74e9ef066943ffc6c5f74751d8b84dee67e9aea2f"` [INFO] running `"docker" "rm" "-f" "2cf4bde02a8628ea86d3a0d74e9ef066943ffc6c5f74751d8b84dee67e9aea2f"` [INFO] [stdout] 2cf4bde02a8628ea86d3a0d74e9ef066943ffc6c5f74751d8b84dee67e9aea2f