[INFO] crate devicemapper 0.26.1 is already in cache [INFO] extracting crate devicemapper 0.26.1 into work/ex/clippy-test-run/sources/stable/reg/devicemapper/0.26.1 [INFO] extracting crate devicemapper 0.26.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/devicemapper/0.26.1 [INFO] validating manifest of devicemapper-0.26.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of devicemapper-0.26.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing devicemapper-0.26.1 [INFO] finished frobbing devicemapper-0.26.1 [INFO] frobbed toml for devicemapper-0.26.1 written to work/ex/clippy-test-run/sources/stable/reg/devicemapper/0.26.1/Cargo.toml [INFO] started frobbing devicemapper-0.26.1 [INFO] finished frobbing devicemapper-0.26.1 [INFO] frobbed toml for devicemapper-0.26.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/devicemapper/0.26.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting devicemapper-0.26.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/devicemapper/0.26.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5b3e7cd787a143d26078bd5a8fa28e42b08a726e46f6c0f757fd2a222d96da8 [INFO] running `"docker" "start" "-a" "e5b3e7cd787a143d26078bd5a8fa28e42b08a726e46f6c0f757fd2a222d96da8"` [INFO] [stderr] Checking libmount v0.1.12 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking devicemapper v0.26.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | #![allow(doc_markdown)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/types.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | #![allow(cast_lossless)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cachedev.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `decimal_literal_representation` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cachedev.rs:753:9 [INFO] [stderr] | [INFO] [stderr] 753 | #[allow(decimal_literal_representation)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::decimal_literal_representation` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:170:25 [INFO] [stderr] | [INFO] [stderr] 170 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:529:25 [INFO] [stderr] | [INFO] [stderr] 529 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:567:29 [INFO] [stderr] | [INFO] [stderr] 567 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:626:13 [INFO] [stderr] | [INFO] [stderr] 626 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | #![allow(doc_markdown)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/dm.rs:79:68 [INFO] [stderr] | [INFO] [stderr] 79 | fn hdr_set_name(hdr: &mut dmi::Struct_dm_ioctl, name: &DmName) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/dm.rs:86:68 [INFO] [stderr] | [INFO] [stderr] 86 | fn hdr_set_uuid(hdr: &mut dmi::Struct_dm_ioctl, uuid: &DmUuid) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `identity_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm_flags.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | #[allow(identity_op)] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::identity_op` [INFO] [stderr] [INFO] [stderr] warning: lint name `identity_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm_flags.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | #[allow(identity_op)] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::identity_op` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | #![allow(doc_markdown)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_lossless` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/types.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | #![allow(cast_lossless)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::cast_lossless` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cachedev.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | #[allow(too_many_arguments)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `decimal_literal_representation` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cachedev.rs:753:9 [INFO] [stderr] | [INFO] [stderr] 753 | #[allow(decimal_literal_representation)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::decimal_literal_representation` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:170:25 [INFO] [stderr] | [INFO] [stderr] 170 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:247:37 [INFO] [stderr] | [INFO] [stderr] 247 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:529:25 [INFO] [stderr] | [INFO] [stderr] 529 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_ptr_alignment` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:567:29 [INFO] [stderr] | [INFO] [stderr] 567 | #[allow(cast_ptr_alignment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_ptr_alignment` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm.rs:626:13 [INFO] [stderr] | [INFO] [stderr] 626 | #[allow(type_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lineardev.rs:334:18 [INFO] [stderr] | [INFO] [stderr] 334 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | #![allow(doc_markdown)] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/cachedev.rs:820:48 [INFO] [stderr] | [INFO] [stderr] 820 | fn test_minimal_cache_dev(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/device.rs:131:34 [INFO] [stderr] | [INFO] [stderr] 131 | let test_devt_1: dev_t = 0xabcdef1234567890; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef12_3456_7890` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/device.rs:136:32 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(dev1.major, 0xabcde678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xabcd_e678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/device.rs:137:32 [INFO] [stderr] | [INFO] [stderr] 137 | assert_eq!(dev1.minor, 0xf1234590); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf123_4590` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/device.rs:146:32 [INFO] [stderr] | [INFO] [stderr] 146 | let test_devt_1: u32 = 0x12345678; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/device.rs:157:33 [INFO] [stderr] | [INFO] [stderr] 157 | let dev2 = Device::from(0xabcdef1234567890); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xabcd_ef12_3456_7890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/dm.rs:79:68 [INFO] [stderr] | [INFO] [stderr] 79 | fn hdr_set_name(hdr: &mut dmi::Struct_dm_ioctl, name: &DmName) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/dm.rs:86:68 [INFO] [stderr] | [INFO] [stderr] 86 | fn hdr_set_uuid(hdr: &mut dmi::Struct_dm_ioctl, uuid: &DmUuid) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: lint name `identity_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm_flags.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | #[allow(identity_op)] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::identity_op` [INFO] [stderr] [INFO] [stderr] warning: lint name `identity_op` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/dm_flags.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | #[allow(identity_op)] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::identity_op` [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:498:37 [INFO] [stderr] | [INFO] [stderr] 498 | fn test_empty(_paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:510:46 [INFO] [stderr] | [INFO] [stderr] 510 | fn test_empty_table_set(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:530:40 [INFO] [stderr] | [INFO] [stderr] 530 | fn test_rename_id(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:551:37 [INFO] [stderr] | [INFO] [stderr] 551 | fn test_rename(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:576:49 [INFO] [stderr] | [INFO] [stderr] 576 | fn test_duplicate_segments(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:622:47 [INFO] [stderr] | [INFO] [stderr] 622 | fn test_several_segments(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:649:40 [INFO] [stderr] | [INFO] [stderr] 649 | fn test_same_name(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:674:43 [INFO] [stderr] | [INFO] [stderr] 674 | fn test_same_segment(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lineardev.rs:696:38 [INFO] [stderr] | [INFO] [stderr] 696 | fn test_suspend(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/thindev.rs:468:9 [INFO] [stderr] | [INFO] [stderr] 468 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/thindev.rs:463:22 [INFO] [stderr] | [INFO] [stderr] 463 | let result = enumerator [INFO] [stderr] | ______________________^ [INFO] [stderr] 464 | | .scan_devices() [INFO] [stderr] 465 | | .unwrap() [INFO] [stderr] 466 | | .find(|x| x.devnode().map_or(false, |d| dev_node_search == d)) [INFO] [stderr] 467 | | .map_or(None, |dev| Some(device_as_map(&dev))); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:472:40 [INFO] [stderr] | [INFO] [stderr] 472 | fn test_zero_size(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:497:48 [INFO] [stderr] | [INFO] [stderr] 497 | fn test_setup_without_new(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:527:36 [INFO] [stderr] | [INFO] [stderr] 527 | fn test_basic(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:589:45 [INFO] [stderr] | [INFO] [stderr] 589 | fn test_udev_userspace(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:675:39 [INFO] [stderr] | [INFO] [stderr] 675 | fn test_snapshot(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:725:41 [INFO] [stderr] | [INFO] [stderr] 725 | fn test_filesystem(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:793:45 [INFO] [stderr] | [INFO] [stderr] 793 | fn test_snapshot_usage(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thindev.rs:875:46 [INFO] [stderr] | [INFO] [stderr] 875 | fn test_thindev_destroy(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thinpooldev.rs:706:45 [INFO] [stderr] | [INFO] [stderr] 706 | fn test_minimum_values(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thinpooldev.rs:744:50 [INFO] [stderr] | [INFO] [stderr] 744 | fn test_low_data_block_size(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thinpooldev.rs:793:39 [INFO] [stderr] | [INFO] [stderr] 793 | fn test_set_data(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thinpooldev.rs:833:39 [INFO] [stderr] | [INFO] [stderr] 833 | fn test_set_meta(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/thinpooldev.rs:869:38 [INFO] [stderr] | [INFO] [stderr] 869 | fn test_suspend(paths: &[&Path]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/loopbacked.rs:119:46 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn test_with_spec(count: u8, test: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lineardev.rs:334:18 [INFO] [stderr] | [INFO] [stderr] 334 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:511:17 [INFO] [stderr] | [INFO] [stderr] 511 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:531:17 [INFO] [stderr] | [INFO] [stderr] 531 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:552:17 [INFO] [stderr] | [INFO] [stderr] 552 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:577:17 [INFO] [stderr] | [INFO] [stderr] 577 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:623:17 [INFO] [stderr] | [INFO] [stderr] 623 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:650:17 [INFO] [stderr] | [INFO] [stderr] 650 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:675:17 [INFO] [stderr] | [INFO] [stderr] 675 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lineardev.rs:697:17 [INFO] [stderr] | [INFO] [stderr] 697 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/thindev.rs:463:22 [INFO] [stderr] | [INFO] [stderr] 463 | let result = enumerator [INFO] [stderr] | ______________________^ [INFO] [stderr] 464 | | .scan_devices() [INFO] [stderr] 465 | | .unwrap() [INFO] [stderr] 466 | | .find(|x| x.devnode().map_or(false, |d| dev_node_search == d)) [INFO] [stderr] 467 | | .map_or(None, |dev| Some(device_as_map(&dev))); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 463 | let result = enumerator [INFO] [stderr] 464 | .scan_devices() [INFO] [stderr] 465 | .unwrap() [INFO] [stderr] 466 | .find(|x| x.devnode().map_or(false, |d| dev_node_search == d)).and_then(|dev| Some(device_as_map(&dev))); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thindev.rs:473:17 [INFO] [stderr] | [INFO] [stderr] 473 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thindev.rs:498:17 [INFO] [stderr] | [INFO] [stderr] 498 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thindev.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thindev.rs:676:17 [INFO] [stderr] | [INFO] [stderr] 676 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/thindev.rs:726:17 [INFO] [stderr] | [INFO] [stderr] 726 | assert!(paths.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/thindev.rs:794:17 [INFO] [stderr] | [INFO] [stderr] 794 | assert!(paths.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thindev.rs:876:17 [INFO] [stderr] | [INFO] [stderr] 876 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thinpooldev.rs:707:17 [INFO] [stderr] | [INFO] [stderr] 707 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thinpooldev.rs:745:17 [INFO] [stderr] | [INFO] [stderr] 745 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/thinpooldev.rs:870:17 [INFO] [stderr] | [INFO] [stderr] 870 | assert!(paths.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/test_lib.rs:174:28 [INFO] [stderr] | [INFO] [stderr] 174 | for mount_point in parser [INFO] [stderr] | ____________________________^ [INFO] [stderr] 175 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.81s [INFO] running `"docker" "inspect" "e5b3e7cd787a143d26078bd5a8fa28e42b08a726e46f6c0f757fd2a222d96da8"` [INFO] running `"docker" "rm" "-f" "e5b3e7cd787a143d26078bd5a8fa28e42b08a726e46f6c0f757fd2a222d96da8"` [INFO] [stdout] e5b3e7cd787a143d26078bd5a8fa28e42b08a726e46f6c0f757fd2a222d96da8