[INFO] crate device_tree 1.1.0 is already in cache [INFO] extracting crate device_tree 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/device_tree/1.1.0 [INFO] extracting crate device_tree 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/device_tree/1.1.0 [INFO] validating manifest of device_tree-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of device_tree-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing device_tree-1.1.0 [INFO] finished frobbing device_tree-1.1.0 [INFO] frobbed toml for device_tree-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/device_tree/1.1.0/Cargo.toml [INFO] started frobbing device_tree-1.1.0 [INFO] finished frobbing device_tree-1.1.0 [INFO] frobbed toml for device_tree-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/device_tree/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting device_tree-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/device_tree/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d133e8c21bbd1490280c2f701bfcab90a4c763c98baffc6f5d34cc12a2aed4f [INFO] running `"docker" "start" "-a" "0d133e8c21bbd1490280c2f701bfcab90a4c763c98baffc6f5d34cc12a2aed4f"` [INFO] [stderr] Checking device_tree v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | boot_cpuid_phys: boot_cpuid_phys, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `boot_cpuid_phys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | reserved: reserved, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | props: props, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | boot_cpuid_phys: boot_cpuid_phys, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `boot_cpuid_phys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | reserved: reserved, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `reserved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | props: props, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | const MAGIC_NUMBER : u32 = 0xd00dfeed; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd00d_feed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | const OF_DT_BEGIN_NODE : u32 = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | const OF_DT_END_NODE : u32 = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | const OF_DT_PROP : u32 = 0x00000003; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if ! (pos+4 <= self.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pos+4 > self.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | (self[pos] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | | (self[pos+1] as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | | (self[pos+2] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | | (self[pos+3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if ! (pos+8 <= self.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pos+8 > self.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | (self[pos] as u64) << 56 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | | (self[pos+1] as u64) << 48 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:46:15 [INFO] [stderr] | [INFO] [stderr] 46 | | (self[pos+2] as u64) << 40 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | | (self[pos+3] as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:48:15 [INFO] [stderr] | [INFO] [stderr] 48 | | (self[pos+4] as u64) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:49:15 [INFO] [stderr] | [INFO] [stderr] 49 | | (self[pos+5] as u64) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | | (self[pos+6] as u64) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | | (self[pos+7] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if ! (end < self.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `end >= self.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:290:16 [INFO] [stderr] | [INFO] [stderr] 290 | if let Some(_) = self.prop_raw(name) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 291 | | true [INFO] [stderr] 292 | | } else { [INFO] [stderr] 293 | | false [INFO] [stderr] 294 | | } [INFO] [stderr] | |_________- help: try this: `if self.prop_raw(name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | const MAGIC_NUMBER : u32 = 0xd00dfeed; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd00d_feed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | const OF_DT_BEGIN_NODE : u32 = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | const OF_DT_END_NODE : u32 = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:44:32 [INFO] [stderr] | [INFO] [stderr] 44 | const OF_DT_PROP : u32 = 0x00000003; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | if ! (pos+4 <= self.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pos+4 > self.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | (self[pos] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:31:15 [INFO] [stderr] | [INFO] [stderr] 31 | | (self[pos+1] as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | | (self[pos+2] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | | (self[pos+3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self[pos+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if ! (pos+8 <= self.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pos+8 > self.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | (self[pos] as u64) << 56 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | | (self[pos+1] as u64) << 48 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:46:15 [INFO] [stderr] | [INFO] [stderr] 46 | | (self[pos+2] as u64) << 40 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:47:15 [INFO] [stderr] | [INFO] [stderr] 47 | | (self[pos+3] as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:48:15 [INFO] [stderr] | [INFO] [stderr] 48 | | (self[pos+4] as u64) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:49:15 [INFO] [stderr] | [INFO] [stderr] 49 | | (self[pos+5] as u64) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | | (self[pos+6] as u64) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:51:15 [INFO] [stderr] | [INFO] [stderr] 51 | | (self[pos+7] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self[pos+7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/util.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if ! (end < self.len()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `end >= self.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:290:16 [INFO] [stderr] | [INFO] [stderr] 290 | if let Some(_) = self.prop_raw(name) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 291 | | true [INFO] [stderr] 292 | | } else { [INFO] [stderr] 293 | | false [INFO] [stderr] 294 | | } [INFO] [stderr] | |_________- help: try this: `if self.prop_raw(name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.49s [INFO] running `"docker" "inspect" "0d133e8c21bbd1490280c2f701bfcab90a4c763c98baffc6f5d34cc12a2aed4f"` [INFO] running `"docker" "rm" "-f" "0d133e8c21bbd1490280c2f701bfcab90a4c763c98baffc6f5d34cc12a2aed4f"` [INFO] [stdout] 0d133e8c21bbd1490280c2f701bfcab90a4c763c98baffc6f5d34cc12a2aed4f