[INFO] crate dev_menu 0.25.0 is already in cache [INFO] extracting crate dev_menu 0.25.0 into work/ex/clippy-test-run/sources/stable/reg/dev_menu/0.25.0 [INFO] extracting crate dev_menu 0.25.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dev_menu/0.25.0 [INFO] validating manifest of dev_menu-0.25.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dev_menu-0.25.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dev_menu-0.25.0 [INFO] finished frobbing dev_menu-0.25.0 [INFO] frobbed toml for dev_menu-0.25.0 written to work/ex/clippy-test-run/sources/stable/reg/dev_menu/0.25.0/Cargo.toml [INFO] started frobbing dev_menu-0.25.0 [INFO] finished frobbing dev_menu-0.25.0 [INFO] frobbed toml for dev_menu-0.25.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dev_menu/0.25.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dev_menu-0.25.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dev_menu/0.25.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2159931b89d3aea178fbf59e2d7bdc7c65f9f8ff672fb1bbcd0b48883ee9a1c [INFO] running `"docker" "start" "-a" "c2159931b89d3aea178fbf59e2d7bdc7c65f9f8ff672fb1bbcd0b48883ee9a1c"` [INFO] [stderr] Compiling freetype-sys v0.7.1 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking freetype-rs v0.19.1 [INFO] [stderr] Checking gfx_text v0.23.0 [INFO] [stderr] Checking gfx_debug_draw v0.22.0 [INFO] [stderr] Checking dev_menu v0.25.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/menu_item.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/menu_item.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/menu_item.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | step_size: step_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `step_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/menu_item.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/menu_item.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/menu_item.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | step_size: step_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `step_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `menu::Menu` [INFO] [stderr] --> src/menu.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Menu { [INFO] [stderr] 21 | | Menu { [INFO] [stderr] 22 | | items: Vec::new(), [INFO] [stderr] 23 | | selected_item: 0, [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/menu_item.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &MenuItem::ActionItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] 18 | | &MenuItem::SliderItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | MenuItem::ActionItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] 18 | MenuItem::SliderItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/menu_item.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &mut MenuItem::ActionItem(ref mut item) => item.event(e, settings), [INFO] [stderr] 25 | | &mut MenuItem::SliderItem(ref mut item) => item.event(e, settings), [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | MenuItem::ActionItem(ref mut item) => item.event(e, settings), [INFO] [stderr] 25 | MenuItem::SliderItem(ref mut item) => item.event(e, settings), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `menu::Menu` [INFO] [stderr] --> src/menu.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> Menu { [INFO] [stderr] 21 | | Menu { [INFO] [stderr] 22 | | items: Vec::new(), [INFO] [stderr] 23 | | selected_item: 0, [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/menu_item.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &MenuItem::ActionItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] 18 | | &MenuItem::SliderItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | MenuItem::ActionItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] 18 | MenuItem::SliderItem(ref item) => item.draw(settings, debug_renderer, position, selected), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/menu_item.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &mut MenuItem::ActionItem(ref mut item) => item.event(e, settings), [INFO] [stderr] 25 | | &mut MenuItem::SliderItem(ref mut item) => item.event(e, settings), [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | MenuItem::ActionItem(ref mut item) => item.event(e, settings), [INFO] [stderr] 25 | MenuItem::SliderItem(ref mut item) => item.event(e, settings), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.66s [INFO] running `"docker" "inspect" "c2159931b89d3aea178fbf59e2d7bdc7c65f9f8ff672fb1bbcd0b48883ee9a1c"` [INFO] running `"docker" "rm" "-f" "c2159931b89d3aea178fbf59e2d7bdc7c65f9f8ff672fb1bbcd0b48883ee9a1c"` [INFO] [stdout] c2159931b89d3aea178fbf59e2d7bdc7c65f9f8ff672fb1bbcd0b48883ee9a1c