[INFO] crate deterministic 0.1.0 is already in cache [INFO] extracting crate deterministic 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/deterministic/0.1.0 [INFO] extracting crate deterministic 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/deterministic/0.1.0 [INFO] validating manifest of deterministic-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deterministic-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deterministic-0.1.0 [INFO] finished frobbing deterministic-0.1.0 [INFO] frobbed toml for deterministic-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/deterministic/0.1.0/Cargo.toml [INFO] started frobbing deterministic-0.1.0 [INFO] finished frobbing deterministic-0.1.0 [INFO] frobbed toml for deterministic-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/deterministic/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deterministic-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/deterministic/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4bc28cabaa1ce3f1091fa3ac7be4c5ea47f2077acd30d1b775a62c38ebafe24a [INFO] running `"docker" "start" "-a" "4bc28cabaa1ce3f1091fa3ac7be4c5ea47f2077acd30d1b775a62c38ebafe24a"` [INFO] [stderr] Checking deterministic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `file::OpenOptions` [INFO] [stderr] --> src/file.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn new() -> OpenOptions { [INFO] [stderr] 117 | | OpenOptions { [INFO] [stderr] 118 | | inner: fs::OpenOptions::new(), [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | impl Default for file::OpenOptions { [INFO] [stderr] 104 | fn default() -> Self { [INFO] [stderr] 105 | Self::new() [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | fn context<'a>() -> Arc { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/context.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(self.fill_bytes(dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a `Copy` type [INFO] [stderr] --> src/spawn.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | context::set_time(time.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `time` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::clone_on_copy)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/spawn.rs:128:28 [INFO] [stderr] | [INFO] [stderr] 128 | let child_time = spawn(|| context::now()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `context::now` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_closure)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: you should consider adding a `Default` implementation for `file::OpenOptions` [INFO] [stderr] --> src/file.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn new() -> OpenOptions { [INFO] [stderr] 117 | | OpenOptions { [INFO] [stderr] 118 | | inner: fs::OpenOptions::new(), [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | impl Default for file::OpenOptions { [INFO] [stderr] 104 | fn default() -> Self { [INFO] [stderr] 105 | Self::new() [INFO] [stderr] 106 | } [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | fn context<'a>() -> Arc { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::extra_unused_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: passing a unit value to a function [INFO] [stderr] --> src/context.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | Ok(self.fill_bytes(dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:4:24 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unit_arg)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `deterministic`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4bc28cabaa1ce3f1091fa3ac7be4c5ea47f2077acd30d1b775a62c38ebafe24a"` [INFO] running `"docker" "rm" "-f" "4bc28cabaa1ce3f1091fa3ac7be4c5ea47f2077acd30d1b775a62c38ebafe24a"` [INFO] [stdout] 4bc28cabaa1ce3f1091fa3ac7be4c5ea47f2077acd30d1b775a62c38ebafe24a