[INFO] crate destructivator 0.1.0 is already in cache [INFO] extracting crate destructivator 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/destructivator/0.1.0 [INFO] extracting crate destructivator 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/destructivator/0.1.0 [INFO] validating manifest of destructivator-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of destructivator-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing destructivator-0.1.0 [INFO] removed 0 missing tests [INFO] finished frobbing destructivator-0.1.0 [INFO] frobbed toml for destructivator-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/destructivator/0.1.0/Cargo.toml [INFO] started frobbing destructivator-0.1.0 [INFO] removed 0 missing tests [INFO] finished frobbing destructivator-0.1.0 [INFO] frobbed toml for destructivator-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/destructivator/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting destructivator-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/destructivator/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 17c5ef03a98111619590927eb1e548136499d8ccba09838cf8da084ceb34d00f [INFO] running `"docker" "start" "-a" "17c5ef03a98111619590927eb1e548136499d8ccba09838cf8da084ceb34d00f"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/branch_all_new_test.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking globset v0.2.1 [INFO] [stderr] Checking config v0.7.1 [INFO] [stderr] Compiling git2 v0.6.11 [INFO] [stderr] Checking ignore v0.3.1 [INFO] [stderr] Compiling destructivator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> build.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | let root_dir = env::home_dir().unwrap().join(&format!(".{}", pkg_name)); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/git.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | println!("{}","HEAD identical to master. Exiting."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/git.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | println!("{}","HEAD identical to master. Exiting."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | pub const IGNORE_FILE: &'static str = "destructivator.ignore"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | pub const MAPPING_FILE: &'static str = "type-mapping.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub const NAME: &'static str = "destructivator"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/forcedotcom.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | const DEFAULT_API_VERSION: &'static str = "39.0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/git.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | let root_dir = env::home_dir().unwrap().join(&format!(".{}", NAME)); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/git.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | let root_dir = env::home_dir().unwrap().join(&format!(".{}", NAME)); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | pub const IGNORE_FILE: &'static str = "destructivator.ignore"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | pub const MAPPING_FILE: &'static str = "type-mapping.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:7:18 [INFO] [stderr] | [INFO] [stderr] 7 | pub const NAME: &'static str = "destructivator"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/forcedotcom.rs:4:29 [INFO] [stderr] | [INFO] [stderr] 4 | const DEFAULT_API_VERSION: &'static str = "39.0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/git.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | let root_dir = env::home_dir().unwrap().join(&format!(".{}", NAME)); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/git.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | let root_dir = env::home_dir().unwrap().join(&format!(".{}", NAME)); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/forcedotcom.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | match new_file_path.rsplit("/").nth(1) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/forcedotcom.rs:118:16 [INFO] [stderr] | [INFO] [stderr] 118 | if md_folder.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!md_folder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/forcedotcom.rs:119:44 [INFO] [stderr] | [INFO] [stderr] 119 | match new_file_path.rsplit("/").nth(0) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/forcedotcom.rs:121:61 [INFO] [stderr] | [INFO] [stderr] 121 | Some(f) => component.push_str(&f.rsplit(".") [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/forcedotcom.rs:132:20 [INFO] [stderr] | [INFO] [stderr] 132 | if component.len() > 0 && type_mapping.contains_key(&md_folder) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!component.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/forcedotcom.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | / match types_hash_map.get_mut(&md_type) { [INFO] [stderr] 141 | | Some(ref mut types) => types.members.push(members), [INFO] [stderr] 142 | | None => {}, [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(ref mut types) = types_hash_map.get_mut(&md_type) { types.members.push(members) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:34:34 [INFO] [stderr] | [INFO] [stderr] 34 | let deltas: Vec = diff.deltas() [INFO] [stderr] | __________________________________^ [INFO] [stderr] 35 | | .filter_map(|d| match d.status() == Delta::Added { true => Some(d), false => None, }) [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | .filter_map(|d| match d.status() == Delta::Added { true => Some(d), false => None, }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an if/else expression: `if d.status() == Delta::Added { Some(d) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/forcedotcom.rs:114:40 [INFO] [stderr] | [INFO] [stderr] 114 | match new_file_path.rsplit("/").nth(1) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/forcedotcom.rs:118:16 [INFO] [stderr] | [INFO] [stderr] 118 | if md_folder.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!md_folder.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/forcedotcom.rs:119:44 [INFO] [stderr] | [INFO] [stderr] 119 | match new_file_path.rsplit("/").nth(0) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/forcedotcom.rs:121:61 [INFO] [stderr] | [INFO] [stderr] 121 | Some(f) => component.push_str(&f.rsplit(".") [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/forcedotcom.rs:132:20 [INFO] [stderr] | [INFO] [stderr] 132 | if component.len() > 0 && type_mapping.contains_key(&md_folder) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!component.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/forcedotcom.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | / match types_hash_map.get_mut(&md_type) { [INFO] [stderr] 141 | | Some(ref mut types) => types.members.push(members), [INFO] [stderr] 142 | | None => {}, [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(ref mut types) = types_hash_map.get_mut(&md_type) { types.members.push(members) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:34:34 [INFO] [stderr] | [INFO] [stderr] 34 | let deltas: Vec = diff.deltas() [INFO] [stderr] | __________________________________^ [INFO] [stderr] 35 | | .filter_map(|d| match d.status() == Delta::Added { true => Some(d), false => None, }) [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | .filter_map(|d| match d.status() == Delta::Added { true => Some(d), false => None, }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an if/else expression: `if d.status() == Delta::Added { Some(d) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> tests/branch_all_new_test.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | let root_dir = env::home_dir().unwrap().join(&format!(".{}", NAME)); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.59s [INFO] running `"docker" "inspect" "17c5ef03a98111619590927eb1e548136499d8ccba09838cf8da084ceb34d00f"` [INFO] running `"docker" "rm" "-f" "17c5ef03a98111619590927eb1e548136499d8ccba09838cf8da084ceb34d00f"` [INFO] [stdout] 17c5ef03a98111619590927eb1e548136499d8ccba09838cf8da084ceb34d00f