[INFO] crate derpy 0.1.0 is already in cache [INFO] extracting crate derpy 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/derpy/0.1.0 [INFO] extracting crate derpy 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derpy/0.1.0 [INFO] validating manifest of derpy-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derpy-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derpy-0.1.0 [INFO] finished frobbing derpy-0.1.0 [INFO] frobbed toml for derpy-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/derpy/0.1.0/Cargo.toml [INFO] started frobbing derpy-0.1.0 [INFO] finished frobbing derpy-0.1.0 [INFO] frobbed toml for derpy-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derpy/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derpy-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derpy/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a4556672e4ea9f5aef78be859376ef612c4019c088a48708b43fc2ebf9d7044 [INFO] running `"docker" "start" "-a" "6a4556672e4ea9f5aef78be859376ef612c4019c088a48708b43fc2ebf9d7044"` [INFO] [stderr] Checking strfmt v0.1.6 [INFO] [stderr] Checking derpy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/acquire.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 87 | | if let AcquireMode::Acquire = acquire_mode { [INFO] [stderr] 88 | | vcs.acquire(&log, dep)?; [INFO] [stderr] 89 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | } else if let AcquireMode::Acquire = acquire_mode { [INFO] [stderr] 87 | vcs.acquire(&log, dep)?; [INFO] [stderr] 88 | [INFO] [stderr] 89 | Ok(AcquireOutcome::Acquired { [INFO] [stderr] 90 | at_version: vcs.get_version_of(&log, dep)?, [INFO] [stderr] 91 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/acquire.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 87 | | if let AcquireMode::Acquire = acquire_mode { [INFO] [stderr] 88 | | vcs.acquire(&log, dep)?; [INFO] [stderr] 89 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | } else if let AcquireMode::Acquire = acquire_mode { [INFO] [stderr] 87 | vcs.acquire(&log, dep)?; [INFO] [stderr] 88 | [INFO] [stderr] 89 | Ok(AcquireOutcome::Acquired { [INFO] [stderr] 90 | at_version: vcs.get_version_of(&log, dep)?, [INFO] [stderr] 91 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arg_utils.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | let parts = text.splitn(2, ":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/acquire.rs:39:28 [INFO] [stderr] | [INFO] [stderr] 39 | None => return Err(DerpyError::UnknownVcs { name: dep.vcs.clone() }.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::UnknownVcs { name: dep.vcs.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/acquire.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | Err(DerpyError::NonsenseAcquireMode { [INFO] [stderr] | _________________^ [INFO] [stderr] 95 | | dependency: dep.name.clone(), [INFO] [stderr] 96 | | acquire_mode, [INFO] [stderr] 97 | | }.into()) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 94 | Err(DerpyError::NonsenseAcquireMode { [INFO] [stderr] 95 | dependency: dep.name.clone(), [INFO] [stderr] 96 | acquire_mode, [INFO] [stderr] 97 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/init.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | return Err(DerpyError::AlreadyInitialised.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::AlreadyInitialised` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cmds/init.rs:11:8 [INFO] [stderr] | [INFO] [stderr] 11 | Ok(save_config(&Default::default(), config_path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 11 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | None => return Err(DerpyError::UnknownVcs { name: vcs.into() }.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::UnknownVcs { name: vcs.into() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:19:59 [INFO] [stderr] | [INFO] [stderr] 19 | None => return Err(DerpyError::UnknownVcs { name: vcs.into() }.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `vcs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | return Err(DerpyError::DependencyAlreadyExists { name: name.into() }.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::DependencyAlreadyExists { name: name.into() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:56:64 [INFO] [stderr] | [INFO] [stderr] 56 | return Err(DerpyError::DependencyAlreadyExists { name: name.into() }.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | fn expand_vcs_command(cmd: &VcsCommand, macros: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:58:34 [INFO] [stderr] | [INFO] [stderr] 58 | fn expand_vcs_command_list(list: &VcsCommandList, macros: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arg_utils.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | let parts = text.splitn(2, ":") [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | fn run_cmd(log: &Log, cmd: &VcsCommand) -> Result<(String, String), DerpyError> { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change `cmd.clone()` to [INFO] [stderr] | [INFO] [stderr] 122 | cmd: cmd.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: change `cmd.clone()` to [INFO] [stderr] | [INFO] [stderr] 130 | cmd: cmd.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: change `cmd.clone()` to [INFO] [stderr] | [INFO] [stderr] 139 | cmd: cmd.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/vcs.rs:144:12 [INFO] [stderr] | [INFO] [stderr] 144 | if return_code.success() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!return_code.success()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/vcs.rs:145:24 [INFO] [stderr] | [INFO] [stderr] 145 | return Err(DerpyError::VcsCommandFailed { cmd: cmd.clone(), return_code, stdout, stderr }.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::VcsCommandFailed { cmd: cmd.clone(), return_code, stdout, stderr }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:151:46 [INFO] [stderr] | [INFO] [stderr] 151 | fn run_cmd_sequence(log: &Log, sequence: &VcsCommandList) -> Result<(), DerpyError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/acquire.rs:39:28 [INFO] [stderr] | [INFO] [stderr] 39 | None => return Err(DerpyError::UnknownVcs { name: dep.vcs.clone() }.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::UnknownVcs { name: dep.vcs.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/acquire.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | Err(DerpyError::NonsenseAcquireMode { [INFO] [stderr] | _________________^ [INFO] [stderr] 95 | | dependency: dep.name.clone(), [INFO] [stderr] 96 | | acquire_mode, [INFO] [stderr] 97 | | }.into()) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 94 | Err(DerpyError::NonsenseAcquireMode { [INFO] [stderr] 95 | dependency: dep.name.clone(), [INFO] [stderr] 96 | acquire_mode, [INFO] [stderr] 97 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match run_cli(matches) { [INFO] [stderr] 86 | | Err(e) => println!("error: {}", e), [INFO] [stderr] 87 | | _ => {}, [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = run_cli(matches) { println!("error: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | Err(DerpyError::InvalidArguments { [INFO] [stderr] | _________________^ [INFO] [stderr] 99 | | reason: "no subcommand was used".into(), [INFO] [stderr] 100 | | }.into()) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 98 | Err(DerpyError::InvalidArguments { [INFO] [stderr] 99 | reason: "no subcommand was used".into(), [INFO] [stderr] 100 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/init.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | return Err(DerpyError::AlreadyInitialised.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::AlreadyInitialised` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cmds/init.rs:11:8 [INFO] [stderr] | [INFO] [stderr] 11 | Ok(save_config(&Default::default(), config_path)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 11 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | None => return Err(DerpyError::UnknownVcs { name: vcs.into() }.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::UnknownVcs { name: vcs.into() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:19:59 [INFO] [stderr] | [INFO] [stderr] 19 | None => return Err(DerpyError::UnknownVcs { name: vcs.into() }.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `vcs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | return Err(DerpyError::DependencyAlreadyExists { name: name.into() }.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::DependencyAlreadyExists { name: name.into() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/cmds/add.rs:56:64 [INFO] [stderr] | [INFO] [stderr] 56 | return Err(DerpyError::DependencyAlreadyExists { name: name.into() }.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | fn expand_vcs_command(cmd: &VcsCommand, macros: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:58:34 [INFO] [stderr] | [INFO] [stderr] 58 | fn expand_vcs_command_list(list: &VcsCommandList, macros: &HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | fn run_cmd(log: &Log, cmd: &VcsCommand) -> Result<(String, String), DerpyError> { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change `cmd.clone()` to [INFO] [stderr] | [INFO] [stderr] 122 | cmd: cmd.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: change `cmd.clone()` to [INFO] [stderr] | [INFO] [stderr] 130 | cmd: cmd.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: change `cmd.clone()` to [INFO] [stderr] | [INFO] [stderr] 139 | cmd: cmd.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/vcs.rs:144:12 [INFO] [stderr] | [INFO] [stderr] 144 | if return_code.success() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!return_code.success()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/vcs.rs:145:24 [INFO] [stderr] | [INFO] [stderr] 145 | return Err(DerpyError::VcsCommandFailed { cmd: cmd.clone(), return_code, stdout, stderr }.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `DerpyError::VcsCommandFailed { cmd: cmd.clone(), return_code, stdout, stderr }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/vcs.rs:151:46 [INFO] [stderr] | [INFO] [stderr] 151 | fn run_cmd_sequence(log: &Log, sequence: &VcsCommandList) -> Result<(), DerpyError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match run_cli(matches) { [INFO] [stderr] 86 | | Err(e) => println!("error: {}", e), [INFO] [stderr] 87 | | _ => {}, [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = run_cli(matches) { println!("error: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | Err(DerpyError::InvalidArguments { [INFO] [stderr] | _________________^ [INFO] [stderr] 99 | | reason: "no subcommand was used".into(), [INFO] [stderr] 100 | | }.into()) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 98 | Err(DerpyError::InvalidArguments { [INFO] [stderr] 99 | reason: "no subcommand was used".into(), [INFO] [stderr] 100 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.31s [INFO] running `"docker" "inspect" "6a4556672e4ea9f5aef78be859376ef612c4019c088a48708b43fc2ebf9d7044"` [INFO] running `"docker" "rm" "-f" "6a4556672e4ea9f5aef78be859376ef612c4019c088a48708b43fc2ebf9d7044"` [INFO] [stdout] 6a4556672e4ea9f5aef78be859376ef612c4019c088a48708b43fc2ebf9d7044