[INFO] crate derive_state_machine_future 0.2.0 is already in cache [INFO] extracting crate derive_state_machine_future 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/derive_state_machine_future/0.2.0 [INFO] extracting crate derive_state_machine_future 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive_state_machine_future/0.2.0 [INFO] validating manifest of derive_state_machine_future-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derive_state_machine_future-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derive_state_machine_future-0.2.0 [INFO] finished frobbing derive_state_machine_future-0.2.0 [INFO] frobbed toml for derive_state_machine_future-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/derive_state_machine_future/0.2.0/Cargo.toml [INFO] started frobbing derive_state_machine_future-0.2.0 [INFO] finished frobbing derive_state_machine_future-0.2.0 [INFO] frobbed toml for derive_state_machine_future-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive_state_machine_future/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derive_state_machine_future-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derive_state_machine_future/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adaf9f4ad22a25e823d9feda14e2efbe621814382d08fe6d955b17828f9f481f [INFO] running `"docker" "start" "-a" "adaf9f4ad22a25e823d9feda14e2efbe621814382d08fe6d955b17828f9f481f"` [INFO] [stderr] Checking ident_case v1.0.0 [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Compiling darling_core v0.8.3 [INFO] [stderr] Compiling darling_macro v0.8.3 [INFO] [stderr] Checking darling v0.8.3 [INFO] [stderr] Checking derive_state_machine_future v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/codegen.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / fn to_tokens(&self, tokens: &mut proc_macro2::TokenStream) { [INFO] [stderr] 44 | | if cfg!(feature = "debug_code_generation") { [INFO] [stderr] 45 | | println!("StateMachine::to_tokens: self = {:#?}", self); [INFO] [stderr] 46 | | } [INFO] [stderr] ... | [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codegen.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | let has_no_start_parameters = start_params.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `start_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/phases.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | "Non-{ready,error} states must have transitions" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/phases.rs:546:61 [INFO] [stderr] | [INFO] [stderr] 546 | let lifetime_def = *lifetime_defs.get(lifetime).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lifetime_defs[lifetime]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/phases.rs:555:59 [INFO] [stderr] | [INFO] [stderr] 555 | let type_param = *type_param_defs.get(ident).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&type_param_defs[ident]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/codegen.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / fn to_tokens(&self, tokens: &mut proc_macro2::TokenStream) { [INFO] [stderr] 44 | | if cfg!(feature = "debug_code_generation") { [INFO] [stderr] 45 | | println!("StateMachine::to_tokens: self = {:#?}", self); [INFO] [stderr] 46 | | } [INFO] [stderr] ... | [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codegen.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | let has_no_start_parameters = start_params.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `start_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/phases.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | "Non-{ready,error} states must have transitions" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/phases.rs:546:61 [INFO] [stderr] | [INFO] [stderr] 546 | let lifetime_def = *lifetime_defs.get(lifetime).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lifetime_defs[lifetime]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/phases.rs:555:59 [INFO] [stderr] | [INFO] [stderr] 555 | let type_param = *type_param_defs.get(ident).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&type_param_defs[ident]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.40s [INFO] running `"docker" "inspect" "adaf9f4ad22a25e823d9feda14e2efbe621814382d08fe6d955b17828f9f481f"` [INFO] running `"docker" "rm" "-f" "adaf9f4ad22a25e823d9feda14e2efbe621814382d08fe6d955b17828f9f481f"` [INFO] [stdout] adaf9f4ad22a25e823d9feda14e2efbe621814382d08fe6d955b17828f9f481f