[INFO] crate derive_builder 0.7.0 is already in cache [INFO] extracting crate derive_builder 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/derive_builder/0.7.0 [INFO] extracting crate derive_builder 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive_builder/0.7.0 [INFO] validating manifest of derive_builder-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derive_builder-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derive_builder-0.7.0 [INFO] finished frobbing derive_builder-0.7.0 [INFO] frobbed toml for derive_builder-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/derive_builder/0.7.0/Cargo.toml [INFO] started frobbing derive_builder-0.7.0 [INFO] finished frobbing derive_builder-0.7.0 [INFO] frobbed toml for derive_builder-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive_builder/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derive_builder-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derive_builder/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a804f9e4b66a33cdf9701790f236caf13dd6328be9c6cf172506335b0e4411b [INFO] running `"docker" "start" "-a" "8a804f9e4b66a33cdf9701790f236caf13dd6328be9c6cf172506335b0e4411b"` [INFO] [stderr] Checking ident_case v1.0.0 [INFO] [stderr] Compiling derive_builder v0.7.0 (/opt/crater/workdir) [INFO] [stderr] Compiling derive_builder_core v0.4.0 [INFO] [stderr] Checking darling_core v0.8.3 [INFO] [stderr] Checking darling v0.8.3 [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options/darling_opts.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / pub fn fields<'a>(&'a self) -> FieldIter<'a> { [INFO] [stderr] 332 | | FieldIter(self, self.raw_fields().into_iter()) [INFO] [stderr] 333 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options/darling_opts.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | / pub fn as_builder<'a>(&'a self) -> Builder<'a> { [INFO] [stderr] 349 | | Builder { [INFO] [stderr] 350 | | enabled: true, [INFO] [stderr] 351 | | ident: self.builder_ident(), [INFO] [stderr] ... | [INFO] [stderr] 362 | | } [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options/darling_opts.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | / pub fn as_build_method<'a>(&'a self) -> BuildMethod<'a> { [INFO] [stderr] 366 | | let (_, ty_generics, _) = self.generics.split_for_impl(); [INFO] [stderr] 367 | | BuildMethod { [INFO] [stderr] 368 | | enabled: !self.build_fn.skip, [INFO] [stderr] ... | [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/options/darling_opts.rs:401:14 [INFO] [stderr] | [INFO] [stderr] 401 | .or(self.parent.setter.enabled()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.parent.setter.enabled())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/options/darling_opts.rs:418:14 [INFO] [stderr] | [INFO] [stderr] 418 | .or(self.parent.setter.prefix.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.parent.setter.prefix.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/options/darling_opts.rs:451:14 [INFO] [stderr] | [INFO] [stderr] 451 | .unwrap_or(syn::parse_str("pub").unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::parse_str("pub").unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `expect` followed by a function call [INFO] [stderr] --> src/options/mod.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | .expect(&format!("Couldn't parse default expression `{:?}`", self)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse default expression `{:?}`", self))` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::expect_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:573:10 [INFO] [stderr] | [INFO] [stderr] 573 | .expect(&format!("Couldn't parse `{}` to tokens", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse `{}` to tokens", result))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `derive_builder`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options/darling_opts.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / pub fn fields<'a>(&'a self) -> FieldIter<'a> { [INFO] [stderr] 332 | | FieldIter(self, self.raw_fields().into_iter()) [INFO] [stderr] 333 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options/darling_opts.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | / pub fn as_builder<'a>(&'a self) -> Builder<'a> { [INFO] [stderr] 349 | | Builder { [INFO] [stderr] 350 | | enabled: true, [INFO] [stderr] 351 | | ident: self.builder_ident(), [INFO] [stderr] ... | [INFO] [stderr] 362 | | } [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options/darling_opts.rs:365:5 [INFO] [stderr] | [INFO] [stderr] 365 | / pub fn as_build_method<'a>(&'a self) -> BuildMethod<'a> { [INFO] [stderr] 366 | | let (_, ty_generics, _) = self.generics.split_for_impl(); [INFO] [stderr] 367 | | BuildMethod { [INFO] [stderr] 368 | | enabled: !self.build_fn.skip, [INFO] [stderr] ... | [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/options/darling_opts.rs:401:14 [INFO] [stderr] | [INFO] [stderr] 401 | .or(self.parent.setter.enabled()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.parent.setter.enabled())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/options/darling_opts.rs:418:14 [INFO] [stderr] | [INFO] [stderr] 418 | .or(self.parent.setter.prefix.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.parent.setter.prefix.as_ref())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/options/darling_opts.rs:451:14 [INFO] [stderr] | [INFO] [stderr] 451 | .unwrap_or(syn::parse_str("pub").unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::parse_str("pub").unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `expect` followed by a function call [INFO] [stderr] --> src/options/mod.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | .expect(&format!("Couldn't parse default expression `{:?}`", self)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse default expression `{:?}`", self))` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:525:9 [INFO] [stderr] | [INFO] [stderr] 525| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::expect_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:573:10 [INFO] [stderr] | [INFO] [stderr] 573 | .expect(&format!("Couldn't parse `{}` to tokens", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse `{}` to tokens", result))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `derive_builder`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/generic_structs.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | ipsum: "Generic".into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Generic"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8a804f9e4b66a33cdf9701790f236caf13dd6328be9c6cf172506335b0e4411b"` [INFO] running `"docker" "rm" "-f" "8a804f9e4b66a33cdf9701790f236caf13dd6328be9c6cf172506335b0e4411b"` [INFO] [stdout] 8a804f9e4b66a33cdf9701790f236caf13dd6328be9c6cf172506335b0e4411b