[INFO] crate derive-new 0.5.6 is already in cache [INFO] extracting crate derive-new 0.5.6 into work/ex/clippy-test-run/sources/stable/reg/derive-new/0.5.6 [INFO] extracting crate derive-new 0.5.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-new/0.5.6 [INFO] validating manifest of derive-new-0.5.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derive-new-0.5.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derive-new-0.5.6 [INFO] finished frobbing derive-new-0.5.6 [INFO] frobbed toml for derive-new-0.5.6 written to work/ex/clippy-test-run/sources/stable/reg/derive-new/0.5.6/Cargo.toml [INFO] started frobbing derive-new-0.5.6 [INFO] finished frobbing derive-new-0.5.6 [INFO] frobbed toml for derive-new-0.5.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-new/0.5.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derive-new-0.5.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derive-new/0.5.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8c14837dc807239edbc1f1c98c7664a54f1d14af08b6833a73e8dc0e3b22d8c [INFO] running `"docker" "start" "-a" "d8c14837dc807239edbc1f1c98c7664a54f1d14af08b6833a73e8dc0e3b22d8c"` [INFO] [stderr] Compiling derive-new v0.5.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | named: named, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `named` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:342:13 [INFO] [stderr] | [INFO] [stderr] 342 | named: named, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `named` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:394:21 [INFO] [stderr] | [INFO] [stderr] 394 | / if ch.is_uppercase() { [INFO] [stderr] 395 | | if prev.is_lowercase() || prev.is_numeric() || [INFO] [stderr] 396 | | (prev.is_uppercase() && next.is_lowercase()) [INFO] [stderr] 397 | | { [INFO] [stderr] 398 | | acc.push('_'); [INFO] [stderr] 399 | | } [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 394 | if ch.is_uppercase() && (prev.is_lowercase() || prev.is_numeric() || [INFO] [stderr] 395 | (prev.is_uppercase() && next.is_lowercase())) { [INFO] [stderr] 396 | acc.push('_'); [INFO] [stderr] 397 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:394:21 [INFO] [stderr] | [INFO] [stderr] 394 | / if ch.is_uppercase() { [INFO] [stderr] 395 | | if prev.is_lowercase() || prev.is_numeric() || [INFO] [stderr] 396 | | (prev.is_uppercase() && next.is_lowercase()) [INFO] [stderr] 397 | | { [INFO] [stderr] 398 | | acc.push('_'); [INFO] [stderr] 399 | | } [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 394 | if ch.is_uppercase() && (prev.is_lowercase() || prev.is_numeric() || [INFO] [stderr] 395 | (prev.is_uppercase() && next.is_lowercase())) { [INFO] [stderr] 396 | acc.push('_'); [INFO] [stderr] 397 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:300:46 [INFO] [stderr] | [INFO] [stderr] 300 | let tokens = s.value().parse().ok() [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 301 | | .expect(&format!( [INFO] [stderr] 302 | | "Invalid expression in #[new]: `{}`", s.value())); [INFO] [stderr] | |_________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:301:38 [INFO] [stderr] | [INFO] [stderr] 301 | .expect(&format!( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 302 | | "Invalid expression in #[new]: `{}`", s.value())); [INFO] [stderr] | |_________________________________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("Invalid expression in #[new]: `{}`", s.value()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:300:46 [INFO] [stderr] | [INFO] [stderr] 300 | let tokens = s.value().parse().ok() [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 301 | | .expect(&format!( [INFO] [stderr] 302 | | "Invalid expression in #[new]: `{}`", s.value())); [INFO] [stderr] | |_________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:301:38 [INFO] [stderr] | [INFO] [stderr] 301 | .expect(&format!( [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 302 | | "Invalid expression in #[new]: `{}`", s.value())); [INFO] [stderr] | |_________________________________________________________________________________________^ help: try this: `unwrap_or_else(|| panic!("Invalid expression in #[new]: `{}`", s.value()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.97s [INFO] running `"docker" "inspect" "d8c14837dc807239edbc1f1c98c7664a54f1d14af08b6833a73e8dc0e3b22d8c"` [INFO] running `"docker" "rm" "-f" "d8c14837dc807239edbc1f1c98c7664a54f1d14af08b6833a73e8dc0e3b22d8c"` [INFO] [stdout] d8c14837dc807239edbc1f1c98c7664a54f1d14af08b6833a73e8dc0e3b22d8c