[INFO] crate derive-getters 0.0.7 is already in cache [INFO] extracting crate derive-getters 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/derive-getters/0.0.7 [INFO] extracting crate derive-getters 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-getters/0.0.7 [INFO] validating manifest of derive-getters-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derive-getters-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derive-getters-0.0.7 [INFO] finished frobbing derive-getters-0.0.7 [INFO] frobbed toml for derive-getters-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/derive-getters/0.0.7/Cargo.toml [INFO] started frobbing derive-getters-0.0.7 [INFO] finished frobbing derive-getters-0.0.7 [INFO] frobbed toml for derive-getters-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-getters/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derive-getters-0.0.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derive-getters/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0550d6536067379cb7eebe447f7b8f546fd1be7c60d57e7127dec1c6031ff351 [INFO] running `"docker" "start" "-a" "0550d6536067379cb7eebe447f7b8f546fd1be7c60d57e7127dec1c6031ff351"` [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Compiling derive-getters v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `y` [INFO] [stderr] --> tests/lib.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | y: u64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `z` [INFO] [stderr] --> tests/lib.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | z: u64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/lib.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | assert!(numbers.floating() == &45.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(numbers.floating() - &45.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/lib.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | assert!(numbers.floating() == &45.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `derive-getters`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | let name = field.ident.as_ref().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*field.ident.as_ref().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / match data { [INFO] [stderr] 99 | | &Data::Struct(ref body) => { [INFO] [stderr] 100 | | match &body.fields { [INFO] [stderr] 101 | | &Fields::Named(ref named) => Ok(&named.named), [INFO] [stderr] ... | [INFO] [stderr] 105 | | _ => Err(INVALID_VARIANT), [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *data { [INFO] [stderr] 99 | Data::Struct(ref body) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match &body.fields { [INFO] [stderr] 101 | | &Fields::Named(ref named) => Ok(&named.named), [INFO] [stderr] 102 | | _ => Err(INVALID_STRUCT), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | match body.fields { [INFO] [stderr] 101 | Fields::Named(ref named) => Ok(&named.named), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:109:1 [INFO] [stderr] | [INFO] [stderr] 109 | / fn setup_getters_impl<'a>(ast: &'a syn::DeriveInput) -> quote::Tokens { [INFO] [stderr] 110 | | let slots: Vec = get_slots(&ast.data) [INFO] [stderr] 111 | | .unwrap_or_else(|e| panic!("Couldn't autogenerate: {}", e)) [INFO] [stderr] 112 | | .iter() [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | let name = field.ident.as_ref().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*field.ident.as_ref().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | let label = slot.label.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `slot.label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / match data { [INFO] [stderr] 99 | | &Data::Struct(ref body) => { [INFO] [stderr] 100 | | match &body.fields { [INFO] [stderr] 101 | | &Fields::Named(ref named) => Ok(&named.named), [INFO] [stderr] ... | [INFO] [stderr] 105 | | _ => Err(INVALID_VARIANT), [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *data { [INFO] [stderr] 99 | Data::Struct(ref body) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match &body.fields { [INFO] [stderr] 101 | | &Fields::Named(ref named) => Ok(&named.named), [INFO] [stderr] 102 | | _ => Err(INVALID_STRUCT), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 100 | match body.fields { [INFO] [stderr] 101 | Fields::Named(ref named) => Ok(&named.named), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:109:1 [INFO] [stderr] | [INFO] [stderr] 109 | / fn setup_getters_impl<'a>(ast: &'a syn::DeriveInput) -> quote::Tokens { [INFO] [stderr] 110 | | let slots: Vec = get_slots(&ast.data) [INFO] [stderr] 111 | | .unwrap_or_else(|e| panic!("Couldn't autogenerate: {}", e)) [INFO] [stderr] 112 | | .iter() [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | let struct_name = ast.ident.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ast.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | let label = slot.label.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `slot.label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | let struct_name = ast.ident.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ast.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0550d6536067379cb7eebe447f7b8f546fd1be7c60d57e7127dec1c6031ff351"` [INFO] running `"docker" "rm" "-f" "0550d6536067379cb7eebe447f7b8f546fd1be7c60d57e7127dec1c6031ff351"` [INFO] [stdout] 0550d6536067379cb7eebe447f7b8f546fd1be7c60d57e7127dec1c6031ff351