[INFO] crate derive-error 0.0.4 is already in cache [INFO] extracting crate derive-error 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/derive-error/0.0.4 [INFO] extracting crate derive-error 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-error/0.0.4 [INFO] validating manifest of derive-error-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derive-error-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derive-error-0.0.4 [INFO] finished frobbing derive-error-0.0.4 [INFO] frobbed toml for derive-error-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/derive-error/0.0.4/Cargo.toml [INFO] started frobbing derive-error-0.0.4 [INFO] finished frobbing derive-error-0.0.4 [INFO] frobbed toml for derive-error-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-error/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derive-error-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derive-error/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 153b1fab3ce2b4e09d9d675913b016ac9331a3b0477260570054c341d1d57226 [INFO] running `"docker" "start" "-a" "153b1fab3ce2b4e09d9d675913b016ac9331a3b0477260570054c341d1d57226"` [INFO] [stderr] Checking case v0.1.0 [INFO] [stderr] Compiling derive-error v0.0.4 (/opt/crater/workdir) [INFO] [stderr] Compiling derive-new v0.5.6 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/error.rs:212:32 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 213 | | if title.is_some() { [INFO] [stderr] 214 | | return trimmed(title); [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if title.is_some() { [INFO] [stderr] 213 | return trimmed(title); [INFO] [stderr] 214 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/error.rs:107:67 [INFO] [stderr] | [INFO] [stderr] 107 | fn tuple_variant(&mut self, var: &Variant, msg: &str, fields: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Field]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/error.rs:150:66 [INFO] [stderr] | [INFO] [stderr] 150 | fn struct_field(&mut self, var: &Variant, msg: &str, fields: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/error.rs:196:33 [INFO] [stderr] | [INFO] [stderr] 196 | fn title(&self, attributes: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Checking rspec v1.0.0-beta.4 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/error.rs:212:32 [INFO] [stderr] | [INFO] [stderr] 212 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 213 | | if title.is_some() { [INFO] [stderr] 214 | | return trimmed(title); [INFO] [stderr] 215 | | } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 212 | } else if title.is_some() { [INFO] [stderr] 213 | return trimmed(title); [INFO] [stderr] 214 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/error.rs:107:67 [INFO] [stderr] | [INFO] [stderr] 107 | fn tuple_variant(&mut self, var: &Variant, msg: &str, fields: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Field]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/error.rs:150:66 [INFO] [stderr] | [INFO] [stderr] 150 | fn struct_field(&mut self, var: &Variant, msg: &str, fields: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Field]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/error.rs:196:33 [INFO] [stderr] | [INFO] [stderr] 196 | fn title(&self, attributes: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Attribute]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.13s [INFO] running `"docker" "inspect" "153b1fab3ce2b4e09d9d675913b016ac9331a3b0477260570054c341d1d57226"` [INFO] running `"docker" "rm" "-f" "153b1fab3ce2b4e09d9d675913b016ac9331a3b0477260570054c341d1d57226"` [INFO] [stdout] 153b1fab3ce2b4e09d9d675913b016ac9331a3b0477260570054c341d1d57226