[INFO] crate derive-diff 0.2.5 is already in cache
[INFO] extracting crate derive-diff 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/derive-diff/0.2.5
[INFO] extracting crate derive-diff 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-diff/0.2.5
[INFO] validating manifest of derive-diff-0.2.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of derive-diff-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing derive-diff-0.2.5
[INFO] finished frobbing derive-diff-0.2.5
[INFO] frobbed toml for derive-diff-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/derive-diff/0.2.5/Cargo.toml
[INFO] started frobbing derive-diff-0.2.5
[INFO] finished frobbing derive-diff-0.2.5
[INFO] frobbed toml for derive-diff-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-diff/0.2.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting derive-diff-0.2.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derive-diff/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 41224354a71245711254053437d5d839b5223376b35abfc47fb8a83677303f91
[INFO] running `"docker" "start" "-a" "41224354a71245711254053437d5d839b5223376b35abfc47fb8a83677303f91"`
[INFO] [stderr]     Checking struct-diff v0.2.3
[INFO] [stderr]     Checking derive-diff v0.2.5 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:73:50
[INFO] [stderr]    |
[INFO] [stderr] 73 |             let field_name = field.ident.clone().unwrap_or(syn::Ident::from(i));
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::Ident::from(i))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:136:20
[INFO] [stderr]     |
[INFO] [stderr] 136 |           let diff = match var_data {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 137 | |             &syn::VariantData::Tuple(ref fields) => {
[INFO] [stderr] 138 | |                 let gen = FieldGenerator { name: var_name, fields };
[INFO] [stderr] 139 | |                 let names: Vec<syn::Ident> = fields.iter()
[INFO] [stderr] ...   |
[INFO] [stderr] 183 | |             },
[INFO] [stderr] 184 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let diff = match *var_data {
[INFO] [stderr] 137 |             syn::VariantData::Tuple(ref fields) => {
[INFO] [stderr] 138 |                 let gen = FieldGenerator { name: var_name, fields };
[INFO] [stderr] 139 |                 let names: Vec<syn::Ident> = fields.iter()
[INFO] [stderr] 140 |                         .enumerate()
[INFO] [stderr] 141 |                         .map(|(id, field)| field.ident.clone().unwrap_or(syn::Ident::from(id)))
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:141:64
[INFO] [stderr]     |
[INFO] [stderr] 141 |                         .map(|(id, field)| field.ident.clone().unwrap_or(syn::Ident::from(id)))
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::Ident::from(id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:163:64
[INFO] [stderr]     |
[INFO] [stderr] 163 |                         .map(|(id, field)| field.ident.clone().unwrap_or(syn::Ident::from(id)))
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::Ident::from(id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:73:50
[INFO] [stderr]    |
[INFO] [stderr] 73 |             let field_name = field.ident.clone().unwrap_or(syn::Ident::from(i));
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::Ident::from(i))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:274:9
[INFO] [stderr]     |
[INFO] [stderr] 274 |         v@_ => {
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:136:20
[INFO] [stderr]     |
[INFO] [stderr] 136 |           let diff = match var_data {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 137 | |             &syn::VariantData::Tuple(ref fields) => {
[INFO] [stderr] 138 | |                 let gen = FieldGenerator { name: var_name, fields };
[INFO] [stderr] 139 | |                 let names: Vec<syn::Ident> = fields.iter()
[INFO] [stderr] ...   |
[INFO] [stderr] 183 | |             },
[INFO] [stderr] 184 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let diff = match *var_data {
[INFO] [stderr] 137 |             syn::VariantData::Tuple(ref fields) => {
[INFO] [stderr] 138 |                 let gen = FieldGenerator { name: var_name, fields };
[INFO] [stderr] 139 |                 let names: Vec<syn::Ident> = fields.iter()
[INFO] [stderr] 140 |                         .enumerate()
[INFO] [stderr] 141 |                         .map(|(id, field)| field.ident.clone().unwrap_or(syn::Ident::from(id)))
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:141:64
[INFO] [stderr]     |
[INFO] [stderr] 141 |                         .map(|(id, field)| field.ident.clone().unwrap_or(syn::Ident::from(id)))
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::Ident::from(id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:163:64
[INFO] [stderr]     |
[INFO] [stderr] 163 |                         .map(|(id, field)| field.ident.clone().unwrap_or(syn::Ident::from(id)))
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| syn::Ident::from(id))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the `v @ _` pattern can be written as just `v`
[INFO] [stderr]    --> src/lib.rs:274:9
[INFO] [stderr]     |
[INFO] [stderr] 274 |         v@_ => {
[INFO] [stderr]     |         ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.84s
[INFO] running `"docker" "inspect" "41224354a71245711254053437d5d839b5223376b35abfc47fb8a83677303f91"`
[INFO] running `"docker" "rm" "-f" "41224354a71245711254053437d5d839b5223376b35abfc47fb8a83677303f91"`
[INFO] [stdout] 41224354a71245711254053437d5d839b5223376b35abfc47fb8a83677303f91