[INFO] crate derive-com-impl 0.1.0-alpha3 is already in cache [INFO] extracting crate derive-com-impl 0.1.0-alpha3 into work/ex/clippy-test-run/sources/stable/reg/derive-com-impl/0.1.0-alpha3 [INFO] extracting crate derive-com-impl 0.1.0-alpha3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-com-impl/0.1.0-alpha3 [INFO] validating manifest of derive-com-impl-0.1.0-alpha3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derive-com-impl-0.1.0-alpha3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derive-com-impl-0.1.0-alpha3 [INFO] finished frobbing derive-com-impl-0.1.0-alpha3 [INFO] frobbed toml for derive-com-impl-0.1.0-alpha3 written to work/ex/clippy-test-run/sources/stable/reg/derive-com-impl/0.1.0-alpha3/Cargo.toml [INFO] started frobbing derive-com-impl-0.1.0-alpha3 [INFO] finished frobbing derive-com-impl-0.1.0-alpha3 [INFO] frobbed toml for derive-com-impl-0.1.0-alpha3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/derive-com-impl/0.1.0-alpha3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derive-com-impl-0.1.0-alpha3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/derive-com-impl/0.1.0-alpha3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e94cd215487df545c198329b36e15cd6ca022bfb618cd20567c582dfae6d97ed [INFO] running `"docker" "start" "-a" "e94cd215487df545c198329b36e15cd6ca022bfb618cd20567c582dfae6d97ed"` [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking com-impl v0.1.0-alpha2 [INFO] [stderr] Checking derive-com-impl v0.1.0-alpha3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/com_impl.rs:549:17 [INFO] [stderr] | [INFO] [stderr] 549 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/com_impl.rs:553:18 [INFO] [stderr] | [INFO] [stderr] 553 | _ => return Err("Invalid argument syntax for COM function.".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Invalid argument syntax for COM function.".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/derive.rs:181:37 [INFO] [stderr] | [INFO] [stderr] 181 | Meta::List(list) if list.nested.len() > 0 => list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.nested.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/com_impl.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn expand_com_impl(args: &AttributeArgs, item: &Item) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/com_impl.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | fn parse(args: &'a AttributeArgs, item: &'a ItemImpl) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/com_impl.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | fn has_parent(args: &AttributeArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/com_impl.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | assert!(ty.segments.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ty.segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/com_impl.rs:499:12 [INFO] [stderr] | [INFO] [stderr] 499 | if item.sig.decl.generics.params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!item.sig.decl.generics.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Checking wio v0.2.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/com_impl.rs:549:17 [INFO] [stderr] | [INFO] [stderr] 549 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/com_impl.rs:553:18 [INFO] [stderr] | [INFO] [stderr] 553 | _ => return Err("Invalid argument syntax for COM function.".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Invalid argument syntax for COM function.".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/derive.rs:181:37 [INFO] [stderr] | [INFO] [stderr] 181 | Meta::List(list) if list.nested.len() > 0 => list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.nested.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/com_impl.rs:9:30 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn expand_com_impl(args: &AttributeArgs, item: &Item) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/com_impl.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | fn parse(args: &'a AttributeArgs, item: &'a ItemImpl) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/com_impl.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | fn has_parent(args: &AttributeArgs) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/com_impl.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | assert!(ty.segments.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ty.segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/com_impl.rs:499:12 [INFO] [stderr] | [INFO] [stderr] 499 | if item.sig.decl.generics.params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!item.sig.decl.generics.params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.08s [INFO] running `"docker" "inspect" "e94cd215487df545c198329b36e15cd6ca022bfb618cd20567c582dfae6d97ed"` [INFO] running `"docker" "rm" "-f" "e94cd215487df545c198329b36e15cd6ca022bfb618cd20567c582dfae6d97ed"` [INFO] [stdout] e94cd215487df545c198329b36e15cd6ca022bfb618cd20567c582dfae6d97ed