[INFO] crate der-parser 1.1.0 is already in cache [INFO] extracting crate der-parser 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/der-parser/1.1.0 [INFO] extracting crate der-parser 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/der-parser/1.1.0 [INFO] validating manifest of der-parser-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of der-parser-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing der-parser-1.1.0 [INFO] finished frobbing der-parser-1.1.0 [INFO] frobbed toml for der-parser-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/der-parser/1.1.0/Cargo.toml [INFO] started frobbing der-parser-1.1.0 [INFO] finished frobbing der-parser-1.1.0 [INFO] frobbed toml for der-parser-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/der-parser/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting der-parser-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/der-parser/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9dce78d19b67cbb02b4a5d058042daef0e1e19cfb0f6b0b1f7cd831c8f95eea [INFO] running `"docker" "start" "-a" "f9dce78d19b67cbb02b4a5d058042daef0e1e19cfb0f6b0b1f7cd831c8f95eea"` [INFO] [stderr] Checking rusticata-macros v1.1.0 [INFO] [stderr] Checking der-parser v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der_print.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der_print.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | obj: obj, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `obj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der_print.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | indent: indent, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `indent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/der_print.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | obj: obj, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `obj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:659:86 [INFO] [stderr] | [INFO] [stderr] 659 | let expected = DerObject::from_obj(DerObjectContent::OID(Oid::from(&[1, 2, 840, 113549, 1, 1, 5]))); [INFO] [stderr] | ^^^^^^ help: consider: `113_549` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:1056:73 [INFO] [stderr] | [INFO] [stderr] 1056 | assert_eq!(parse_der_u32(&[0x02, 0x03, 0xff, 0xff, 0xff]),Ok((empty,0xffffff))); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:1057:79 [INFO] [stderr] | [INFO] [stderr] 1057 | assert_eq!(parse_der_u32(&[0x02, 0x04, 0x01, 0x23, 0x45, 0x67]),Ok((empty,0x1234567))); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0123_4567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:1058:79 [INFO] [stderr] | [INFO] [stderr] 1058 | assert_eq!(parse_der_u32(&[0x02, 0x04, 0xff, 0xff, 0xff, 0xff]),Ok((empty,0xffffffff))); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:1073:73 [INFO] [stderr] | [INFO] [stderr] 1073 | assert_eq!(parse_der_u64(&[0x02, 0x03, 0xff, 0xff, 0xff]),Ok((empty,0xffffff))); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:1074:79 [INFO] [stderr] | [INFO] [stderr] 1074 | assert_eq!(parse_der_u64(&[0x02, 0x04, 0x01, 0x23, 0x45, 0x67]),Ok((empty,0x1234567))); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0123_4567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:1075:79 [INFO] [stderr] | [INFO] [stderr] 1075 | assert_eq!(parse_der_u64(&[0x02, 0x04, 0xff, 0xff, 0xff, 0xff]),Ok((empty,0xffffffff))); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/der_parser.rs:1076:85 [INFO] [stderr] | [INFO] [stderr] 1076 | assert_eq!(parse_der_u64(&[0x02, 0x05, 0x01, 0x23, 0x45, 0x67, 0x89]),Ok((empty,0x123456789))); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_2345_6789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oid.rs:58:38 [INFO] [stderr] | [INFO] [stderr] 58 | let oid = Oid::from(&[1, 2, 840, 113549, 1, 1, 5]); [INFO] [stderr] | ^^^^^^ help: consider: `113_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:37:39 [INFO] [stderr] | [INFO] [stderr] 37 | 1 => Ok((rem, i[0] as u32)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:38:39 [INFO] [stderr] | [INFO] [stderr] 38 | 2 => Ok((rem, (i[0] as u32) << 8 | (i[1] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:38:61 [INFO] [stderr] | [INFO] [stderr] 38 | 2 => Ok((rem, (i[0] as u32) << 8 | (i[1] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | 3 => Ok((rem, (i[0] as u32) << 16 | (i[1] as u32) << 8 | (i[2] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:39:61 [INFO] [stderr] | [INFO] [stderr] 39 | 3 => Ok((rem, (i[0] as u32) << 16 | (i[1] as u32) << 8 | (i[2] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:39:82 [INFO] [stderr] | [INFO] [stderr] 39 | 3 => Ok((rem, (i[0] as u32) << 16 | (i[1] as u32) << 8 | (i[2] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:39 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:61 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:83 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:104 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:76:11 [INFO] [stderr] | [INFO] [stderr] 76 | acc = i[0] as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | acc = (acc << 7) | (c & 0b0111_1111) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c & 0b0111_1111)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | 0 => len.1 as u64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(len.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/der_parser.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn der_read_element_content_as(i:&[u8], tag:u8, len:usize) -> IResult<&[u8], DerObjectContent> { [INFO] [stderr] 135 | | match tag { [INFO] [stderr] 136 | | // 0x00 end-of-content [INFO] [stderr] 137 | | // 0x01 bool [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:589:38 [INFO] [stderr] | [INFO] [stderr] 589 | error_if!(hdr.len > ::std::u32::MAX as u64, ErrorKind::Custom(DER_INVALID_LENGTH)) >> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in der_obj.ref_iter().enumerate()` or similar iterators [INFO] [stderr] --> src/der.rs:555:14 [INFO] [stderr] | [INFO] [stderr] 555 | for v in der_obj.ref_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:37:39 [INFO] [stderr] | [INFO] [stderr] 37 | 1 => Ok((rem, i[0] as u32)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:38:39 [INFO] [stderr] | [INFO] [stderr] 38 | 2 => Ok((rem, (i[0] as u32) << 8 | (i[1] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:38:61 [INFO] [stderr] | [INFO] [stderr] 38 | 2 => Ok((rem, (i[0] as u32) << 8 | (i[1] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:39:39 [INFO] [stderr] | [INFO] [stderr] 39 | 3 => Ok((rem, (i[0] as u32) << 16 | (i[1] as u32) << 8 | (i[2] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:39:61 [INFO] [stderr] | [INFO] [stderr] 39 | 3 => Ok((rem, (i[0] as u32) << 16 | (i[1] as u32) << 8 | (i[2] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:39:82 [INFO] [stderr] | [INFO] [stderr] 39 | 3 => Ok((rem, (i[0] as u32) << 16 | (i[1] as u32) << 8 | (i[2] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:39 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:61 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:83 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:40:104 [INFO] [stderr] | [INFO] [stderr] 40 | 4 => Ok((rem, (i[0] as u32) << 24 | (i[1] as u32) << 16 | (i[2] as u32) << 8 | (i[3] as u32) )), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:76:11 [INFO] [stderr] | [INFO] [stderr] 76 | acc = i[0] as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:82:28 [INFO] [stderr] | [INFO] [stderr] 82 | acc = (acc << 7) | (c & 0b0111_1111) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c & 0b0111_1111)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | 0 => len.1 as u64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(len.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/der_parser.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn der_read_element_content_as(i:&[u8], tag:u8, len:usize) -> IResult<&[u8], DerObjectContent> { [INFO] [stderr] 135 | | match tag { [INFO] [stderr] 136 | | // 0x00 end-of-content [INFO] [stderr] 137 | | // 0x01 bool [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/der_parser.rs:589:38 [INFO] [stderr] | [INFO] [stderr] 589 | error_if!(hdr.len > ::std::u32::MAX as u64, ErrorKind::Custom(DER_INVALID_LENGTH)) >> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/constructed.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting function pointer `parse_der_integer` to `u8`, which truncates the value [INFO] [stderr] --> tests/constructed.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | parse_der_tagged!(bytes as &[u8],IMPLICIT 3,parse_der_integer), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::fn_to_numeric_cast_with_truncation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#fn_to_numeric_cast_with_truncation [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.47s [INFO] running `"docker" "inspect" "f9dce78d19b67cbb02b4a5d058042daef0e1e19cfb0f6b0b1f7cd831c8f95eea"` [INFO] running `"docker" "rm" "-f" "f9dce78d19b67cbb02b4a5d058042daef0e1e19cfb0f6b0b1f7cd831c8f95eea"` [INFO] [stdout] f9dce78d19b67cbb02b4a5d058042daef0e1e19cfb0f6b0b1f7cd831c8f95eea