[INFO] crate depot 0.2.0 is already in cache [INFO] extracting crate depot 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/depot/0.2.0 [INFO] extracting crate depot 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/depot/0.2.0 [INFO] validating manifest of depot-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of depot-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing depot-0.2.0 [INFO] finished frobbing depot-0.2.0 [INFO] frobbed toml for depot-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/depot/0.2.0/Cargo.toml [INFO] started frobbing depot-0.2.0 [INFO] finished frobbing depot-0.2.0 [INFO] frobbed toml for depot-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/depot/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting depot-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/depot/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e4dcc12ca487c2dca0dcce5825ee172e9d430503c1d2399ee0436cff44db256 [INFO] running `"docker" "start" "-a" "6e4dcc12ca487c2dca0dcce5825ee172e9d430503c1d2399ee0436cff44db256"` [INFO] [stderr] Checking depot v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/queue.rs:195:28 [INFO] [stderr] | [INFO] [stderr] 195 | max_file_size: 2147287039, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_287_039` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/section.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/section.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | let result = if id > max_item_size as usize { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 117 | | always_fail = true; [INFO] [stderr] 118 | | [INFO] [stderr] 119 | | Err(io::Error::new( [INFO] [stderr] ... | [INFO] [stderr] 126 | | Self::parse_item(position, item, known_eof) [INFO] [stderr] 127 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let v = MAX_COMPONENT_VALUE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(MAX_COMPONENT_VALUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | let v = MAX_COMPONENT_VALUE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(MAX_COMPONENT_VALUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | self.one as u32 * v * v * v [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.one)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | + self.two as u32 * v * v [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.two)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:85:15 [INFO] [stderr] | [INFO] [stderr] 85 | + self.three as u32 * v [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.three)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:86:15 [INFO] [stderr] | [INFO] [stderr] 86 | + self.four as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.four)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/queue.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn is_empty(&mut self) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/queue.rs:246:20 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn is_full(&mut self) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/queue.rs:486:25 [INFO] [stderr] | [INFO] [stderr] 486 | if name.starts_with("d") && len > 1 { [INFO] [stderr] | ^^^ help: try using a char instead: `'d'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/queue.rs:511:43 [INFO] [stderr] | [INFO] [stderr] 511 | let path = path.as_ref().join(format!("d0")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"d0".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/queue.rs:532:43 [INFO] [stderr] | [INFO] [stderr] 532 | let path = path.as_ref().join(format!("d0")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"d0".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:559:13 [INFO] [stderr] | [INFO] [stderr] 559 | let f = component.encode() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(component.encode())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:560:13 [INFO] [stderr] | [INFO] [stderr] 560 | let s = section_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | const MARKER_ESCAPE: u8 = '\\' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\\' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | const MARKER_SEPARATOR: u8 = '\n' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | const MARKER_SEPARATOR_REMAP: u8 = '$' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'$' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | const MARKER_FAIL: u8 = '-' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | const MARKER_FAIL_REMAP: u8 = '.' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'.' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | file.seek(SeekFrom::Start(requested_id as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(requested_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:279:21 [INFO] [stderr] | [INFO] [stderr] 279 | if length > FAIL_FILE_SIZE as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(FAIL_FILE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:343:35 [INFO] [stderr] | [INFO] [stderr] 343 | file.seek(SeekFrom::Start(position as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:457:35 [INFO] [stderr] | [INFO] [stderr] 457 | file.seek(SeekFrom::Start(starting_at as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(starting_at)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/queue.rs:195:28 [INFO] [stderr] | [INFO] [stderr] 195 | max_file_size: 2147287039, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_287_039` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/queue.rs:590:9 [INFO] [stderr] | [INFO] [stderr] 590 | 8589934587705032705, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `8_589_934_587_705_032_705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/queue.rs:613:62 [INFO] [stderr] | [INFO] [stderr] 613 | Queue::config(&PathBuf::from(&tmp_path), 8388608, 65536, 8192, 8192); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/queue.rs:630:70 [INFO] [stderr] | [INFO] [stderr] 630 | let queue = Queue::config(&PathBuf::from(&tmp_path), 8388608, 65536, 8192, 8192); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/queue.rs:660:70 [INFO] [stderr] | [INFO] [stderr] 660 | let mut queue = Queue::config(&PathBuf::from(&tmp_path), 8388608, 65536, 8192, 8192); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/queue.rs:674:66 [INFO] [stderr] | [INFO] [stderr] 674 | let queue = Queue::config(&PathBuf::from(&tmp_path), 8388608, 65536, 8192, 8192); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/section.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/section.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | let result = if id > max_item_size as usize { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 117 | | always_fail = true; [INFO] [stderr] 118 | | [INFO] [stderr] 119 | | Err(io::Error::new( [INFO] [stderr] ... | [INFO] [stderr] 126 | | Self::parse_item(position, item, known_eof) [INFO] [stderr] 127 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let v = MAX_COMPONENT_VALUE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(MAX_COMPONENT_VALUE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | let v = MAX_COMPONENT_VALUE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(MAX_COMPONENT_VALUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | self.one as u32 * v * v * v [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.one)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | + self.two as u32 * v * v [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.two)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:85:15 [INFO] [stderr] | [INFO] [stderr] 85 | + self.three as u32 * v [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.three)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:86:15 [INFO] [stderr] | [INFO] [stderr] 86 | + self.four as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(self.four)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/queue.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | pub fn is_empty(&mut self) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/queue.rs:246:20 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn is_full(&mut self) -> io::Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/queue.rs:486:25 [INFO] [stderr] | [INFO] [stderr] 486 | if name.starts_with("d") && len > 1 { [INFO] [stderr] | ^^^ help: try using a char instead: `'d'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/queue.rs:511:43 [INFO] [stderr] | [INFO] [stderr] 511 | let path = path.as_ref().join(format!("d0")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"d0".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/queue.rs:532:43 [INFO] [stderr] | [INFO] [stderr] 532 | let path = path.as_ref().join(format!("d0")); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"d0".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:559:13 [INFO] [stderr] | [INFO] [stderr] 559 | let f = component.encode() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(component.encode())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/queue.rs:560:13 [INFO] [stderr] | [INFO] [stderr] 560 | let s = section_offset as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/queue.rs:635:32 [INFO] [stderr] | [INFO] [stderr] 635 | if let Some(_) = reader.next() { [INFO] [stderr] | _________________________- ^^^^^^^ [INFO] [stderr] 636 | | break; [INFO] [stderr] 637 | | } else { [INFO] [stderr] 638 | | thread::sleep(time::Duration::from_millis(10)); [INFO] [stderr] 639 | | } [INFO] [stderr] | |_________________________- help: try this: `if reader.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/queue.rs:679:28 [INFO] [stderr] | [INFO] [stderr] 679 | if let Some(_) = reader.next() { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 680 | | break; [INFO] [stderr] 681 | | } else { [INFO] [stderr] 682 | | thread::sleep(time::Duration::from_millis(10)); [INFO] [stderr] 683 | | } [INFO] [stderr] | |_____________________- help: try this: `if reader.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | const MARKER_ESCAPE: u8 = '\\' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\\' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | const MARKER_SEPARATOR: u8 = '\n' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | const MARKER_SEPARATOR_REMAP: u8 = '$' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'$' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | const MARKER_FAIL: u8 = '-' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/section.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | const MARKER_FAIL_REMAP: u8 = '.' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'.' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | file.seek(SeekFrom::Start(requested_id as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(requested_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:279:21 [INFO] [stderr] | [INFO] [stderr] 279 | if length > FAIL_FILE_SIZE as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(FAIL_FILE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:343:35 [INFO] [stderr] | [INFO] [stderr] 343 | file.seek(SeekFrom::Start(position as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/section.rs:457:35 [INFO] [stderr] | [INFO] [stderr] 457 | file.seek(SeekFrom::Start(starting_at as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(starting_at)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "6e4dcc12ca487c2dca0dcce5825ee172e9d430503c1d2399ee0436cff44db256"` [INFO] running `"docker" "rm" "-f" "6e4dcc12ca487c2dca0dcce5825ee172e9d430503c1d2399ee0436cff44db256"` [INFO] [stdout] 6e4dcc12ca487c2dca0dcce5825ee172e9d430503c1d2399ee0436cff44db256