[INFO] crate dep-check 0.1.0 is already in cache [INFO] extracting crate dep-check 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dep-check/0.1.0 [INFO] extracting crate dep-check 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dep-check/0.1.0 [INFO] validating manifest of dep-check-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dep-check-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dep-check-0.1.0 [INFO] finished frobbing dep-check-0.1.0 [INFO] frobbed toml for dep-check-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dep-check/0.1.0/Cargo.toml [INFO] started frobbing dep-check-0.1.0 [INFO] finished frobbing dep-check-0.1.0 [INFO] frobbed toml for dep-check-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dep-check/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dep-check-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dep-check/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59d6a0ac1745d18fad40d6cbc9a2d09ec831a61edb1bceb3fbcb76d746f04d37 [INFO] running `"docker" "start" "-a" "59d6a0ac1745d18fad40d6cbc9a2d09ec831a61edb1bceb3fbcb76d746f04d37"` [INFO] [stderr] Checking crates-index v0.12.1 [INFO] [stderr] Checking dep-check v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:110:2 [INFO] [stderr] | [INFO] [stderr] 110 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:138:2 [INFO] [stderr] | [INFO] [stderr] 138 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:110:2 [INFO] [stderr] | [INFO] [stderr] 110 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:138:2 [INFO] [stderr] | [INFO] [stderr] 138 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:96:101 [INFO] [stderr] | [INFO] [stderr] 96 | let mut requirement_list: Vec<(VersionReq, u32)> = requirement_map.iter().map(|(r, n)| (r.clone(), n.clone())).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:103:89 [INFO] [stderr] | [INFO] [stderr] 103 | let mut feature_list: Vec<(String, u32)> = feature_map.iter().map(|(f, n)| (f.clone(), n.clone())).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:106:25 [INFO] [stderr] | [INFO] [stderr] 106 | let mut resolved_list: Vec<(VersionNo, (u32, Vec<(String, u32)>))> = resolved_map.iter().map(|(f, v)| (f.clone(), (v.0.clone(), v.1.iter().map(|(f, n)| (f.clone(), n.clone()) ).collect()))).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:117 [INFO] [stderr] | [INFO] [stderr] 106 | let mut resolved_list: Vec<(VersionNo, (u32, Vec<(String, u32)>))> = resolved_map.iter().map(|(f, v)| (f.clone(), (v.0.clone(), v.1.iter().map(|(f, n)| (f.clone(), n.clone()) ).collect()))).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `v.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:166 [INFO] [stderr] | [INFO] [stderr] 106 | let mut resolved_list: Vec<(VersionNo, (u32, Vec<(String, u32)>))> = resolved_map.iter().map(|(f, v)| (f.clone(), (v.0.clone(), v.1.iter().map(|(f, n)| (f.clone(), n.clone()) ).collect()))).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | n as f64 / total_deps as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | n as f64 / total_deps as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | v.0 as f64 / total_deps as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(v.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | n as f64 / v.0 as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | n as f64 / v.0 as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(v.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:96:101 [INFO] [stderr] | [INFO] [stderr] 96 | let mut requirement_list: Vec<(VersionReq, u32)> = requirement_map.iter().map(|(r, n)| (r.clone(), n.clone())).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:103:89 [INFO] [stderr] | [INFO] [stderr] 103 | let mut feature_list: Vec<(String, u32)> = feature_map.iter().map(|(f, n)| (f.clone(), n.clone())).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:106:25 [INFO] [stderr] | [INFO] [stderr] 106 | let mut resolved_list: Vec<(VersionNo, (u32, Vec<(String, u32)>))> = resolved_map.iter().map(|(f, v)| (f.clone(), (v.0.clone(), v.1.iter().map(|(f, n)| (f.clone(), n.clone()) ).collect()))).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:117 [INFO] [stderr] | [INFO] [stderr] 106 | let mut resolved_list: Vec<(VersionNo, (u32, Vec<(String, u32)>))> = resolved_map.iter().map(|(f, v)| (f.clone(), (v.0.clone(), v.1.iter().map(|(f, n)| (f.clone(), n.clone()) ).collect()))).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `v.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:106:166 [INFO] [stderr] | [INFO] [stderr] 106 | let mut resolved_list: Vec<(VersionNo, (u32, Vec<(String, u32)>))> = resolved_map.iter().map(|(f, v)| (f.clone(), (v.0.clone(), v.1.iter().map(|(f, n)| (f.clone(), n.clone()) ).collect()))).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | n as f64 / total_deps as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | n as f64 / total_deps as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | v.0 as f64 / total_deps as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(v.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | n as f64 / v.0 as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | n as f64 / v.0 as f64 * 100.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(v.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.02s [INFO] running `"docker" "inspect" "59d6a0ac1745d18fad40d6cbc9a2d09ec831a61edb1bceb3fbcb76d746f04d37"` [INFO] running `"docker" "rm" "-f" "59d6a0ac1745d18fad40d6cbc9a2d09ec831a61edb1bceb3fbcb76d746f04d37"` [INFO] [stdout] 59d6a0ac1745d18fad40d6cbc9a2d09ec831a61edb1bceb3fbcb76d746f04d37