[INFO] crate densevec 0.3.1 is already in cache [INFO] extracting crate densevec 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/densevec/0.3.1 [INFO] extracting crate densevec 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/densevec/0.3.1 [INFO] validating manifest of densevec-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of densevec-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing densevec-0.3.1 [INFO] finished frobbing densevec-0.3.1 [INFO] frobbed toml for densevec-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/densevec/0.3.1/Cargo.toml [INFO] started frobbing densevec-0.3.1 [INFO] finished frobbing densevec-0.3.1 [INFO] frobbed toml for densevec-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/densevec/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting densevec-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/densevec/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e04f8db025e1b3cf6fd947c0f2451ce173622f792d5003aa5ce354de2c49c7ac [INFO] running `"docker" "start" "-a" "e04f8db025e1b3cf6fd947c0f2451ce173622f792d5003aa5ce354de2c49c7ac"` [INFO] [stderr] Checking densevec v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:317:36 [INFO] [stderr] | [INFO] [stderr] 317 | .find(|result| match result{ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 318 | | &Err(_) => true, [INFO] [stderr] 319 | | &Ok(()) => false, [INFO] [stderr] 320 | | }).unwrap_or(Ok(())) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 317 | .find(|result| match *result{ [INFO] [stderr] 318 | Err(_) => true, [INFO] [stderr] 319 | Ok(()) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:1290:19 [INFO] [stderr] | [INFO] [stderr] 1290 | .map(|i| a.insert_key_gen(0)) [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:317:36 [INFO] [stderr] | [INFO] [stderr] 317 | .find(|result| match result{ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 318 | | &Err(_) => true, [INFO] [stderr] 319 | | &Ok(()) => false, [INFO] [stderr] 320 | | }).unwrap_or(Ok(())) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 317 | .find(|result| match *result{ [INFO] [stderr] 318 | Err(_) => true, [INFO] [stderr] 319 | Ok(()) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/lib.rs:744:5 [INFO] [stderr] | [INFO] [stderr] 744 | / fn test_lots_of_insertions() { [INFO] [stderr] 745 | | let mut m = DenseVec::new(); [INFO] [stderr] 746 | | [INFO] [stderr] 747 | | // Try this a few times to make sure we never screw up the densevec's [INFO] [stderr] ... | [INFO] [stderr] 803 | | } [INFO] [stderr] 804 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:755:26 [INFO] [stderr] | [INFO] [stderr] 755 | for j in 1..i + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:774:26 [INFO] [stderr] | [INFO] [stderr] 774 | for j in 1..i + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:927:13 [INFO] [stderr] | [INFO] [stderr] 927 | *value = (*value) * 2 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value *= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/lib.rs:1120:9 [INFO] [stderr] | [INFO] [stderr] 1120 | map[4]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1256:18 [INFO] [stderr] | [INFO] [stderr] 1256 | a.insert(key.clone(), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:1256:31 [INFO] [stderr] | [INFO] [stderr] 1256 | a.insert(key.clone(), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 1256 | a.insert(key.clone(), &(*value).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 1256 | a.insert(key.clone(), &str::clone(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1260:23 [INFO] [stderr] | [INFO] [stderr] 1260 | match a.entry(key.clone()) { [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1275:23 [INFO] [stderr] | [INFO] [stderr] 1275 | match a.entry(key.clone()) { [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:1279:26 [INFO] [stderr] | [INFO] [stderr] 1279 | e.insert(value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 1279 | e.insert(&(*value).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 1279 | e.insert(&str::clone(value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `densevec`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e04f8db025e1b3cf6fd947c0f2451ce173622f792d5003aa5ce354de2c49c7ac"` [INFO] running `"docker" "rm" "-f" "e04f8db025e1b3cf6fd947c0f2451ce173622f792d5003aa5ce354de2c49c7ac"` [INFO] [stdout] e04f8db025e1b3cf6fd947c0f2451ce173622f792d5003aa5ce354de2c49c7ac