[INFO] crate deltamap 0.2.2 is already in cache [INFO] extracting crate deltamap 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/deltamap/0.2.2 [INFO] extracting crate deltamap 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/deltamap/0.2.2 [INFO] validating manifest of deltamap-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deltamap-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deltamap-0.2.2 [INFO] finished frobbing deltamap-0.2.2 [INFO] frobbed toml for deltamap-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/deltamap/0.2.2/Cargo.toml [INFO] started frobbing deltamap-0.2.2 [INFO] finished frobbing deltamap-0.2.2 [INFO] frobbed toml for deltamap-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/deltamap/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deltamap-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/deltamap/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9ae72cb9533407e7499ba70a065b40ea27c4ec002572bbfec1dda6f9e5c79397 [INFO] running `"docker" "start" "-a" "9ae72cb9533407e7499ba70a065b40ea27c4ec002572bbfec1dda6f9e5c79397"` [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling glutin v0.19.0 [INFO] [stderr] Compiling deltamap v0.2.2 (/opt/crater/workdir) [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking osmpbf v0.1.12 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking http v0.1.15 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/context.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/context.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/context.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/search.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | MatchItem::Node{id, pos: _} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Node { id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/search.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | MatchItem::Way{id, nodes: _} => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Way { id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/search.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | MatchItem::WayNode{id, pos: _} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `WayNode { id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/context.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/query.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/search.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | MatchItem::Node{id, pos: _} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Node { id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/search.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | MatchItem::Way{id, nodes: _} => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Way { id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/search.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | MatchItem::WayNode{id, pos: _} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `WayNode { id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/orthografic_view.rs:451:31 [INFO] [stderr] | [INFO] [stderr] 451 | pub fn zoom_at(&mut self, pos: ScreenCoord, zoom_delta: f64) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/orthografic_view.rs:467:35 [INFO] [stderr] | [INFO] [stderr] 467 | pub fn set_zoom_at(&mut self, pos: ScreenCoord, zoom: f64) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cx` [INFO] [stderr] --> src/path_layer.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | cx: &mut Context, [INFO] [stderr] | ^^ help: consider using `_cx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ortho` [INFO] [stderr] --> src/path_layer.rs:379:9 [INFO] [stderr] | [INFO] [stderr] 379 | ortho: &OrthograficView, [INFO] [stderr] | ^^^^^ help: consider using `_ortho` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dpi_factor` [INFO] [stderr] --> src/path_layer.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | dpi_factor: f64, [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_dpi_factor` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/orthografic_view.rs:451:31 [INFO] [stderr] | [INFO] [stderr] 451 | pub fn zoom_at(&mut self, pos: ScreenCoord, zoom_delta: f64) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/orthografic_view.rs:467:35 [INFO] [stderr] | [INFO] [stderr] 467 | pub fn set_zoom_at(&mut self, pos: ScreenCoord, zoom: f64) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cx` [INFO] [stderr] --> src/path_layer.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | cx: &mut Context, [INFO] [stderr] | ^^ help: consider using `_cx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ortho` [INFO] [stderr] --> src/path_layer.rs:379:9 [INFO] [stderr] | [INFO] [stderr] 379 | ortho: &OrthograficView, [INFO] [stderr] | ^^^^^ help: consider using `_ortho` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `dpi_factor` [INFO] [stderr] --> src/path_layer.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | dpi_factor: f64, [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_dpi_factor` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/ortho_tile_layer.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn new(view_center: LatLonRad, viewport_size: (u32, u32), sphere_radius: f64, lat: f64) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/ortho_tile_layer.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn new(view_center: LatLonRad, viewport_size: (u32, u32), sphere_radius: f64, lat: f64) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/context.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/buffer.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/config.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | / loop { [INFO] [stderr] 83 | | if let (Some(k), Some(v)) = (kv.next(), kv.next()) { [INFO] [stderr] 84 | | vec.push((k.to_string(), v.to_string())); [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | break; [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________^ help: try: `while let (Some(k), Some(v)) = (kv.next(), kv.next()) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/config.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / loop { [INFO] [stderr] 98 | | if let (Some(k), Some(v)) = (kv.next(), kv.next()) { [INFO] [stderr] 99 | | vec.push((k.to_string(), v.to_string())); [INFO] [stderr] 100 | | } else { [INFO] [stderr] 101 | | break; [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ help: try: `while let (Some(k), Some(v)) = (kv.next(), kv.next()) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/context.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/buffer.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/config.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | / loop { [INFO] [stderr] 83 | | if let (Some(k), Some(v)) = (kv.next(), kv.next()) { [INFO] [stderr] 84 | | vec.push((k.to_string(), v.to_string())); [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | break; [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________________^ help: try: `while let (Some(k), Some(v)) = (kv.next(), kv.next()) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/config.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | / loop { [INFO] [stderr] 98 | | if let (Some(k), Some(v)) = (kv.next(), kv.next()) { [INFO] [stderr] 99 | | vec.push((k.to_string(), v.to_string())); [INFO] [stderr] 100 | | } else { [INFO] [stderr] 101 | | break; [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ help: try: `while let (Some(k), Some(v)) = (kv.next(), kv.next()) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:300:32 [INFO] [stderr] | [INFO] [stderr] 300 | vertices.iter().fold(false, |acc, v| acc || v.x >= -1.0) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.x >= -1.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:301:32 [INFO] [stderr] | [INFO] [stderr] 301 | vertices.iter().fold(false, |acc, v| acc || v.x <= 1.0) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.x <= 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:302:32 [INFO] [stderr] | [INFO] [stderr] 302 | vertices.iter().fold(false, |acc, v| acc || v.y >= -1.0) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.y >= -1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:303:32 [INFO] [stderr] | [INFO] [stderr] 303 | vertices.iter().fold(false, |acc, v| acc || v.y <= 1.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.y <= 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/path_layer.rs:322:53 [INFO] [stderr] | [INFO] [stderr] 322 | start_normal = start_normal.or(Some(normal_b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(normal_b))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/path_layer.rs:328:47 [INFO] [stderr] | [INFO] [stderr] 328 | start_point = start_point.or(Some(point_b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(point_b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/program.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/coord.rs:498:25 [INFO] [stderr] | [INFO] [stderr] 498 | let mut b = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/query.rs:292:19 [INFO] [stderr] | [INFO] [stderr] 292 | matches: &mut HashSet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 289 | pub fn find_query_matches( [INFO] [stderr] 290 | block: &PrimitiveBlock, [INFO] [stderr] 291 | query: &Q, [INFO] [stderr] 292 | matches: &mut HashSet, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/query.rs:293:24 [INFO] [stderr] | [INFO] [stderr] 293 | way_node_ids: &mut HashSet, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 289 | pub fn find_query_matches( [INFO] [stderr] 290 | block: &PrimitiveBlock, [INFO] [stderr] 291 | query: &Q, [INFO] [stderr] 292 | matches: &mut HashSet, [INFO] [stderr] 293 | way_node_ids: &mut HashSet, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/search.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / match query { [INFO] [stderr] 99 | | &QueryKind::ValuePattern(ref query) => { [INFO] [stderr] 100 | | find_query_matches(block, query, &mut matches, &mut way_node_ids); [INFO] [stderr] 101 | | }, [INFO] [stderr] ... | [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *query { [INFO] [stderr] 99 | QueryKind::ValuePattern(ref query) => { [INFO] [stderr] 100 | find_query_matches(block, query, &mut matches, &mut way_node_ids); [INFO] [stderr] 101 | }, [INFO] [stderr] 102 | QueryKind::KeyValue(ref query) => { [INFO] [stderr] 103 | find_query_matches(block, query, &mut matches, &mut way_node_ids); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/url_template.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | fn max_size(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vertex_attrib.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:300:32 [INFO] [stderr] | [INFO] [stderr] 300 | vertices.iter().fold(false, |acc, v| acc || v.x >= -1.0) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.x >= -1.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:301:32 [INFO] [stderr] | [INFO] [stderr] 301 | vertices.iter().fold(false, |acc, v| acc || v.x <= 1.0) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.x <= 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:302:32 [INFO] [stderr] | [INFO] [stderr] 302 | vertices.iter().fold(false, |acc, v| acc || v.y >= -1.0) && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.y >= -1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:137:55 [INFO] [stderr] | [INFO] [stderr] 137 | PathElement::MoveTo((*query_state.way_nodes.get(&way[0]).unwrap()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[0]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:143:55 [INFO] [stderr] | [INFO] [stderr] 143 | PathElement::MoveTo((*query_state.way_nodes.get(&way[0]).unwrap()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/orthografic_view.rs:303:32 [INFO] [stderr] | [INFO] [stderr] 303 | vertices.iter().fold(false, |acc, v| acc || v.y <= 1.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.any(|v| v.y <= 1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:146:55 [INFO] [stderr] | [INFO] [stderr] 146 | PathElement::LineTo((*query_state.way_nodes.get(&way[1]).unwrap()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[1]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:150:72 [INFO] [stderr] | [INFO] [stderr] 150 | map.add_path_element(PathElement::MoveTo((*query_state.way_nodes.get(&way[0]).unwrap()).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:154:80 [INFO] [stderr] | [INFO] [stderr] 154 | map.add_path_element(PathElement::LineTo((*query_state.way_nodes.get(node_id).unwrap()).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[node_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:159:80 [INFO] [stderr] | [INFO] [stderr] 159 | map.add_path_element(PathElement::LineTo((*query_state.way_nodes.get(node_id).unwrap()).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[node_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:512:17 [INFO] [stderr] | [INFO] [stderr] 512 | assert!(result.iter().find(|&&x| x == TileNeighbor::Coord(TileCoord::new(1, 1, 0))).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::Coord(TileCoord::new(1, 1, 0))).is_some()` with `any(|&&x| x == TileNeighbor::Coord(TileCoord::new(1, 1, 0)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:513:17 [INFO] [stderr] | [INFO] [stderr] 513 | assert!(result.iter().find(|&&x| x == TileNeighbor::Coord(TileCoord::new(1, 0, 1))).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::Coord(TileCoord::new(1, 0, 1))).is_some()` with `any(|&&x| x == TileNeighbor::Coord(TileCoord::new(1, 0, 1)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:518:17 [INFO] [stderr] | [INFO] [stderr] 518 | assert!(result.iter().find(|&&x| x == TileNeighbor::NorthPole).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::NorthPole).is_some()` with `any(|&&x| x == TileNeighbor::NorthPole)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:522:17 [INFO] [stderr] | [INFO] [stderr] 522 | assert!(result.iter().find(|&&x| x == TileNeighbor::SouthPole).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::SouthPole).is_some()` with `any(|&&x| x == TileNeighbor::SouthPole)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:526:17 [INFO] [stderr] | [INFO] [stderr] 526 | assert!(result.iter().find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 2, 1))).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 2, 1))).is_some()` with `any(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 2, 1)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:527:17 [INFO] [stderr] | [INFO] [stderr] 527 | assert!(result.iter().find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 0, 1))).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 0, 1))).is_some()` with `any(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 0, 1)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:528:17 [INFO] [stderr] | [INFO] [stderr] 528 | assert!(result.iter().find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 3, 0))).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 3, 0))).is_some()` with `any(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 3, 0)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/orthografic_view.rs:529:17 [INFO] [stderr] | [INFO] [stderr] 529 | assert!(result.iter().find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 3, 2))).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 3, 2))).is_some()` with `any(|&&x| x == TileNeighbor::Coord(TileCoord::new(2, 3, 2)))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/path_layer.rs:322:53 [INFO] [stderr] | [INFO] [stderr] 322 | start_normal = start_normal.or(Some(normal_b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(normal_b))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/path_layer.rs:328:47 [INFO] [stderr] | [INFO] [stderr] 328 | start_point = start_point.or(Some(point_b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(point_b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/program.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/query.rs:292:19 [INFO] [stderr] | [INFO] [stderr] 292 | matches: &mut HashSet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 289 | pub fn find_query_matches( [INFO] [stderr] 290 | block: &PrimitiveBlock, [INFO] [stderr] 291 | query: &Q, [INFO] [stderr] 292 | matches: &mut HashSet, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/query.rs:293:24 [INFO] [stderr] | [INFO] [stderr] 293 | way_node_ids: &mut HashSet, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 289 | pub fn find_query_matches( [INFO] [stderr] 290 | block: &PrimitiveBlock, [INFO] [stderr] 291 | query: &Q, [INFO] [stderr] 292 | matches: &mut HashSet, [INFO] [stderr] 293 | way_node_ids: &mut HashSet, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/search.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / match query { [INFO] [stderr] 99 | | &QueryKind::ValuePattern(ref query) => { [INFO] [stderr] 100 | | find_query_matches(block, query, &mut matches, &mut way_node_ids); [INFO] [stderr] 101 | | }, [INFO] [stderr] ... | [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *query { [INFO] [stderr] 99 | QueryKind::ValuePattern(ref query) => { [INFO] [stderr] 100 | find_query_matches(block, query, &mut matches, &mut way_node_ids); [INFO] [stderr] 101 | }, [INFO] [stderr] 102 | QueryKind::KeyValue(ref query) => { [INFO] [stderr] 103 | find_query_matches(block, query, &mut matches, &mut way_node_ids); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/url_template.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | fn max_size(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vertex_attrib.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn index(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:137:55 [INFO] [stderr] | [INFO] [stderr] 137 | PathElement::MoveTo((*query_state.way_nodes.get(&way[0]).unwrap()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[0]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:143:55 [INFO] [stderr] | [INFO] [stderr] 143 | PathElement::MoveTo((*query_state.way_nodes.get(&way[0]).unwrap()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:146:55 [INFO] [stderr] | [INFO] [stderr] 146 | PathElement::LineTo((*query_state.way_nodes.get(&way[1]).unwrap()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[1]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:150:72 [INFO] [stderr] | [INFO] [stderr] 150 | map.add_path_element(PathElement::MoveTo((*query_state.way_nodes.get(&way[0]).unwrap()).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[&way[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:154:80 [INFO] [stderr] | [INFO] [stderr] 154 | map.add_path_element(PathElement::LineTo((*query_state.way_nodes.get(node_id).unwrap()).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[node_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:159:80 [INFO] [stderr] | [INFO] [stderr] 159 | map.add_path_element(PathElement::LineTo((*query_state.way_nodes.get(node_id).unwrap()).into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&query_state.way_nodes[node_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.35s [INFO] running `"docker" "inspect" "9ae72cb9533407e7499ba70a065b40ea27c4ec002572bbfec1dda6f9e5c79397"` [INFO] running `"docker" "rm" "-f" "9ae72cb9533407e7499ba70a065b40ea27c4ec002572bbfec1dda6f9e5c79397"` [INFO] [stdout] 9ae72cb9533407e7499ba70a065b40ea27c4ec002572bbfec1dda6f9e5c79397